[issue18555] type_set_bases() doesn't check return value of PyArg_UnpackTuple()

2013-07-26 Thread Ronald Oussoren 

Ronald Oussoren added the comment:

This appears to be harmless. The contents of the temp list are added by 
mro_subclasses, and that function only adds tuples of 2 elements. That means 
that the call to PyArg_UnpackTuple cannot fail.

It might be better to explicitly document this, either using an assert() or by 
calling Py_FatalError.

--
nosy: +ronaldoussoren

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18555
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18555] type_set_bases() doesn't check return value of PyArg_UnpackTuple()

2013-07-26 Thread Christian Heimes 

Christian Heimes added the comment:

Ah, you are right! Good catch :)

I have marked CID 486265 as intentional / ignore.

--
priority: normal - low
stage: needs patch - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18555
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18555] type_set_bases() doesn't check return value of PyArg_UnpackTuple()

2013-07-26 Thread Christian Heimes 

Changes by Christian Heimes li...@cheimes.de:


--
resolution:  - wont fix
stage:  - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18555
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18555] type_set_bases() doesn't check return value of PyArg_UnpackTuple()

2013-07-25 Thread Christian Heimes 

New submission from Christian Heimes:

http://hg.python.org/cpython/file/be5f1f0bea09/Objects/typeobject.c#l554

CID 486265 (#1 of 1): Unchecked return value (CHECKED_RETURN)
19. check_return: Calling function PyArg_UnpackTuple(PyObject *, char const *, 
Py_ssize_t, Py_ssize_t, ...) without checking return value (as is done 
elsewhere 64 out of 65 times).
PyArg_UnpackTuple(PyList_GET_ITEM(temp, i),
  , 2, 2, cls, mro);

--
components: Interpreter Core
messages: 193702
nosy: christian.heimes
priority: normal
severity: normal
stage: needs patch
status: open
title: type_set_bases() doesn't check return value of  PyArg_UnpackTuple()
type: behavior
versions: Python 3.3, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18555
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com