[issue19085] Add tkinter basic options tests
Serhiy Storchaka added the comment: Thank you Net, Vajrasky and Zachary for your help for testing. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Zachary Ware added the comment: What's the status here? Appears to be fixed? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Ned Deily added the comment: All of the failures I reported are now fixed so I think this issue can be closed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Ned Deily added the comment: I've opened Issue19761 to document the current state of test failures for 3.4.0b1 on OS X with the native Tk 8.5 and 8.4. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Serhiy Storchaka added the comment: test_widgets.ButtonTest is still causing a Cocoa Tk 8.5/8.6 crash which also crashes Python while running the test suite. The test should be fixed or disabled. Opened issue19733 for this. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Ned Deily added the comment: test_widgets.ButtonTest is still causing a Cocoa Tk 8.5/8.6 crash which also crashes Python while running the test suite. The test should be fixed or disabled. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Serhiy Storchaka added the comment: Crashes? It should be separate issue, no one Tkinter operation shouldn't crash Python. Fill free to disable this tests on MacOSX (or better on more specific environment) if they prevent the test suite from running. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Ned Deily added the comment: See msg202006 above. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Roundup Robot added the comment: New changeset be8f9beca8aa by Serhiy Storchaka in branch '2.7': Fix Tkinter tests on Tk 8.5 with patchlevel 8.5.11 (issue #19085). http://hg.python.org/cpython/rev/be8f9beca8aa New changeset 204e66190dbb by Serhiy Storchaka in branch '3.3': Fix Tkinter tests on Tk 8.5 with patchlevel 8.5.11 (issue #19085). http://hg.python.org/cpython/rev/204e66190dbb New changeset 2834e410d1ae by Serhiy Storchaka in branch 'default': Fix Tkinter tests on Tk 8.5 with patchlevel 8.5.11 (issue #19085). http://hg.python.org/cpython/rev/2834e410d1ae -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Zachary Ware added the comment: Looks like the last commit broke 8.5.15 on Windows; in particular, on line 25 of widget_tests.py, int_round doesn't exist. Replacing 'int_round' with 'round' allows most tests to pass, but I still get these two failures: == FAIL: test_insertwidth (tkinter.test.test_tkinter.test_widgets.EntryTest) -- Traceback (most recent call last): File P:\Projects\OSS\Python\cpython\lib\tkinter\test\test_tkinter\test_widget s.py, line 336, in test_insertwidth self.checkParam(widget, 'insertwidth', 0.9, expected=2) File P:\Projects\OSS\Python\cpython\lib\tkinter\test\widget_tests.py, line 6 6, in checkParam self.assertEqual2(widget[name], expected, eq=eq) File P:\Projects\OSS\Python\cpython\lib\tkinter\test\widget_tests.py, line 5 0, in assertEqual2 self.assertEqual(actual, expected, msg) AssertionError: 1 != 2 == FAIL: test_insertwidth (tkinter.test.test_tkinter.test_widgets.SpinboxTest) -- Traceback (most recent call last): File P:\Projects\OSS\Python\cpython\lib\tkinter\test\test_tkinter\test_widget s.py, line 336, in test_insertwidth self.checkParam(widget, 'insertwidth', 0.9, expected=2) File P:\Projects\OSS\Python\cpython\lib\tkinter\test\widget_tests.py, line 6 6, in checkParam self.assertEqual2(widget[name], expected, eq=eq) File P:\Projects\OSS\Python\cpython\lib\tkinter\test\widget_tests.py, line 5 0, in assertEqual2 self.assertEqual(actual, expected, msg) AssertionError: 1 != 2 -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Roundup Robot added the comment: New changeset d5d0356ba5ac by Serhiy Storchaka in branch '3.3': Fix typo in tkinter tests (issue #19085). http://hg.python.org/cpython/rev/d5d0356ba5ac New changeset fc4ef17c7db8 by Serhiy Storchaka in branch 'default': Fix typo in tkinter tests (issue #19085). http://hg.python.org/cpython/rev/fc4ef17c7db8 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Serhiy Storchaka added the comment: Thank you Zachary. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Roundup Robot added the comment: New changeset eb126f976fa2 by Serhiy Storchaka in branch '2.7': Fix test_insertwidth Tkinter tests on Tk 8.5 with patchlevel = 8.5.12 (issue #19085). http://hg.python.org/cpython/rev/eb126f976fa2 New changeset 21fbe3ec90dc by Serhiy Storchaka in branch '3.3': Fix test_insertwidth Tkinter tests on Tk 8.5 with patchlevel = 8.5.12 (issue #19085). http://hg.python.org/cpython/rev/21fbe3ec90dc New changeset ce08158e3f6c by Serhiy Storchaka in branch 'default': Fix test_insertwidth Tkinter tests on Tk 8.5 with patchlevel = 8.5.12 (issue #19085). http://hg.python.org/cpython/rev/ce08158e3f6c -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Zachary Ware added the comment: Working from ce08158e3f6c with 8.5.15 on Windows, I get the same failures with a different AssertionError: == FAIL: test_insertwidth (tkinter.test.test_tkinter.test_widgets.EntryTest) -- Traceback (most recent call last): File P:\Projects\OSS\Python\cpython\lib\tkinter\test\test_tkinter\test_widget s.py, line 340, in test_insertwidth self.checkParam(widget, 'insertwidth', 0.9) File P:\Projects\OSS\Python\cpython\lib\tkinter\test\widget_tests.py, line 6 6, in checkParam self.assertEqual2(widget[name], expected, eq=eq) File P:\Projects\OSS\Python\cpython\lib\tkinter\test\widget_tests.py, line 5 0, in assertEqual2 self.assertEqual(actual, expected, msg) AssertionError: 1 != 0.9 == FAIL: test_insertwidth (tkinter.test.test_tkinter.test_widgets.SpinboxTest) -- Traceback (most recent call last): File P:\Projects\OSS\Python\cpython\lib\tkinter\test\test_tkinter\test_widget s.py, line 340, in test_insertwidth self.checkParam(widget, 'insertwidth', 0.9) File P:\Projects\OSS\Python\cpython\lib\tkinter\test\widget_tests.py, line 6 6, in checkParam self.assertEqual2(widget[name], expected, eq=eq) File P:\Projects\OSS\Python\cpython\lib\tkinter\test\widget_tests.py, line 5 0, in assertEqual2 self.assertEqual(actual, expected, msg) AssertionError: 1 != 0.9 By the way, thank you for all the work you're doing on this, Serhiy! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Zachary Ware added the comment: FTR, both 8.5.11 and 8.6.1 pass all tests on Windows from ce08158e3f6c (with unrelated modifications required to build and use 8.6.1). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Roundup Robot added the comment: New changeset c97600bdd726 by Serhiy Storchaka in branch '2.7': Revert wrong change in previous commit (issue #19085). http://hg.python.org/cpython/rev/c97600bdd726 New changeset bec6df56c053 by Serhiy Storchaka in branch '3.3': Revert wrong change in previous commit (issue #19085). http://hg.python.org/cpython/rev/bec6df56c053 New changeset 545feebd58fb by Serhiy Storchaka in branch 'default': Revert wrong change in previous commit (issue #19085). http://hg.python.org/cpython/rev/545feebd58fb -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Serhiy Storchaka added the comment: My fault. I missed that here is simple checkParam() instead of checkPixelsParam(). Thank you Zachary. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Roundup Robot added the comment: New changeset c3fa22d04fb2 by Serhiy Storchaka in branch '2.7': Issue #19085: Fix Tkinter tests on Tk 8.5 with patchlevel 8.5.12. http://hg.python.org/cpython/rev/c3fa22d04fb2 New changeset 583347b79aa0 by Serhiy Storchaka in branch '3.3': Issue #19085: Fix Tkinter tests on Tk 8.5 with patchlevel 8.5.12. http://hg.python.org/cpython/rev/583347b79aa0 New changeset fe5a829bd645 by Serhiy Storchaka in branch 'default': Issue #19085: Fix Tkinter tests on Tk 8.5 with patchlevel 8.5.12. http://hg.python.org/cpython/rev/fe5a829bd645 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Roundup Robot added the comment: New changeset fe7aaf14b129 by Serhiy Storchaka in branch '2.7': Issue #19085: Fix running test_ttk_textonly on displayless host. http://hg.python.org/cpython/rev/fe7aaf14b129 New changeset 47d3714dcb33 by Serhiy Storchaka in branch '3.3': Issue #19085: Fix running test_ttk_textonly on displayless host. http://hg.python.org/cpython/rev/47d3714dcb33 New changeset 713cc4908a96 by Serhiy Storchaka in branch 'default': Issue #19085: Fix running test_ttk_textonly on displayless host. http://hg.python.org/cpython/rev/713cc4908a96 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Ned Deily added the comment: With Cocoa Tk 8.5.15 or Cocoa Tk 8.6.1 on OS X 10.8.5, test_widgets.ButtonTest crashes Tk: test_image (tkinter.test.test_tkinter.test_widgets.ButtonTest) ... 2013-11-03 01:52:53.498 pytest_10.8[82465:f07] *** Assertion failure in -[NSBitmapImageRep initWithCGImage:], /SourceCache/AppKit/AppKit-1187.40/AppKit.subproj/NSBitmapImageRep.m:1242 2013-11-03 01:52:53.499 pytest_10.8[82465:f07] An uncaught exception was raised 2013-11-03 01:52:53.499 pytest_10.8[82465:f07] Invalid parameter not satisfying: cgImage != NULL 2013-11-03 01:52:53.502 pytest_10.8[82465:f07] ( 0 CoreFoundation 0x965eae8b __raiseError + 219 1 libobjc.A.dylib 0x956d152e objc_exception_throw + 230 2 CoreFoundation 0x9654a698 +[NSException raise:format:arguments:] + 136 3 Foundation 0x966a5364 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 116 4 AppKit 0x98a34525 -[NSBitmapImageRep initWithCGImage:] + 145 5 Tk 0x00725a48 CreateNSImageWithPixmap + 151 6 Tk 0x00725b1c TkMacOSXGetNSImageWithTkImage + 149 7 Tk 0x0071eb2f TkpComputeButtonGeometry + 2550 8 Tk 0x0069849d TkButtonWorldChanged + 470 9 Tk 0x00698e99 ConfigureButton + 1981 10 Tk 0x0069980f ButtonWidgetObjCmd + 440 11 Tcl 0x00579c2f TclEvalObjvInternal + 770 12 Tcl 0x0057ac1a Tcl_EvalObjv + 72 13 _tkinter.so 0x0055db81 Tkapp_Call + 673 [...] With Carbon Tk 8.4.20 on OS X 10.8.5, two test_insertborderwidth failures: == FAIL: test_insertborderwidth (tkinter.test.test_tkinter.test_widgets.EntryTest) -- Traceback (most recent call last): File /py/dev/3x/root/fwd32/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/test_tkinter/test_widgets.py, line 327, in test_insertborderwidth self.checkPixelsParam(widget, 'insertborderwidth', 0, 1.3, -2) File /py/dev/3x/root/fwd32/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/widget_tests.py, line 158, in checkPixelsParam conv=conv1, **kwargs) File /py/dev/3x/root/fwd32/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/widget_tests.py, line 48, in checkParam self.assertEqual2(widget[name], expected, eq=eq) File /py/dev/3x/root/fwd32/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/widget_tests.py, line 32, in assertEqual2 self.assertEqual(actual, expected, msg) AssertionError: 0 != 1 == FAIL: test_insertborderwidth (tkinter.test.test_tkinter.test_widgets.SpinboxTest) -- Traceback (most recent call last): File /py/dev/3x/root/fwd32/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/test_tkinter/test_widgets.py, line 327, in test_insertborderwidth self.checkPixelsParam(widget, 'insertborderwidth', 0, 1.3, -2) File /py/dev/3x/root/fwd32/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/widget_tests.py, line 158, in checkPixelsParam conv=conv1, **kwargs) File /py/dev/3x/root/fwd32/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/widget_tests.py, line 48, in checkParam self.assertEqual2(widget[name], expected, eq=eq) File /py/dev/3x/root/fwd32/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/widget_tests.py, line 32, in assertEqual2 self.assertEqual(actual, expected, msg) AssertionError: 0 != 1 -- Ran 536 tests in 1.149s FAILED (failures=2, skipped=10) -- priority: high - critical ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Serhiy Storchaka added the comment: Yes, I know. Here is a list of broken buildbots: http://buildbot.python.org/all/builders/x86%20FreeBSD%206.4%203.x http://buildbot.python.org/all/builders/x86%20FreeBSD%207.2%203.x http://buildbot.python.org/all/builders/x86%20FreeBSD%206.4%203.3 http://buildbot.python.org/all/builders/x86%20Tiger%203.3 http://buildbot.python.org/all/builders/x86%20Windows7%202.7 http://buildbot.python.org/all/builders/x86%20XP-4%202.7 http://buildbot.python.org/all/builders/x86%20FreeBSD%206.4%202.7 http://buildbot.python.org/all/builders/x86%20FreeBSD%207.2%202.7 On Tiger only two tests failed, on other buildbots multiple tests failed and symptoms look as differences between 8.5 and 8.4 or 8.5 (Tk version is wrongly detected?). I'm working on this. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Vajrasky Kok added the comment: Serhiy, In Python3.4, Windows Vista 32 bit, Release Mode, Tcl/Tk 8.5.15, I got a lot of errors. However, if I set _conv_pixels to round in Lib/tkinter/test/widget_tests.py, everything works fine. In Python 3.4, Fedora 18, Debug Mode, Tcl/Tk 8.5.13, I got a lot of errors. However, if I set _conv_pixels to round in Lib/tkinter/test/widget_tests.py, I got two errors only. == FAIL: test_insertwidth (__main__.EntryTest) -- Traceback (most recent call last): File Lib/tkinter/test/test_tkinter/test_widgets.py, line 335, in test_insertwidth self.checkParam(widget, 'insertwidth', 0.9, expected=2) File /home/sky/Code/python/programming_language/cpython/Lib/tkinter/test/widget_tests.py, line 49, in checkParam self.assertEqual2(widget[name], expected, eq=eq) File /home/sky/Code/python/programming_language/cpython/Lib/tkinter/test/widget_tests.py, line 33, in assertEqual2 self.assertEqual(actual, expected, msg) AssertionError: 1 != 2 Other error is same. Hope that helps! -- nosy: +vajrasky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Roundup Robot added the comment: New changeset a34889a30d52 by Serhiy Storchaka in branch '2.7': Issue #19085: Fixed pixels rounding for last Tk patchlevels. http://hg.python.org/cpython/rev/a34889a30d52 New changeset dfdf47a9aad4 by Serhiy Storchaka in branch '3.3': Issue #19085: Fixed pixels rounding for last Tk patchlevels. http://hg.python.org/cpython/rev/dfdf47a9aad4 New changeset e7be7aceab77 by Serhiy Storchaka in branch 'default': Issue #19085: Fixed pixels rounding for last Tk patchlevels. http://hg.python.org/cpython/rev/e7be7aceab77 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Serhiy Storchaka added the comment: Thanks Vajrasky. Now I see that this is a bug in Tk 8.5 which was fixed in 8.5.12. We should use round() to conform with last Tk patchlevels. However this breaks tests on Ubuntu 12.04 LTS which uses 8.5.11. Here is a patch which adds workaround for this bug. -- Added file: http://bugs.python.org/file32482/pixels_round.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Roundup Robot added the comment: New changeset 92e268f2719e by Serhiy Storchaka in branch '3.3': Issue #19085: Added basic tests for all tkinter widget options. http://hg.python.org/cpython/rev/92e268f2719e New changeset ab7c2c1d349c by Serhiy Storchaka in branch 'default': Issue #19085: Added basic tests for all tkinter widget options. http://hg.python.org/cpython/rev/ab7c2c1d349c New changeset ced345326151 by Serhiy Storchaka in branch '2.7': Issue #19085: Added basic tests for all tkinter widget options. http://hg.python.org/cpython/rev/ced345326151 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Roundup Robot added the comment: New changeset cee56ef59a6a by Serhiy Storchaka in branch 'default': Issue #19085. Try to fix tkinter tests on Windows. http://hg.python.org/cpython/rev/cee56ef59a6a -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Roundup Robot added the comment: New changeset 278d15021d9a by Serhiy Storchaka in branch '2.7': Issue #19085: Fix Tkinter tests with Tcl/Tk 8.4. http://hg.python.org/cpython/rev/278d15021d9a -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Roundup Robot added the comment: New changeset f25679db52fb by Serhiy Storchaka in branch '3.3': Issue #19085: Fixed some Tkinter tests on Windows. http://hg.python.org/cpython/rev/f25679db52fb New changeset 4a2afda8f187 by Serhiy Storchaka in branch '2.7': Issue #19085: Fixed some Tkinter tests on Windows. http://hg.python.org/cpython/rev/4a2afda8f187 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Serhiy Storchaka added the comment: Updated patch addresses Ezio's comments. -- Added file: http://bugs.python.org/file32441/tkinter_options_tests_3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file32379/tkinter_options_tests_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Serhiy Storchaka added the comment: Updated patch fixes issues for Tk 8.4 and skipped ttk.Scrollbar test on MacOSX. I have increased the priority because many Tkinter issues will benefit from these tests. -- priority: normal - high ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Ned Deily added the comment: With Aqua Cocoa Tcl/Tk 8.5.14 or 8.6.0 (using ActiveState's 8.5.14 or 8.6.0) on OS X 10.8.5, running test_ttk_guionly: == ERROR: test_class (tkinter.test.test_ttk.test_widgets.ScrollbarTest) -- Traceback (most recent call last): File /py/dev/3x/root/fwd/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/test_ttk/test_widgets.py, line 22, in test_class self.assertEqual(widget['class'], '') File /py/dev/3x/root/fwd/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/__init__.py, line 1267, in cget return self.tk.call(self._w, 'cget', '-' + key) _tkinter.TclError: unknown option -class == ERROR: test_style (tkinter.test.test_ttk.test_widgets.ScrollbarTest) -- Traceback (most recent call last): File /py/dev/3x/root/fwd/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/test_ttk/test_widgets.py, line 44, in test_style self.assertEqual(widget['style'], '') File /py/dev/3x/root/fwd/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/__init__.py, line 1267, in cget return self.tk.call(self._w, 'cget', '-' + key) _tkinter.TclError: unknown option -style == FAIL: test_orient (tkinter.test.test_ttk.test_widgets.ScrollbarTest) -- Traceback (most recent call last): File /py/dev/3x/root/fwd/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/support.py, line 426, in test_orient self.checkEnumParam(widget, 'orient', 'horizontal', 'vertical') File /py/dev/3x/root/fwd/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/support.py, line 244, in checkEnumParam errmsg='ambiguous' + errmsg2) File /py/dev/3x/root/fwd/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/support.py, line 174, in checkInvalidParam widget[name] = value AssertionError: TclError not raised -- Ran 233 tests in 2.823s FAILED (failures=1, errors=2, skipped=1) test test_ttk_guionly failed 1 test failed: test_ttk_guionly --- With Aqua Carbon Tcl/Tk 8.4.19 (using ActiveState's 8.4.19) on OS X 10.8.5, running test_ttk_guionly (in 32-bit mode): = ERROR: test_class (tkinter.test.test_ttk.test_widgets.ScrollbarTest) -- Traceback (most recent call last): File /py/dev/3x/root/fwd/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/test_ttk/test_widgets.py, line 22, in test_class self.assertEqual(widget['class'], '') File /py/dev/3x/root/fwd/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/__init__.py, line 1267, in cget return self.tk.call(self._w, 'cget', '-' + key) _tkinter.TclError: unknown option -class == ERROR: test_style (tkinter.test.test_ttk.test_widgets.ScrollbarTest) -- Traceback (most recent call last): File /py/dev/3x/root/fwd/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/test_ttk/test_widgets.py, line 44, in test_style self.assertEqual(widget['style'], '') File /py/dev/3x/root/fwd/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/__init__.py, line 1267, in cget return self.tk.call(self._w, 'cget', '-' + key) _tkinter.TclError: unknown option -style == FAIL: test_values (tkinter.test.test_ttk.test_widgets.ComboboxTest) -- Traceback (most recent call last): File /py/dev/3x/root/fwd/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/test_ttk/test_widgets.py, line 351, in test_values self.assertEqual(self.combo['values'], '') AssertionError: () != '' == FAIL: test_borderwidth (tkinter.test.test_ttk.test_widgets.FrameTest) -- Traceback (most recent call last): File /py/dev/3x/root/fwd/Library/Frameworks/pytest_10.8.framework/Versions/3.4/lib/python3.4/tkinter/test/support.py, line 336, in test_borderwidth 0, 1.3, 2.6, 6, -2, '10p') File
[issue19085] Add tkinter basic options tests
Serhiy Storchaka added the comment: Thank you Ned. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Serhiy Storchaka added the comment: If there are no objections I'm going to commit this. -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
New submission from Serhiy Storchaka: The proposed patch adds tests for all options of all widgets. They test that widgets support all documented options, accepts valid values in different formats, reject invalid values, and return values in expected format. This would be helpful for regression testing. The patch tested with Tcl/Tk 8.5 and 8.6 on Linux. All new tests are compatible with wantobjects=1 and wantobjects=0. It will be good to test it with Tcl/Tk 8.4 (or even 8.3) and on Windows. -- components: Tests, Tkinter files: tkinter_options_tests.patch keywords: patch messages: 198366 nosy: gpolo, serhiy.storchaka, terry.reedy priority: normal severity: normal stage: patch review status: open title: Add tkinter basic options tests type: enhancement versions: Python 2.7, Python 3.3, Python 3.4 Added file: http://bugs.python.org/file31861/tkinter_options_tests.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19085] Add tkinter basic options tests
Changes by Ned Deily n...@acm.org: -- nosy: +ned.deily ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19085 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
