[issue19102] Add tests for CLI of the tabnanny module

[Jaysinh shukla]

Jaysinh shukla  added the comment:

@vstinner I have created the PR here. I wasn't sure so linked the PR with this 
issue. Thanks!

PR URL: https://github.com/python/cpython/pull/7699

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19102] Add tests for CLI of the tabnanny module

[Jaysinh shukla]

Change by Jaysinh shukla :


--
pull_requests: +7315

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19102] Add tests for CLI of the tabnanny module

[Jaysinh shukla]

Jaysinh shukla  added the comment:

@STINNER Victor Thanks for merging. I will try to observe that patch and will 
update you here. Have a great day

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19102] Add tests for CLI of the tabnanny module

[STINNER Victor]

STINNER Victor  added the comment:

New changeset dfa9643d292dcaa14cbf3c44b8330ba2159976c0 by Victor Stinner 
(Jaysinh Shukla) in branch 'master':
bpo-19382: Adding test cases for module tabnanny (GH-851)
https://github.com/python/cpython/commit/dfa9643d292dcaa14cbf3c44b8330ba2159976c0

--

@Jaysinh Shukla: I looked at Berker's old patch, and I think that it would be 
interesting to modify tabnanny to return with a non-zero exit code in case of 
failure. Maybe replace "return" with "sys.exit(1)" after errprint() calls.

--
nosy: +jaysinh.shukla, vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19102] Add tests for CLI of the tabnanny module

[Al Sweigart]

Al Sweigart added the comment:

Since tabnanny is also a module in the standard library (it is imported by the 
idle code), wouldn't moving it to lib/test/test_tools make it un-importable? 
This would be a good case for leaving it where it is.

--
nosy: +Al.Sweigart

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19102
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19102] Add tests for CLI of the tabnanny module

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Added comments on Rietveld.

Although tabnanny is located in the Lib directory, not in the Tools directory, 
technically it is a script. May be move test_tabnanny.py to Lib/test/test_tools?

--
assignee:  - berker.peksag
nosy: +serhiy.storchaka
type:  - enhancement
versions: +Python 3.5 -Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19102
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19102] Add tests for CLI of the tabnanny module

[Berker Peksag]

New submission from Berker Peksag:

I was trying to use the argparse module instead of getopt and I couldn't find 
any tests for CLI of the tabnanny module.

--
components: Tests
files: test_tabnanny.diff
keywords: patch
messages: 198467
nosy: berker.peksag
priority: low
severity: normal
stage: patch review
status: open
title: Add tests for CLI of the tabnanny module
versions: Python 3.4
Added file: http://bugs.python.org/file31882/test_tabnanny.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19102
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com