[issue19398] test_trace fails with -S

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +846

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19398] test_trace fails with -S

[Antoine Pitrou]

New submission from Antoine Pitrou:

$ ./python -S -m test test_trace
[1/1] test_trace
test test_trace failed -- Traceback (most recent call last):
  File "/home/antoine/cpython/default/Lib/test/test_trace.py", line 313, in 
test_coverage
self.assertTrue("pprint.cover" in files)
AssertionError: False is not true

--
components: Tests
messages: 201286
nosy: pitrou
priority: low
severity: normal
status: open
title: test_trace fails with -S
type: behavior
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19398] test_trace fails with -S

[Vajrasky Kok]

Vajrasky Kok added the comment:

This is the "emergency" patch to solve this issue.

The main issue is,

[sky@localhost cpython]$ ./python -Sc "import sys; print(sys.path)"
['', '/usr/local/lib/python34.zip', 
'/home/sky/Code/python/programming_language/cpython/Lib/', 
'/home/sky/Code/python/programming_language/cpython/Lib/plat-linux', 
'/home/sky/Code/python/programming_language/cpython/build/lib.linux-x86_64-3.4-pydebug']
[sky@localhost cpython]$ ./python -c "import sys; print(sys.path)"
['', '/usr/local/lib/python34.zip', 
'/home/sky/Code/python/programming_language/cpython/Lib', 
'/home/sky/Code/python/programming_language/cpython/Lib/plat-linux', 
'/home/sky/Code/python/programming_language/cpython/build/lib.linux-x86_64-3.4-pydebug',
 '/home/sky/.local/lib/python3.4/site-packages']

Let me "zoom" it for you.

[sky@localhost cpython]$ ./python -Sc "import sys; print(sys.path[2])"
/home/sky/Code/python/programming_language/cpython/Lib/
[sky@localhost cpython]$ ./python -c "import sys; print(sys.path[2])"
/home/sky/Code/python/programming_language/cpython/Lib

The "extra" slash is the culprit. I need to investigate whether this is 
deliberate or not.

--
keywords: +patch
nosy: +vajrasky
Added file: 
http://bugs.python.org/file32366/emergency_patch_for_test_trace.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19398] test_trace fails with -S

[Vajrasky Kok]

Vajrasky Kok added the comment:

I finally found the main culprit which puts extra '/' in my sys.path. The patch 
removed the extra '/' and also fixed this test automatically.

--
Added file: 
http://bugs.python.org/file32367/remove_extra_slash_from_sys_path.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19398] test_trace fails with -S

[Terry J. Reedy]

Terry J. Reedy added the comment:

The test should use the more specific assertXyz method:
self.assertIn("pprint.cover", files)

The error message would then be the more informative
AssertionError: 'pprint.cover' not found in 

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19398] test_trace fails with -S

[Vajrasky Kok]

Vajrasky Kok added the comment:

Attached the patch to accommodate Terry J. Reedy's request.

--
Added file: 
http://bugs.python.org/file32460/remove_extra_slash_from_sys_path_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19398] test_trace fails with -S

[Tim Smith]

Changes by Tim Smith :


--
nosy: +tdsmith
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19398] test_trace fails with -S

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The separator is needed if the relative path is not empty and the prefix 
doesn't end with the separator.

This patch seems also fixes most problems of issue28655.

--
assignee:  -> serhiy.storchaka
nosy: +serhiy.storchaka
versions: +Python 3.5, Python 3.6, Python 3.7 -Python 3.4
Added file: 
http://bugs.python.org/file45422/remove_extra_slash_from_sys_path_v3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19398] test_trace fails with -S

[Roundup Robot]

Roundup Robot added the comment:

New changeset db220f2df5a9 by Serhiy Storchaka in branch '3.5':
Issue #19398: Extra slash no longer added to sys.path components in case of
https://hg.python.org/cpython/rev/db220f2df5a9

New changeset 1a88baaed7a0 by Serhiy Storchaka in branch '3.6':
Issue #19398: Extra slash no longer added to sys.path components in case of
https://hg.python.org/cpython/rev/1a88baaed7a0

New changeset 82607e7c24c7 by Serhiy Storchaka in branch 'default':
Issue #19398: Extra slash no longer added to sys.path components in case of
https://hg.python.org/cpython/rev/82607e7c24c7

New changeset 237ef36fb1bb by Serhiy Storchaka in branch '2.7':
Issue #19398: Extra slash no longer added to sys.path components in case of
https://hg.python.org/cpython/rev/237ef36fb1bb

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19398] test_trace fails with -S

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com