[issue19744] test_venv and installation fail if SSL/TLS is not available

[Roundup Robot]

Roundup Robot added the comment:

New changeset cd39d4cab680 by Nick Coghlan in branch '3.4':
Issue #19744: Handle missing SSL/TLS in ensurepip
http://hg.python.org/cpython/rev/cd39d4cab680

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19744] test_venv and installation fail if SSL/TLS is not available

[Nick Coghlan]

Nick Coghlan added the comment:

Issue 20685 created to cover inclusion in 3.4.0, already committed to default, 
so closing this one.

--
resolution:  -> fixed
stage: commit review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19744] test_venv and installation fail if SSL/TLS is not available

[Nick Coghlan]

Nick Coghlan added the comment:

Thanks Ned - I fixed that test to only run if SSL/TLS is available, and added a 
new one to test that the command "succeeds" (with a warning printed to stderr) 
if SSL/TLS is missing.

Larry - over to you to decide whether or not to cherry pick this into the 
release clone. The remaining misbehaviour that was fixed in the last patch only 
affects custom source builds, so the beneficiaries would be people trying to 
build from the source tarball or release tag without SSL/TLS support.

--
assignee: ned.deily -> larry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19744] test_venv and installation fail if SSL/TLS is not available

[Roundup Robot]

Roundup Robot added the comment:

New changeset 9f76adbac8b7 by Nick Coghlan in branch 'default':
Issue #19744: Handle missing SSL/TLS in ensurepip
http://hg.python.org/cpython/rev/9f76adbac8b7

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19744] test_venv and installation fail if SSL/TLS is not available

[Ned Deily]

Ned Deily added the comment:

issue19744_ensurepip_install_ok_without_ssl.diff looks good to me.  Note, 
though, that with it and with ssl support missing, test_ensurepip fails 
somewhat obscurely:

==
FAIL: test_bootstrap_version (test.test_ensurepip.TestBootstrappingMainFunction)
--
Traceback (most recent call last):
  File "/py/dev/3x/root/uxd/lib/python3.4/test/test_ensurepip.py", line 293, in 
test_bootstrap_version
ensurepip._main(["--version"])
AssertionError: SystemExit not raised

--

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19744] test_venv and installation fail if SSL/TLS is not available

[Nick Coghlan]

Nick Coghlan added the comment:

Note: I'm deliberately not worrying about ensurepip._uninstall here, since that 
only gets invoked implicitly in the Windows uninstaller, and that should always 
have a valid SSL to play with.

Always, since I worked out how to disable ssl in my local build (just a small 
tweak to setup.py), I was able to verify the correct behaviour of 
test_ensurepip and test_venv with SSL unavailable.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19744] test_venv and installation fail if SSL/TLS is not available

[Nick Coghlan]

Nick Coghlan added the comment:

This patch is probably a better bet - it just prints a message to stderr to say 
that we're ignoring the ensurepip failure during installation.

pip wouldn't work anyway in a Python without ssl built, but at least this way 
that Python can still be installed without the ensurepip invocation complaining.

Ned, if this approach sounds reasonable to you, I'll commit this one.

--
assignee: ncoghlan -> ned.deily
nosy: +ned.deily
Added file: 
http://bugs.python.org/file34078/issue19744_ensurepip_install_ok_without_ssl.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19744] test_venv and installation fail if SSL/TLS is not available

[Nick Coghlan]

Nick Coghlan added the comment:

Attached patch tweaks the ensurepip CLI to check immediately for ssl support, 
and avoid printing a traceback if it is missing.

However, missing SSL support still fails the call, which fails installation.

--
keywords: +patch
resolution: fixed -> 
stage: committed/rejected -> commit review
Added file: http://bugs.python.org/file34077/issue19744_ensurepip_no_ssl.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19744] test_venv and installation fail if SSL/TLS is not available

[Nick Coghlan]

Changes by Nick Coghlan :


--
title: test_venv fails if SSL/TLS is not available -> test_venv and 
installation fail if SSL/TLS is not available

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com