[issue19757] _tracemalloc.c: compiler warning with gil_state

[Roundup Robot]

Roundup Robot added the comment:

New changeset 194f74044537 by Victor Stinner in branch 'default':
Close #19757: Cleanup tracemalloc, move
http://hg.python.org/cpython/rev/194f74044537

--
nosy: +python-dev
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19757] _tracemalloc.c: compiler warning with gil_state

[STINNER Victor]

STINNER Victor added the comment:

Hum, Clang is not kind enough to understand that gil_state is not used when 
uninitialized.

Well, I always hesitated to refactor the code. So here is a cleanup which moves 
PyGILState_Ensure/PyGILState_Release to the caller. It duplicates a few lines 
of code, but the new code should be more readable.

--
keywords: +patch
Added file: http://bugs.python.org/file32878/cleanup.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19757] _tracemalloc.c: compiler warning with gil_state

[koobs]

Changes by koobs :


--
nosy: +koobs

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19757] _tracemalloc.c: compiler warning with gil_state

[STINNER Victor]

New submission from STINNER Victor:

Clang complains that gil_state might be used uninitialized in 
_tracemalloc.c:488 and 533.

--
messages: 204254
nosy: christian.heimes, haypo
priority: normal
severity: normal
status: open
title: _tracemalloc.c: compiler warning with gil_state
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com