[issue19798] tracemalloc: rename max_size to peak_size in get_traced_memory() result

2013-11-27 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 553144bd7bf1 by Victor Stinner in branch 'default':
Close #19798: replace maximum term with peak in get_traced_memory()
http://hg.python.org/cpython/rev/553144bd7bf1

--
nosy: +python-dev
resolution:  - fixed
stage:  - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19798
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19798] tracemalloc: rename max_size to peak_size in get_traced_memory() result

2013-11-27 Thread STINNER Victor

STINNER Victor added the comment:

 no?

yes, I also prefer current over size.

--
stage: committed/rejected - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19798
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19798] tracemalloc: rename max_size to peak_size in get_traced_memory() result

2013-11-26 Thread STINNER Victor

Changes by STINNER Victor victor.stin...@gmail.com:


--
components: +Library (Lib)
versions: +Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19798
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19798] tracemalloc: rename max_size to peak_size in get_traced_memory() result

2013-11-26 Thread STINNER Victor

New submission from STINNER Victor:

Jim.J.Jewett asked me to replaced max_size with peak_size. It looks like 
Linux also uses the term peak for /proc/pid/status (or sometimes High Water 
Mark).

See attached patch.

--
files: peak_size.patch
keywords: patch
messages: 204470
nosy: haypo, neologix
priority: normal
severity: normal
status: open
title: tracemalloc: rename max_size to peak_size in get_traced_memory() 
result
Added file: http://bugs.python.org/file32856/peak_size.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19798
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19798] tracemalloc: rename max_size to peak_size in get_traced_memory() result

2013-11-26 Thread STINNER Victor

STINNER Victor added the comment:

@neologix: I would like your opinion first, because you accepted the PEP.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19798
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19798] tracemalloc: rename max_size to peak_size in get_traced_memory() result

2013-11-26 Thread Charles-François Natali

Charles-François Natali added the comment:

 STINNER Victor added the comment:

 @neologix: I would like your opinion first, because you accepted the PEP.

Well, I'm not a native speaker, but peak does sound better than
max (I'd say the later refers to an externally-enforced limit,
contrarily to the former).

So the change looks fine, although:

`(size: int, peak_size: int)``


Would maybe be better with:

`(current: int, peak: int)``


no?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19798
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com