[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Antony Lee]

New submission from Antony Lee:

multiprocessing.sharedctypes was not updated after the "q" (c_longlong) and "Q" 
(c_ulonglong) typecodes were added to the array module (the docs claim that the 
typecode can be "one character typecode of the kind used by the array module"). 
 The attached patch (just adding an entry to the typecode-to-type dict, as well 
as some more tests) fixes the issue.

--
components: Library (Lib)
files: multiprocessing-longlong.patch
keywords: patch
messages: 205287
nosy: Antony.Lee
priority: normal
severity: normal
status: open
title: Exposing "q" and "Q" to multiprocessing.sharedctypes
versions: Python 3.4
Added file: http://bugs.python.org/file32985/multiprocessing-longlong.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy: +sbt
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Gareth Rees]

Gareth Rees added the comment:

Patch looks good to me. The test cases are not very systematic (why only int, 
double, and long long?), but that's not the fault of the patch and shouldn't 
prevent its being applied.

--
nosy: +g...@garethrees.org

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Antony Lee]

Changes by Antony Lee :


--
nosy:  -Antony.Lee

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Gareth Rees]

Changes by Gareth Rees :


--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Antoine Pitrou]

Antoine Pitrou added the comment:

Uh, it's a pity this patch has been overlooked.
Gareth, would you want to make a Github PR out of this?

--
nosy: +pitrou
type:  -> enhancement
versions: +Python 3.7 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Gareth Rees]

Gareth Rees added the comment:

Has Antony Lee has made a copyright assignment?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Antoine Pitrou]

Antoine Pitrou added the comment:

According to the asterisk displayed right of his name, he has, yes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Gareth Rees]

Gareth Rees added the comment:

(If he hasn't, I don't think I can make a PR because I read his patch and so 
any implementation I make now is based on his patch and so potentially 
infringes his copyright.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Gareth Rees]

Changes by Gareth Rees :


--
pull_requests: +2801

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Antoine Pitrou]

Antoine Pitrou added the comment:


New changeset 3913bad4957ac30e58a7ffe9279333ad176a8eea by Antoine Pitrou 
(Gareth Rees) in branch 'master':
bpo-19896: Add typecodes 'q' and 'Q' to multiprocessing.sharedctypes (#2741)
https://github.com/python/cpython/commit/3913bad4957ac30e58a7ffe9279333ad176a8eea


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[STINNER Victor]

STINNER Victor added the comment:

Unhappy buildbot:

http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/1065/steps/test/logs/stdio

...
  File 
"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_multiprocessing_fork.py",
 line 2, in 
import test._test_multiprocessing
  File 
"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/_test_multiprocessing.py",
 line 3180, in 
class _Foo(Structure):
  File 
"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/_test_multiprocessing.py",
 line 3184, in _Foo
('z', c_longlong,)
NameError: name 'c_longlong' is not defined

--
nosy: +haypo
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Antoine Pitrou]

Antoine Pitrou added the comment:

Apparently that buildbot doesn't have libffi.  I submitted a PR in 
https://github.com/python/cpython/pull/2802.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19896] Exposing "q" and "Q" to multiprocessing.sharedctypes

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com