[issue20066] PyStructSequence_NewType() not setting proper heap allocation flag?

[Dong-hee Na]

Dong-hee Na  added the comment:

Thanks @nanjekyejoannah for comment.

Yes, I found that the codes are updated.
see 
https://github.com/python/cpython/blob/bd44a7ead9f7336d7bb45f186b2b6ca0300154f7/Objects/structseq.c#L488

I close this issue.

--
nosy: +corona10
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20066] PyStructSequence_NewType() not setting proper heap allocation flag?

[Joannah Nanjekye]

Joannah Nanjekye  added the comment:

As commented in issue15729, the Py_TPFLAGS_HEAPTYPE flag is now set in 
PyType_FromSpecWithBases() which is called by PyStructSequence_NewType(). I 
think this is no longer an issue.

--
nosy: +nanjekyejoannah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20066] PyStructSequence_NewType() not setting proper heap allocation flag?

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

See also issue15729.

--
components: +Interpreter Core
nosy: +serhiy.storchaka
stage:  - needs patch
versions: +Python 3.4, Python 3.5 -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20066
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20066] PyStructSequence_NewType() not setting proper heap allocation flag?

[Wolf Ihlenfeldt]

New submission from Wolf Ihlenfeldt:

If I am not mistaken, I think that PyStructSequence_NewType() should set the 
Py_TPFLAGS_HEAPTYPE flag in tp-flags (which it currently does not). The 
original version initially works fine, but ultimately crashes at exit time in 
finalization with

Fatal Python error: type_traverse() called for non-heap type 'E_FILE'

#0  0x712913d5 in raise () from /lib64/libc.so.6
#1  0x71292858 in abort () from /lib64/libc.so.6
#2  0x72360484 in Py_FatalError (msg=optimized out) at 
Python/pythonrun.c:2364
#3  0x722e5354 in type_traverse (type=0x10b47a0, visit=0x72374350 
visit_decref, arg=0x0)
at Objects/typeobject.c:2892
#4  0x72374bd1 in subtract_refs (containers=0x726466c0) at 
Modules/gcmodule.c:386
#5  collect (n_uncollectable=synthetic pointer, n_collected=synthetic 
pointer, generation=2)
at Modules/gcmodule.c:891
#6  collect_with_callback (generation=2) at Modules/gcmodule.c:1048
#7  0x72375436 in PyGC_Collect () at Modules/gcmodule.c:1476
#8  0x7235f698 in Py_Finalize () at Python/pythonrun.c:521
#9  0x76e70b70 in CSpythonFinalize () at nmds_python.c:44652
#10 0x00407399 in main ()

Setting the flag manually after creation lets the problem disappear.

--
messages: 206923
nosy: Wolf.Ihlenfeldt
priority: normal
severity: normal
status: open
title: PyStructSequence_NewType() not setting proper heap allocation flag?
type: crash
versions: Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20066
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com