[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Should we close this issue or is anything left in this Derby?

--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset b00854caa080cec613496d3a5e1b0891c9ff83e6 by Serhiy Storchaka in 
branch 'master':
bpo-20171: Convert the _curses and _curses_panel modules to Argument Clinic. 
(GH-4251)
https://github.com/python/cpython/commit/b00854caa080cec613496d3a5e1b0891c9ff83e6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

PR 4251 converts most of functions in the _curses and _curses_panel modules 
(around 130 functions) to Argument Clinic. Many functions didn't have 
docstrings, the PR adds them. You can test new signatures and docstrings by the 
following commands:

./python -m pydoc curses
./python -m pydoc curses.window
./python -m pydoc curses.panel
./python -m pydoc curses.panel.panel

3 functions can't be converted. The initial versions of Argument Clinic 
supported such declarations, but now it doesn't support them. Will try to fix 
Argument Clinic in other issue. Yet 35 generated window methods have not been 
converted because I'm too tired by this patch. They will be converted by other 
patches.

I tried to make new and existing docstrings short and clear, but I think many 
docstrings still need editing.

--
versions: +Python 3.7 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +4213
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Updated to the tip. Unfortunately, Argument Clinic now generates incorrect 
parsing code for some functions. Tests are failed.

--
Added file: http://bugs.python.org/file39293/curses_clinic_2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20171
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Fixed  signatures generated with macro in _curses_panel.

--
Added file: http://bugs.python.org/file39294/curses_clinic_3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20171
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
components: +Argument Clinic

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20171
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Larry Hastings]

Changes by Larry Hastings la...@hastings.org:


--
versions: +Python 3.5 -Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20171
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Larry Hastings]

Larry Hastings added the comment:

All the Derby patches should only go into trunk at this point.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20171
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is half-baked (just for demonstration) patch for the _curses and 
_curses_panel modules.

Known issues:

* The chgat, getstr, and instr methods have signatures which can't be processed 
by current Argument Clinic (issue20303).

* Signatures of the noutrefresh and refresh methods depends on compile-time 
options.

* Many other functions are defined optionally. But the #ifdef trick doesn't 
work with side file destination.

* A lot of functions are generated by preprocessor. We can't use Argument 
Clinic for them (if not increase the volume of code too much). I think 
preprocessor should be used to generate docstrings with signature (done in the 
_curses_panel module).

* Functions in these modules have not docstrings at all. I try to add 
docstrings (simplified descriptions from the documentation file), but may be we 
should do this in separate issue.

I have temporary added the window class to the _curses module and the panel 
classes to the _curses_panel modules. Now you can examine docstrings of 
_curses.window and _curses_panel.panel with pydoc.

--
keywords: +patch
Added file: http://bugs.python.org/file33567/curses_clinic.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20171
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I take it.

--
assignee:  - serhiy.storchaka
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20171
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Larry Hastings]

New submission from Larry Hastings:

This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.

This issue asks you to change the following bundle of files:
Modules/_cursesmodule.c: 115 sites

Talk to me (larry) if you only want to attack part of a bundle.

For instructions on how to convert a function to work with Argument
Clinic, read the howto:
http://docs.python.org/dev/howto/clinic.html

--
components: Library (Lib)
messages: 207616
nosy: larry
priority: normal
severity: normal
stage: needs patch
status: open
title: Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c
type: behavior
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20171
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Larry Hastings]

Changes by Larry Hastings la...@hastings.org:


--
components: +Extension Modules -Library (Lib)

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20171
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20171] Derby #2: Convert 115 sites to Argument Clinic in Modules/_cursesmodule.c

[Larry Hastings]

Changes by Larry Hastings la...@hastings.org:


--
type: behavior - enhancement

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20171
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com