[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Changes by David Watson bai...@users.sourceforge.net: -- nosy: +baikie ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Peter McCormick added the comment: I am working on revising the Argument Clinic definitions for socketmodule.c. -- nosy: +pdmccormick ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Changes by Serhiy Storchaka storch...@gmail.com: -- components: +Argument Clinic ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Larry Hastings added the comment: All the Derby patches should only go into trunk at this point. -- versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Martin v. Löwis added the comment: Ryan, 4 hunks of your patch fail to apply now. Can you please update the patch? -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Ryan Smith-Roberts added the comment: Here's sendmsg with only nested bracket optional args. If Rietveld doesn't like this patch I may cry. -- Added file: http://bugs.python.org/file33496/argument_clinic_socketmodule_v4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Ryan Smith-Roberts added the comment: Forgot to linewrap a paragraph. -- Added file: http://bugs.python.org/file33489/argument_clinic_socketmodule_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Ryan Smith-Roberts added the comment: Tweaked the argument list for functions using a NULL default. Kludgy but doesn't lie to the user. -- Added file: http://bugs.python.org/file33490/argument_clinic_socketmodule_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Ryan Smith-Roberts added the comment: Here's the socketmodule patch. I aggressively imported text from the docs for the docstrings, along with matching parameter names, given how far the old docstrings have drifted over time. The Windows-specific code is untested, but otherwise the tests pass. I tagged functions which can't be converted or whose argument handling is esoteric. These comments can be removed prior to commit. I am not sure if one should convert a C-level class's init method. -- Added file: http://bugs.python.org/file33472/argument_clinic_socketmodule.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Ryan Smith-Roberts added the comment: Just discovered that the bugtracker mail was all going into my spam filter, yay. Didn't notice your reply until just now. The functools patch was just a quickie to get it out of my mental queue, and I'm still working on socketmodule. This is my first time using the Python bugtracker, I don't know if multipart patches are acceptable? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Larry Hastings added the comment: I don't know what you mean by a multipart patch, but the bug tracker has handled every patch I've thrown at it so far. (Assuming that the patch is based on a reasonably fresh checkout of trunk.) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Larry Hastings added the comment: While it's dandy to add docstrings, your patch doesn't have any Argument Clinic stuff in it. I don't mind if you add docstrings as part of the process of converting to Argument Clinic, but I'm not interested in this patch as it stands. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Ryan Smith-Roberts added the comment: Taking a crack at this. socketmodule.h: just a comment, skipping. _functools.c: kind-of skipping, because the relevant functions are not normally directly called (pickle protocol __reduce__ and __setstate__ on partial, __call__ on cmp wrapper). Will add simple docstrings for the pickle protocol handlers though. -- nosy: +rmsr ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Changes by Ryan Smith-Roberts r...@lab.net: -- keywords: +patch Added file: http://bugs.python.org/file33372/argument_clinic_functools.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
New submission from Larry Hastings: This issue is part of the Great Argument Clinic Conversion Derby, where we're trying to convert as much of Python 3.4 to use Argument Clinic as we can before Release Candidate 1 on January 19. This issue asks you to change the following bundle of files: Modules/socketmodule.c: 47 sites Modules/socketmodule.h: 1 sites Modules/_functoolsmodule.c: 2 sites Talk to me (larry) if you only want to attack part of a bundle. For instructions on how to convert a function to work with Argument Clinic, read the howto: http://docs.python.org/dev/howto/clinic.html -- components: Extension Modules messages: 207619 nosy: larry priority: normal severity: normal stage: needs patch status: open title: Derby #5: Convert 50 sites to Argument Clinic across 3 files type: behavior versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20174] Derby #5: Convert 50 sites to Argument Clinic across 3 files
Changes by Larry Hastings la...@hastings.org: -- type: behavior - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20174 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
