[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset b7047e59a40649d81061acf0044e74cfd426f064 by Zackery Spytz in 
branch 'master':
bpo-20181: Convert the readline module to the Argument Clinic (#14326)
https://github.com/python/cpython/commit/b7047e59a40649d81061acf0044e74cfd426f064


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Zackery Spytz]

Zackery Spytz  added the comment:

PR 14326 converts Modules/readline.c.

As the parser module is slated for removal in 3.9 (according to PEP 594), 
Modules/parsermodule.c should not be converted.

--
nosy: +ZackerySpytz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Zackery Spytz]

Change by Zackery Spytz :


--
pull_requests: +14146
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14326

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Tal Einat]

Change by Tal Einat :


--
nosy:  -taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Roundup Robot]

Roundup Robot added the comment:

New changeset c6d468e0ecc6 by Serhiy Storchaka in branch 'default':
Issue #20181: Converted the unicodedata module to Argument Clinic.
https://hg.python.org/cpython/rev/c6d468e0ecc6

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20181
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Larry Hastings]

Larry Hastings added the comment:

I finally talked to someone (Thomas Wouters) about this.  For something going 
into trunk that will be part of 3.5, this is fine.

Please include a mention that the exception's text messages changed in 
Misc/NEWS.  I can help you write this if you want.

I'll try and give this a full review later today or tomorrow, is that soon 
enough?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20181
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The only difference is in error message.

For now:

 unicodedata.name(123)
Traceback (most recent call last):
  File stdin, line 1, in module
TypeError: must be str, not int
 unicodedata.name('123')
Traceback (most recent call last):
  File stdin, line 1, in module
TypeError: need a single Unicode character as parameter

Patched:

 unicodedata.name(123)
Traceback (most recent call last):
  File stdin, line 1, in module
TypeError: must be a unicode character, not int
 unicodedata.name('123')
Traceback (most recent call last):
  File stdin, line 1, in module
TypeError: must be a unicode character, not str

If you think old messages were better, we can change standard error messages 
for 'C' format unit. We already changed standard and specialized error messages 
in 3.5 and earlier. In 3.4 it looks as:

 unicodedata.name(123)
Traceback (most recent call last):
  File stdin, line 1, in module
TypeError: must be str, not int
 unicodedata.name('123')
Traceback (most recent call last):
  File stdin, line 1, in module
TypeError: need a single Unicode character as parameter

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20181
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Larry Hastings]

Larry Hastings added the comment:

I read it quickly.  It looks basically okay, but I have one issue to discuss 
right now.  Changing from the format unit 'O!' and calling getuchar to the 
format unit 'C' means a change in semantics.  The text in the exception will 
change.  Unfortunately, people do depend on that in real-world code.

It'd be nice if we could change those semantics; this won't ship until 3.5 so 
maybe it's okay.  I don't know.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20181
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is a patch for unicodedata.

--
keywords: +patch
nosy: +serhiy.storchaka
Added file: http://bugs.python.org/file38630/unicodedata_clinic.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20181
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
components: +Argument Clinic

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20181
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Larry Hastings]

Larry Hastings added the comment:

All the Derby patches should only go into trunk at this point.

--
versions: +Python 3.5 -Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20181
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Tal Einat]

Tal Einat added the comment:

While converting Objects/stringlib/transmogrify.h as part of issue20180 (Derby 
#11), some changes to Objects/bytesobject.c and Objects/bytearrayobject.c were 
required. Those changes are included in the relevant patch attached to that 
issue.

--
nosy: +taleinat

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20181
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Tal Einat]

Tal Einat added the comment:

See nearly complete conversion of Objects/bytearrayobject.c in patch attached 
to issue20179.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20181
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

[Larry Hastings]

New submission from Larry Hastings:

This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.

This issue asks you to change the following bundle of files:
Objects/bytearrayobject.c: 13 sites
Modules/parsermodule.c: 13 sites
Modules/unicodedata.c: 12 sites
Modules/readline.c: 12 sites

Talk to me (larry) if you only want to attack part of a bundle.

For instructions on how to convert a function to work with Argument
Clinic, read the howto:
http://docs.python.org/dev/howto/clinic.html

--
components: Extension Modules
messages: 207637
nosy: larry
priority: normal
severity: normal
stage: needs patch
status: open
title: Derby #12: Convert 50 sites to Argument Clinic across 4 files
type: enhancement
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20181
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com