[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 1bcaa81e520e30f920bd69e46fbf1d67a9107ce1 by Serhiy Storchaka in 
branch 'master':
bpo-20184: Convert termios to Argument Clinic. (GH-22693)
https://github.com/python/cpython/commit/1bcaa81e520e30f920bd69e46fbf1d67a9107ce1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +21664
pull_request: https://github.com/python/cpython/pull/22693

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[hai shi]

hai shi  added the comment:

Looks like `builtins.vars` and `builtins.dir` should be migrated to AC too, so 
I create PR18512.

--
nosy: +shihai1991

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[hai shi]

Change by hai shi :


--
pull_requests: +17889
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/18512

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is a patch that converts 3 functions in the _json module to Argument 
Clinic. All other functions doesn't fit with Argument Clinic.

--
Added file: http://bugs.python.org/file39292/json_clinic.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Roundup Robot]

Roundup Robot added the comment:

New changeset 49910ff21ba5 by Serhiy Storchaka in branch 'default':
Issue #20184: Converted _dbm and _gdbm modules to Argument Clinic.
https://hg.python.org/cpython/rev/49910ff21ba5

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The patch updated to the tip.

--
Added file: http://bugs.python.org/file39070/dbm_clinic_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Proposed patch converts _dbm and _gdbm modules to Argument Clinic.

--
nosy: +serhiy.storchaka
Added file: http://bugs.python.org/file39032/dbm_clinic.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
components: +Argument Clinic

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Nick Coghlan]

Nick Coghlan added the comment:

(Well, they'll support it in 3.5...)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Nick Coghlan]

Nick Coghlan added the comment:

30 of the builtin functions now support signature introspection thanks to 
Argument Clinic :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Roundup Robot]

Roundup Robot added the comment:

New changeset 6219aa966a5f by Nick Coghlan in branch 'default':
Issue #20184: Add signature introspection for 30 of the builtins
http://hg.python.org/cpython/rev/6219aa966a5f

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Nick Coghlan]

Nick Coghlan added the comment:

Tweaked patch to apply cleanly to trunk, but realised it has been a while since 
I looked at the current state of argument clinic:

* I'm not sure if varargs support has been added yet. If it has, "min", "max", 
"print", "__build_class__" can be converted. If it hasn't, then the comments 
referring to 3.4 still need to be updated.

* the comments referring to needing groups support in AC aren't quite right, 
it's optional group support in inspect that's missing. So the comments relating 
to "range", "slice", "dir", "getattr", "next", "iter", "vars" should be tweaked 
accordingly

* tweaking the behaviour of round to make it AC friendly should probably go 
into its own issue.

Also, Larry, there's a note in the the 3.4 "What's New" about additional 
signature info landing in Python 3.4 maintenance releases. That note should 
probably be adjusted at this point, since any new signature data will only be 
available in 3.5.

--
Added file: 
http://bugs.python.org/file36385/issue20184_builtin_conversion_v7.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Larry Hastings]

Larry Hastings added the comment:

All the Derby patches should only go into trunk at this point.

--
versions: +Python 3.5 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Nick Coghlan]

Nick Coghlan added the comment:

Updated the builtins patch for the 3.4.0 Argument Clinic changes. Also moved 
the issue back to 3.4, since Larry has indicated that AC conversions are in 
scope for 3.4.x maintenance releases, so long as no public API behaviour 
changes.

--
nosy: +yselivanov
versions: +Python 3.4 -Python 3.5
Added file: 
http://bugs.python.org/file34664/issue20184_builtin_conversion_v6.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Nick Coghlan]

Nick Coghlan added the comment:

Interpreting the lack of response as "this can wait until 3.5".

--
assignee: larry -> 
priority: release blocker -> normal
versions: +Python 3.5 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Nick Coghlan]

Nick Coghlan added the comment:

Larry, I'd like to include the most-builtin-functions signature support for 
3.4, but since the AC Derby is over, it's your call as release manager.

If it looks good to you, go ahead and commit it (I won't have time until later 
in the week), otherwise just drop the priority and punt it to 3.5.

--
assignee: ncoghlan -> larry
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Nick Coghlan]

Changes by Nick Coghlan :


Added file: 
http://bugs.python.org/file33861/issue20184_builtin_conversion_v5.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Nick Coghlan]

Nick Coghlan added the comment:

Larry, if this version looks good to you, I'd like to commit it.

- id() is now back to being a properly generated AC function (since AC can now 
preserve the old C level signature)

- sorted() is partially converted and has a __text_signature__ compatible 
docstring. However, full conversion will have to wait for the ability to 
preserve the kwds dict, since that's the API exposed by the list object.

- with the new never-triggered-by-accident AC syntax, the test case now ensures 
that all the builtins that are expected to *not* expose signature info at this 
point, don't. As they're converted for 3.5, that will force them to be added to 
the list of functions that are checked for compatibility.

I'm thinking it's probably worth flagging this new test as a CPython 
implementation detail test, though.

--
Added file: 
http://bugs.python.org/file33860/issue20184_builtin_conversion_v4.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Nick Coghlan]

Nick Coghlan added the comment:

Assigning to myself to make it clear that bltinmodule is the only part of this 
still under consideration for 3.4.

The test_pydoc and test_gdb failures pointed to real issues with the previous 
patch:

- the pydoc errors themselves were incidental, indicating that I had added 
doctests to chr and ord. However, those new doctests used a Unicode character 
in a C string, which seems like a recipe for portability trouble. I took those 
doctests out again, and updated the prose docs instead. I like my obscure 
multilingual Monty Python reference and would like to keep it now I thought of 
it :)

- the gdb error suggests that gdb is relying on being able to find builtin_id 
based on its exact signature, including the parameter names. Rather than trying 
to figure out the full details of that, I've instead partially reverted its 
conversion to Argument Clinic by disabling the input block and restoring the 
old parameter names in the function signature. We can change it back to full 
conversion for 3.5, after AC has the ability to use different names in the 
Python signature and in the C implementation function.

This does mean we'll want to update the signature by hand once you merge the 
patch changing the indicators that argument clinic is looking for.

--
assignee:  -> ncoghlan
Added file: 
http://bugs.python.org/file33740/issue20184_builtin_conversion_v3.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Nick Coghlan]

Nick Coghlan added the comment:

More comprehensive patch uploaded - all the non-type callables implemented in 
bltinmodule.c have been converted or classified with a reason for not being 
converted yet (see the new test in test_inspect.py for details, as well as the 
AC 3.4 and AC 3.5 comments in the module itself).

I also cleaned up the docstrings for the builtins I actually changed in the 
patch. There were a few that had never been properly updated for the Py3k 
transition.

There are still a couple of test failures with this version - the doctest tests 
get confused by the fact ord and chr now have a doctest in their docstrings, 
and test_gdb is definitely not in a happy place (that has always been 
temperamental, though).

I also just realised the Unicode character in the new ord and chr docstrings 
could pose a compatibility problem at the C compiler source encoding level, so 
we may have to reconsider that (even though I was rather happy to sneak that 
obscure Monty Python reference in there).

--
Added file: 
http://bugs.python.org/file33701/issue20184_builtin_conversion_v2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Nick Coghlan]

Nick Coghlan added the comment:

Attached patch shows the new test case I'm using to ensure that all callable 
builtins have signatures, and once we get it that way, it stays that way.

Preliminary goal is signatures for all the non-type objects, and once I get to 
that point, I'll propose it for review.

--
keywords: +patch
Added file: http://bugs.python.org/file33696/issue20184_builtin_conversion.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Nick Coghlan]

Nick Coghlan added the comment:

I'm going to specifically tackle the "bltinmodule" side of things using a test 
driven approach: adding a new test to test_inspect that checks all the builtin 
names have signatures (I'll explicitly exclude ones that are known not to be 
handled, like range and slice).

--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Nadeem Vawda]

Changes by Nadeem Vawda :


--
nosy: +nadeem.vawda

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

[Larry Hastings]

New submission from Larry Hastings:

This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.

This issue asks you to change the following bundle of files:
Modules/faulthandler.c: 7 sites
Modules/_pickle.c: 7 sites
Modules/_lzmamodule.c: 7 sites
Python/bltinmodule.c: 6 sites
Modules/termios.c: 6 sites
Modules/syslogmodule.c: 6 sites
Modules/_dbmmodule.c: 4 sites
Modules/_gdbmmodule.c: 2 sites
Modules/_json.c: 5 sites

Talk to me (larry) if you only want to attack part of a bundle.

For instructions on how to convert a function to work with Argument
Clinic, read the "howto":
http://docs.python.org/dev/howto/clinic.html

--
components: Extension Modules
messages: 207642
nosy: larry
priority: normal
severity: normal
stage: needs patch
status: open
title: Derby #16: Convert 50 sites to Argument Clinic across 9 files
type: enhancement
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com