[issue20295] imghdr add openexr support

[R. David Murray]

R. David Murray added the comment:

Thanks, Martin and Claudiu.

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20295] imghdr add openexr support

[Roundup Robot]

Roundup Robot added the comment:

New changeset 71b9a841119a by R David Murray in branch 'default':
#20295: Teach imghdr to recognize OpenEXR format images.
http://hg.python.org/cpython/rev/71b9a841119a

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20295] imghdr add openexr support

[Claudiu Popa]

Changes by Claudiu Popa :


--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20295] imghdr add openexr support

[Claudiu Popa]

Claudiu Popa added the comment:

This seems commit ready.

--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20295] imghdr add openexr support

[Claudiu Popa]

Claudiu Popa added the comment:

Here's an updated patch with a small exr test file.

--
Added file: http://bugs.python.org/file35692/issue20295.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20295] imghdr add openexr support

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20295] imghdr add openexr support

[Claudiu.Popa]

Claudiu.Popa added the comment:

Hi, Martin.

Please see issue19990, which tries to add unit tests for imghdr module. It 
would be nice if you could expand on it with an exr file, for your use case.

--
nosy: +Claudiu.Popa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20295] imghdr add openexr support

[Martin Vignali]

Martin Vignali added the comment:

You're right, i make the correction, in a new patch.

I make other tests, with official sample files : 
http://download.savannah.nongnu.org/releases/openexr/openexr-images-1.4.0.tar.gz

--
Added file: http://bugs.python.org/file33554/img_hdr_exr_3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20295] imghdr add openexr support

[SilentGhost]

SilentGhost added the comment:

Martin, it would be better if you do the check the way it's done in test_rast: 
h.startswith(b'\x76\x2f\x31\x01')

Otherwise, you need to check that that h has at least 4 elements (if it doesn't 
you'll get an IndexError).

--
nosy: +SilentGhost

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20295] imghdr add openexr support

[Martin Vignali]

Martin Vignali added the comment:

New patch with formatting correction and documentation update.

I'm not sure about the place of the versionadded directive in the documentation.

--
Added file: http://bugs.python.org/file33547/img_hdr_exr_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20295] imghdr add openexr support

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +berker.peksag
stage:  -> patch review
versions: +Python 3.5 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20295] imghdr add openexr support

[Martin Vignali]

New submission from Martin Vignali:

Add support for detect openexr file (http://www.openexr.com/)
Based on information provided by :  
http://www.openexr.com/ReadingAndWritingImageFiles.pdf

I make some tests, on different kind of exr file, to check, the new function.

--
components: Library (Lib)
files: img_hdr_exr.patch
keywords: patch
messages: 208409
nosy: mvignali
priority: normal
severity: normal
status: open
title: imghdr add openexr support
type: enhancement
versions: Python 3.4
Added file: http://bugs.python.org/file33531/img_hdr_exr.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com