[issue20350] Replace tkapp.split() to tkapp.splitlist()

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 2.7, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20350] Replace tkapp.split() to tkapp.splitlist()

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8d78cd7c4a9e by Serhiy Storchaka in branch 'default':
Issue #20350. tkapp.splitlist() is now always used instead of unreliable
https://hg.python.org/cpython/rev/8d78cd7c4a9e

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20350] Replace tkapp.split() to tkapp.splitlist()

[Terry J. Reedy]

Terry J. Reedy added the comment:

FWIW, patch applies cleanly to 3.6 on Windows and test_idle passes.

--
versions: +Python 3.5, Python 3.6 -Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20350] Replace tkapp.split() to tkapp.splitlist()

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Most methods are tested now.

There is a difference between split() and splitlist() in Variable.trace_vinfo() 
if the tracer was assigned not by Tkinter method Variable.trace_variable(), but 
by direct execution of Tcl command "trace add variable" and additional 
arguments were included in commandPrefix. This is very unusual case, and I 
think that the result would be more expectable if use splitlist() in 
Variable.trace_vinfo().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20350] Replace tkapp.split() to tkapp.splitlist()

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I use Linux. Unfortunately these methods (as most methods in Tkinter) are not 
tested. IDLE doesn't use any of these methods.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20350] Replace tkapp.split() to tkapp.splitlist()

[Terry J. Reedy]

Terry J. Reedy added the comment:

I know split has been troublesome and I am generally in favor of removing 
semi-duplication. Here are my questions.
What system are you developing and testing on?
Should I try the patch on Windows?
Have you used coveragepy to see if the patched areas are covered by tests?
Have you run Idle with the patch in place (though it does not use tix that I 
know of)?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20350] Replace tkapp.split() to tkapp.splitlist()

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

If there are no objections I'll commit this patch tomorrow.

--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20350] Replace tkapp.split() to tkapp.splitlist()

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Proposed patch replaces errorprone uses of tkapp.split() to tkapp.splitlist().

* Variable.trace_vinfo(). Actually there are no difference between split() and 
splitlist(), because "trace vinfo" always returns a list of 2-element tuple of 
strings and none of these can't contain spaces, '\\', or '{' (at least this 
can't be created from Tkinter).

* Misc.winfo_visualsavailable() already has a workaround for split() 
peculiarity. With splitlist() the code is more straightforward.

* tix.ListNoteBook.pages() and tix.NoteBook.pages() with split() can fail when 
there is only one page or when page names contain spaces or special characters.

* tix.CheckList.getselection() already has a workaround for split() 
peculiarity. It calls splitlist() for result of split(). split() call is 
redundant.

* In tix.Grid.size_column() and tix.Grid.size_row() there are no significant 
differences in behavior between split() and splitlist().

After these changes tkapp.split() no longer be used in the stdlib and can be 
deprecated.

--
components: Library (Lib), Tkinter
files: tkinter_use_splitlist.patch
keywords: patch
messages: 208831
nosy: gpolo, serhiy.storchaka, terry.reedy
priority: normal
severity: normal
stage: patch review
status: open
title: Replace tkapp.split() to tkapp.splitlist()
type: behavior
versions: Python 2.7, Python 3.3, Python 3.4
Added file: http://bugs.python.org/file33628/tkinter_use_splitlist.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com