[issue20480] Add ipaddress property to get name of reverse DNS pointer

[Leon Weber]

Leon Weber added the comment:

Oh nice, then fewer trees have to die. I’ve now signed the contributor’s 
agreement.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20480] Add ipaddress property to get name of reverse DNS pointer

[Nick Coghlan]

Nick Coghlan added the comment:

Gah, we still haven't fixed the contributor license docs on the main
CLA page (hopefully we'll finally have that sorted later this month).
In the meantime, if you go directly to
http://www.python.org/psf/contrib/contrib-form/ it should give you the
option to sign electronically:
http://www.python.org/psf/contrib/contrib-form/

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20480] Add ipaddress property to get name of reverse DNS pointer

[Leon Weber]

Leon Weber added the comment:

Thanks for the feedback, I agree "reverse_pointer" is a better, less ambiguous 
name for the property. I’ve amended the patch to reflect this suggestion.

Regarding the trailing dot, I felt it more appropriate to have it that to leave 
it out, but I don’t have a strong opinion on this. It has to be there in the 
DNS query, but most tools will automatically add it to the query if it’s not 
specified. The "host" tool from bind-utils is undecided as well when printing 
the output, it includes the trailing dot when querying IPv4 addresses, but not 
for IPv6 addresses.

Including the trailing dot has the advantage that the output could be directly 
fed into other code that strictly requires it, like the dnspython module.

I’ll sign and submit the contributor’s agreement as soon as I’m within reach of 
a printer (likely within the next 24 hours).

--
Added file: http://bugs.python.org/file33852/ipaddress_reverse_names_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20480] Add ipaddress property to get name of reverse DNS pointer

[Antoine Pitrou]

Antoine Pitrou added the comment:

Thanks for the patch, Leon. Is the trailing dot actually desired?

>>> ipaddress.ip_address("127.0.0.1").reverse_name
'1.0.0.127.in-addr.arpa.'

Also, to accept your contribution, we will need you to fill a contributor's 
agreement. See http://www.python.org/psf/contrib/

--
nosy: +pitrou
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20480] Add ipaddress property to get name of reverse DNS pointer

[Nick Coghlan]

Nick Coghlan added the comment:

Heh, my initial reaction based on the issue title was the same as Eric's, but 
yes, I agree the pure text manipulation proposed in the patch is actually a 
good fit.

Rather than "reverse_name" (which I feel is ambiguous about whether or not it 
does the DNS lookup to resolve back to the canonical name for the address), I 
would suggest the attribute name "reverse_pointer" or "reverse_record" (with a 
slight preference for the former, as indicated in the updated issue title).

--
title: Add ipaddress property to get reverse DNS name -> Add ipaddress property 
to get name of reverse DNS pointer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com