[issue20490] Show clear error message on circular import

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

This PR introduced a reference leak tracked in:

https://bugs.python.org/issue38090

--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20490] Show clear error message on circular import

[Steve Dower]

Steve Dower  added the comment:


New changeset 2d5594fac21a81a06f82c3605318dfa96e72398f by Steve Dower in branch 
'3.8':
bpo-20490: Improve circular import error message (GH-15308)
https://github.com/python/cpython/commit/2d5594fac21a81a06f82c3605318dfa96e72398f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20490] Show clear error message on circular import

[Steve Dower]

Steve Dower  added the comment:

Thanks for the patch, Anthony!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20490] Show clear error message on circular import

[Steve Dower]

Change by Steve Dower :


--
pull_requests: +15444
pull_request: https://github.com/python/cpython/pull/15791

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20490] Show clear error message on circular import

[Steve Dower]

Steve Dower  added the comment:


New changeset 65366bc8bdc4716ebc361e622590b45a6e5aef07 by Steve Dower (Anthony 
Sottile) in branch 'master':
bpo-20490: Improve circular import error message (GH-15308)
https://github.com/python/cpython/commit/65366bc8bdc4716ebc361e622590b45a6e5aef07


--
nosy: +steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20490] Show clear error message on circular import

[Anthony Sottile]

Change by Anthony Sottile :


--
nosy: +Anthony Sottile
versions: +Python 3.8, Python 3.9 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20490] Show clear error message on circular import

[Anthony Sottile]

Change by Anthony Sottile :


--
keywords: +patch
pull_requests: +15028
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15308

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20490] Show clear error message on circular import

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
nosy: +Arfrever

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20490] Show clear error message on circular import

[Brett Cannon]

Brett Cannon added the comment:

It's not as simple as it sounds because failures from "from ... import ..." are 
triggered in the eval loop and not in import and without thinking it through I 
don't know if you could use the fine-grained import locks to inspect if 
something is in the middle of being imported or not that way.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20490] Show clear error message on circular import

[R. David Murray]

Changes by R. David Murray :


--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20490] Show clear error message on circular import

[Yury Selivanov]

Changes by Yury Selivanov :


--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20490] Show clear error message on circular import

[Yury Selivanov]

Changes by Yury Selivanov :


--
nosy: +yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20490] Show clear error message on circular import

[Ram Rachum]

New submission from Ram Rachum:

If there's a circular import in my program, I don't want to see an error 
message, "Cannot import name 'foo'" and then say in my mind, "ah, I'm an 
experienced Python developer, I know that when Python says that it often means 
that there's a circular import problem." I want the error message to **say 
there's a circular import problem**, so (a) I won't have to remember this piece 
of trivia and (b) less experienced developers won't have to bang their heads on 
their desks trying to figure out why the import isn't working. 

Bonus points if the error message actually shows which module is trying to 
import a module that imports itself, so we'll know where to fix.

--
components: Interpreter Core
messages: 210006
nosy: cool-RR
priority: normal
severity: normal
status: open
title: Show clear error message on circular import
type: enhancement
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com