[issue20796] Test failures when running with PYTHONDONTWRITEBYTECODE

2014-02-27 Thread Chris Angelico 

Changes by Chris Angelico ros...@gmail.com:


--
components: +Tests
versions: +Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20796
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20796] Test failures when running with PYTHONDONTWRITEBYTECODE

2014-02-27 Thread Chris Angelico 

New submission from Chris Angelico:

$ find . -name \*.pyc -delete
$ PYTHONDONTWRITEBYTECODE=1 make test

Three test failures, which all seem to be duplicates of:

==
FAIL: test_timestamp_overflow 
(test.test_importlib.source.test_file_loader.Source_SimpleTest)
--
Traceback (most recent call last):
  File 
/home/rosuav/cpython/Lib/test/test_importlib/source/test_file_loader.py, line 
215, in test_timestamp_overflow
self.assertTrue(os.path.exists(compiled))
AssertionError: False is not true

--


It goes looking for the .pyc cached file, does not find it, and fails. Test 
should probably be skipped if bytecode isn't being written.

--
messages: 212356
nosy: Rosuav
priority: normal
severity: normal
status: open
title: Test failures when running with PYTHONDONTWRITEBYTECODE

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20796
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20796] Test failures when running with PYTHONDONTWRITEBYTECODE

2014-02-27 Thread Berker Peksag 

Berker Peksag added the comment:

Here's a patch to skip the test if PYTHONDONTWRITEBYTECODE is not None.

--
keywords: +patch
nosy: +berker.peksag
Added file: http://bugs.python.org/file34246/issue20796.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20796
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20796] Test failures when running with PYTHONDONTWRITEBYTECODE

2014-02-27 Thread Brett Cannon 

Changes by Brett Cannon br...@python.org:


--
assignee:  - brett.cannon
nosy: +brett.cannon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20796
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20796] Test failures when running with PYTHONDONTWRITEBYTECODE

2014-02-27 Thread Berker Peksag 

Berker Peksag added the comment:

Updated patch adressing Brett's comment. Thanks!

--
stage:  - patch review
Added file: http://bugs.python.org/file34247/issue20796_v2.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20796
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20796] Test failures when running with PYTHONDONTWRITEBYTECODE

2014-02-27 Thread Brett Cannon 

Brett Cannon added the comment:

LGTM; I (or some other core dev) will commit when there's time.

--
stage: patch review - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20796
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20796] Test failures when running with PYTHONDONTWRITEBYTECODE

2014-02-27 Thread Chris Angelico 

Chris Angelico added the comment:

Thanks for the fast turn-around, guys! Not that it matters hugely - I happened 
to have bytecode writing disabled to test something unrelated and noticed the 
test failure.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20796
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20796] Test failures when running with PYTHONDONTWRITEBYTECODE

2014-02-27 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 8afcfe6dfd6e by Benjamin Peterson in branch '3.3':
fix importlib test failure when bytecode writing is disabled (closes #20796)
http://hg.python.org/cpython/rev/8afcfe6dfd6e

New changeset 15a0bbfb27f1 by Benjamin Peterson in branch 'default':
merge 3.3 (#20796)
http://hg.python.org/cpython/rev/15a0bbfb27f1

--
nosy: +python-dev
resolution:  - fixed
stage: commit review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20796
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com