[issue21139] Idle: change default reformat width from 70 to 72

[Terry J. Reedy]

Terry J. Reedy added the comment:

I put 21138 in the commit message. The push messages are these.
New changeset 374746c5dedc by Terry Jan Reedy in branch '2.7':
Issue #21138: Change default reformat paragraph width to PEP 8's 72.
http://hg.python.org/cpython/rev/374746c5dedc

New changeset dd24099c0cf6 by Terry Jan Reedy in branch '3.4':
Issue #21138: Change default reformat paragraph width to PEP 8's 72.
http://hg.python.org/cpython/rev/dd24099c0cf6

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21139] Idle: change default reformat width from 70 to 72

[Terry J. Reedy]

Terry J. Reedy added the comment:

I applied my patch as part of #21284. When I did so, I added 'limit=70' so that 
the tests pass otherwise unchanged. The only thing left here is to change 
config-main.def.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21139] Idle: change default reformat width from 70 to 72

[Terry J. Reedy]

Terry J. Reedy added the comment:

I am puzzled at the differences between the 2.7 and 3.4 patches. There are only 
three differences between the files

- from Tkinter import Tk, Text, TclError
+ from tkinter import Tk, Text, TclError
?  ^
- from test.test_support import requires
+ from test.support import requires
?   ^
- get_selection_indices = EditorWindow.get_selection_indices.im_func
+ get_selection_indices = EditorWindow. get_selection_indices
 
and none of these should affect the patch.

The attached patch adds a limit parameter to the 
FormatParagraph.format_paragraph_event method ReformatParagraph.py that is 
called as self.formatter in the tests.
  cls.formatter = fp.FormatParagraph(editor).format_paragraph_event
With this change, we can augment the calls to
self.formatter('ParameterDoesNothing', 72)
and the tests will ignore the configured value.

--
Added file: http://bugs.python.org/file34904/21139-34-fpe.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21139] Idle: change default reformat width from 70 to 72

[Saimadhav Heblikar]

Changes by Saimadhav Heblikar :


Added file: http://bugs.python.org/file34764/issue21139-34.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21139] Idle: change default reformat width from 70 to 72

[Saimadhav Heblikar]

Saimadhav Heblikar added the comment:

Attaching a patch for 2.7 and 3.4
The comment strings are modified to reflect 70->72 in the tests.

--
keywords: +patch
Added file: http://bugs.python.org/file34763/issue21139-27.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21139] Idle: change default reformat width from 70 to 72

[Terry J. Reedy]

Terry J. Reedy added the comment:

Changing the default in the default configuration file is trivial. In 
test_formatparagraph.FormatEventTest, test_comment_block and test_long_line 
currently fail if the reformat width is changed on the General tab of the 
configuration dialog. These tests will need to be altered when the default is 
changed. Also, the tests should temporarily change the reformat width to the 
presumed default in the class setup and teardown methods. If this is not 
possible, the tests should be skipped if it is not what the test requires.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21139] Idle: change default reformat width from 70 to 72

[Saimadhav Heblikar]

Changes by Saimadhav Heblikar :


--
nosy: +sahutd

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21139] Idle: change default reformat width from 70 to 72

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
components: +IDLE

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21139] Idle: change default reformat width from 70 to 72

[Terry J. Reedy]

New submission from Terry J. Reedy:

PEP 8 specifies a limit of 72 chars for flowing text (comments, multiline 
strings). The current default limit for Idle's Format / Reformat Paragraph is 
70. Increase it to PEP 8's 72.

--
messages: 215417
nosy: terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: Idle: change default reformat width from 70 to 72
type: enhancement
versions: Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com