[issue21256] Sort keyword arguments in mock _format_call_signature
Roundup Robot added the comment: New changeset 8e05e15901a8 by Kushal Das in branch 'default': Closes #21256: Printout of keyword args in deterministic order in mock calls. http://hg.python.org/cpython/rev/8e05e15901a8 -- nosy: +python-dev resolution: - fixed stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21256 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21256] Sort keyword arguments in mock _format_call_signature
Michael Foord added the comment: I agree with Antoine's review comments. With those changes in place, ok to commit. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21256 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21256] Sort keyword arguments in mock _format_call_signature
Kushal Das added the comment: New patch with test and news entry. -- Added file: http://bugs.python.org/file34998/issue21256_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21256 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21256] Sort keyword arguments in mock _format_call_signature
New submission from Michael Foord: Printing call args produces non-deterministic results, making them more or less useless in doctests. kwargs_string = ', '.join([ '%s=%r' % (key, value) for key, value in kwargs.items() ]) should be: kwargs_string = ', '.join([ '%s=%r' % (key, value) for key, value in sorted(kwargs.items()) ]) -- assignee: michael.foord keywords: easy messages: 216491 nosy: kushal.das, michael.foord priority: normal severity: normal stage: needs patch status: open title: Sort keyword arguments in mock _format_call_signature type: behavior versions: Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21256 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21256] Sort keyword arguments in mock _format_call_signature
Eric Snow added the comment: Ordered kwargs anyone? :) -- nosy: +eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21256 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21256] Sort keyword arguments in mock _format_call_signature
Kushal Das added the comment: Patch uploaded for the same. -- keywords: +patch Added file: http://bugs.python.org/file34914/issue21256.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21256 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21256] Sort keyword arguments in mock _format_call_signature
Michael Foord added the comment: Yes to ordered kwargs! I would very much like to be able to order the keyword args in the order they were passed in, information which is currently lost. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21256 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21256] Sort keyword arguments in mock _format_call_signature
Michael Foord added the comment: Needs a test. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21256 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
