[issue21289] make.bat not building documentation
Zachary Ware added the comment: Your more recent patch looks like it's missing the changes to Doc/make.bat, which I assume was unintentional :). Also, thinking about it again, it would be good to use a %SPHINXBUILD% variable rather than hard-coding sphinx-build into the script, the same way %PYTHON% is used currently. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21289 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21289] make.bat not building documentation
Roundup Robot added the comment: New changeset 02fec733f760 by Zachary Ware in branch '3.4': Issue #21289: Fix documentation building on Windows using Doc/make.bat. http://hg.python.org/cpython/rev/02fec733f760 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21289 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21289] make.bat not building documentation
Zachary Ware added the comment: Fixed, thanks for the patch! I went ahead and implemented my comments and committed it. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21289 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21289] make.bat not building documentation
Dave Sawyer added the comment: Thanks Zach, I'm used to Git and this was my first foray with Hg and trying to rebase (I knew I shoulda branched before starting on another patch). BTW, the devs at PyCon Montreal said Zach's a good guy. One of maybe 4 Windows devs. -Dave -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21289 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21289] make.bat not building documentation
New submission from Dave Sawyer: With Python 3.5, some refactoring of the documentation structure has been done. Building the documentation targets directly works, but using the supplied make.bat fails, not finding the sphinx python file. -- assignee: docs@python components: Documentation messages: 216737 nosy: docs@python, dsawyer priority: normal severity: normal status: open title: make.bat not building documentation type: compile error versions: Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21289 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21289] make.bat not building documentation
Changes by Dave Sawyer dsaw...@box.com: -- type: compile error - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21289 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21289] make.bat not building documentation
Changes by Dave Sawyer dsaw...@box.com: -- keywords: +patch Added file: http://bugs.python.org/file34954/mywork.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21289 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21289] make.bat not building documentation
Dave Sawyer added the comment: Removed the use of python in the make, calling the sphinx-build executable. Also the Doc directory was called Docs in the readme.txt -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21289 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21289] make.bat not building documentation
Zachary Ware added the comment: I left a review on Rietveld, which should have sent you an email. Thanks for the report and patch! If you plan on submitting anything more than the most trivial of patches, could you please sign the contributor agreement[1][2]? Thanks! [1]The form: https://www.python.org/psf/contrib/contrib-form/ [2]More information: https://www.python.org/psf/contrib/ -- assignee: docs@python - zach.ware nosy: +zach.ware stage: - patch review versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21289 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21289] make.bat not building documentation
Changes by Dave Sawyer dsaw...@box.com: Added file: http://bugs.python.org/file34957/mywork.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21289 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21289] make.bat not building documentation
Dave Sawyer added the comment: Thanks Zach! The bug tracker was nice enough to prompt me to go look in my email for the agreement too. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21289 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
