[issue21411] Enable Treat Warning as Error on 32-bit Windows

[Zachary Ware]

Zachary Ware  added the comment:

We've introduced enough new warnings in the past 3 years that this is not 
viable at this point.  If we decide we want warnings in the compile stage to 
set the whole build to warnings, we can open an issue in 
https://github.com/python/buildmaster-config for that.

--
resolution:  -> rejected
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21411] Enable Treat Warning as Error on 32-bit Windows

[Tim Golden]

Tim Golden added the comment:

Sounds good to me. It's really a question as to the point where
practicality beats purity...

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21411
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21411] Enable Treat Warning as Error on 32-bit Windows

[Steve Dower]

Steve Dower added the comment:

I think we should fix all the warnings, but turning this on is a great way to 
make the build bots red often. I believe they already go yellow for warnings, 
so people are somewhat informed, but I don't think we want to be more 
aggressive than that.

Also, I know someone who has a patch coming that fixes most of these, so we can 
ignore this for a bit more and just get the fix that way if we want.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21411
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21411] Enable Treat Warning as Error on 32-bit Windows

[Zachary Ware]

Zachary Ware added the comment:

Steve Dower added the comment:
 I think we should fix all the warnings, but turning this on is a great
way to make the build bots red often.

That is the obvious downside. On the other hand, we do have a very old open
issue (though I don't have the number handy) in which Guido made clear that
a build with no warnings on every possible platform would be ideal and is
desired, and this would help make sure we stay there when we reach that
point.

 I believe they already go yellow for warnings, so people are somewhat
informed, but I don't think we want to be more aggressive than that.

The individual step is colored yellow, but not the whole build. So if
you're just looking at the headings on the waterfall page, you'll never
notice. I'm not sure if we can change that setting, but that might be a
nicer solution.

 Also, I know someone who has a patch coming that fixes most of these, so
we can ignore this for a bit more and just get the fix that way if we want.

Ok, that sounds good. When that issue opens, would you mind linking it as a
dependency of this one?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21411
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21411] Enable Treat Warning as Error on 32-bit Windows

[Zachary Ware]

Zachary Ware added the comment:

This has been complicated by the migration to VS2015, which added a bunch of 
new warnings.  Obviously we can't enable this now without either fixing all the 
warnings (unlikely, I think; most of them are just about shadowing vars) or 
disabling particular ones.

So at this point, fix, disable, or reject?

--
nosy: +paul.moore, steve.dower

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21411
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21411] Enable Treat Warning as Error on 32-bit Windows

[Tim Golden]

Tim Golden added the comment:

I'm at least +0.5 on this: I rather like the idea of forcing these things out 
into the open.

The reason I'm not +1 is the danger of relatively benign or trivial 
warnings-turned-errors getting in the way of real, possibly critical, 
development.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21411
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21411] Enable Treat Warning as Error on 32-bit Windows

[Zachary Ware]

New submission from Zachary Ware:

Python 3.4 and 3.5 both compile without warnings on 32-bit Windows, so we 
should turn on Treat Warning as Error (/WX option to cl.exe).  Setting that 
property in pyproject.props sets it for all projects, and the setting does not 
affect Makefile projects so warnings from OpenSSL, Tcl, Tk, or Tix will not 
kill the build.  It will need to be explicitly disabled on 64-bit Windows; 
setting it in x64.props does the trick.

One small issue is that /WX does pick up the no profile information warning 
in the PGUpdate build.  I'm unsure whether we should turn off /WX in 
pgupdate.props, or just force PGUpdate builders to have run something for each 
PGI'd project.

--
components: Build, Windows
messages: 217722
nosy: loewis, tim.golden, zach.ware
priority: low
severity: normal
status: open
title: Enable Treat Warning as Error on 32-bit Windows
type: enhancement
versions: Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21411
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com