[issue21518] Expose RegUnLoadKey in winreg

[Eryk Sun]

Eryk Sun  added the comment:

I added an updated implementation of windows_helper.py to the dependency 
bpo-22080.

--
components: +Windows
nosy: +paul.moore
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnLoadKey in winreg

[Claudiu Popa]

Claudiu Popa added the comment:

Hello,

Can anyone review the last patch? Hopefully it is the final version, since the 
beta is really at the corner and I definitely would like to have this in 3.5.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnLoadKey in winreg

[Claudiu Popa]

Claudiu Popa added the comment:

Thank you for the review. The new patch uses the name UnLoadKey for the API.

--
Added file: http://bugs.python.org/file38481/issue21518_6.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnLoadKey in winreg

[Martin v . Löwis]

Martin v. Löwis added the comment:

The naming of the function needs discussion. I think it should be UnLoadKey, as 
the API function behind it is RegUnLoadKey (not RegUnloadKey). It may be 
illogical(*) that the function is called that way in the API, but it would add 
confusion if Python called it differently.

(*) It's UnlockFile that pairs LockFile, and UnmapViewOfFile that matches 
MapViewOfFile. OTOH, (undocumented) UTRegister is paired with UTUnRegister, and 
GlobalWire with GlobalUnWire.

--
nosy: +loewis
title: Expose RegUnloadKey in winreg -> Expose RegUnLoadKey in winreg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu Popa]

Changes by Claudiu Popa :


Added file: http://bugs.python.org/file38382/issue21518_5.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu Popa]

Changes by Claudiu Popa :


Added file: http://bugs.python.org/file37820/issue21518_4.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu Popa]

Claudiu Popa added the comment:

Ups, the last patch included an extra file.

--
Added file: http://bugs.python.org/file37819/issue21518_3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu Popa]

Claudiu Popa added the comment:

The new patch drops the weird error dance from test_unload_key, it seems to 
work without it, I don't remember how it failed without it.

--
Added file: http://bugs.python.org/file37742/issue21518_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu Popa]

Claudiu Popa added the comment:

Is there something I can do to move this forward?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu Popa]

Changes by Claudiu Popa :


--
dependencies: +Add windows_helper module helper

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu Popa]

Claudiu Popa added the comment:

Here's the patch with only the change for winreg.UnloadKey. I'll have the patch 
with windows_helper soon.

--
Added file: http://bugs.python.org/file35907/winreg_unload_key.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu Popa]

Claudiu Popa added the comment:

Sure, that sounds good.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Zachary Ware]

Zachary Ware added the comment:

I'd like to see the windows_helper.py part of the patch split into its own 
issue, and someone more qualified than I to review it (though I'll learn what I 
can and give it a shot if nobody else can).  The new issue should also try to 
use the new windows_helper utilities to replace what Brian mentioned in 
msg106613 for os.symlink privileges, since that's an existing place where it 
can be used.

The actual change of adding UnloadKey looks fine to me, aside from a copy/paste 
error in the documentation (s/subkey to load/subkey to unload/).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu Popa]

Claudiu Popa added the comment:

Any type of feedback will be appreciated.

--
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu Popa]

Claudiu Popa added the comment:

Attached a new version of the patch which cleanups properly after tests.

--
Added file: http://bugs.python.org/file35618/issue21518_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu.Popa]

Claudiu.Popa added the comment:

Thanks. Here's the updated version. Also, I only tested it on Windows 8.1. I'll 
try to find another machine with an older OS for testing it.

--
Added file: http://bugs.python.org/file35288/issue21518_1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[eryksun]

eryksun added the comment:

ctypes LibraryLoader instances cache CDLL/WinDLL instances, which cache 
function pointers. Using the global ctypes.cdll and ctypes.windll loaders can 
lead to conflicting definitions for restype, argtypes, and errcheck. I suggest 
using a private LibraryLoader in windows_helper, e.g.:

windll = ctypes.LibraryLoader(ctypes.WinDLL)

--
nosy: +eryksun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu.Popa]

Claudiu.Popa added the comment:

This version of the patch skips the test if the privileges can't be acquired.

--
Added file: http://bugs.python.org/file35285/issue21518.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu.Popa]

Claudiu.Popa added the comment:

It needs administrator elevation for running the test. I'll update the patch to 
skip the test if the user doesn't have elevation.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +steve.dower, tim.golden, zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21518] Expose RegUnloadKey in winreg

[Claudiu.Popa]

New submission from Claudiu.Popa:

Hello. While working on issue8579, I noticed that there is no way to detach a 
key from the registry, loaded with LoadKey function. The attached patch exposes 
RegUnLoadKeyW as winreg.UnloadKey. Also, this patch adds a new script in the 
test folder, windows_helper.py, which could be an useful addition for testing 
Windows specific issues, like acquiring / releasing a privilege.

--
components: Library (Lib)
files: winreg_unload_key.patch
keywords: patch
messages: 218708
nosy: Claudiu.Popa
priority: normal
severity: normal
status: open
title: Expose RegUnloadKey in winreg
type: enhancement
versions: Python 3.5
Added file: http://bugs.python.org/file35271/winreg_unload_key.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com