[issue21538] plistlib unable to load iOS7 Safari History.plist
Roundup Robot added the comment: New changeset f0452bc62cc3 by Serhiy Storchaka in branch '3.4': Issue #21538: The plistlib module now supports loading of binary plist files http://hg.python.org/cpython/rev/f0452bc62cc3 New changeset b2c5d0cba5fd by Serhiy Storchaka in branch 'default': Issue #21538: The plistlib module now supports loading of binary plist files http://hg.python.org/cpython/rev/b2c5d0cba5fd -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
Serhiy Storchaka added the comment: Thank you John for your report. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
Ronald Oussoren added the comment: The patch looks good. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
Serhiy Storchaka added the comment: And here is a patch with test. -- stage: test needed - patch review Added file: http://bugs.python.org/file35300/plistlib_read_refs_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file35299/plistlib_read_refs.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
John Lehr added the comment: Serhiy, I applied the patch and can confirm this is a fix (three previous failing loads of History.plists from three different devices now load successfully). Thank you, I would not likely have identified the issue myself. On Mon, May 19, 2014 at 11:08 PM, Serhiy Storchaka rep...@bugs.python.orgwrote: Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file35299/plistlib_read_refs.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
John Lehr added the comment: Patch plistlib_read_refs_2.patch corrects load error for iOS Safari History.plist. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
Serhiy Storchaka added the comment: Issue shouldn't be closed as resolved until patch is committed. Ronald, is it good to you? -- resolution: fixed - status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
New submission from John Lehr: plistlib has key error when attempting to load the iOS7 var/mobile/Applications/com.apple.mobilesafari/Library/Safari/History.plist. No detected issues with other iOS7 plists. In [8]: with open('cases/vitale_test_iphone/unback/AppDomain-com.apple.mobilesafari/Library/Safari/History.plist', 'rb') as f: ...: plist = plistlib.lo plistlib.load plistlib.loads ...: plist = plistlib.load(f) ...: --- KeyError Traceback (most recent call last) ipython-input-8-7824ac03848c in module() 1 with open('cases/vitale_test_iphone/unback/AppDomain-com.apple.mobilesafari/Library/Safari/History.plist', 'rb') as f: 2 plist = plistlib.load(f) 3 /usr/lib/python3.4/plistlib.py in load(fp, fmt, use_builtin_types, dict_type) 993 p = _FORMATS[fmt]['parser'](use_builtin_types=use_builtin_types) 994 -- 995 return p.parse(fp) 996 997 /usr/lib/python3.4/plistlib.py in parse(self, fp) 620 ) = struct.unpack('6xBBQQQ', trailer) 621 self._fp.seek(offset_table_offset) -- 622 offset_format = '' + _BINARY_FORMAT[offset_size] * num_objects 623 self._ref_format = _BINARY_FORMAT[self._ref_size] 624 self._object_offsets = struct.unpack( KeyError: 3 -- messages: 218821 nosy: slo.sleuth priority: normal severity: normal status: open title: plistlib unable to load iOS7 Safari History.plist type: crash versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
Ned Deily added the comment: Can you attach a zipped version of the failing plist or at least identify what data in it is causing the exception? Presumably that plist is user-specific, i.e. contains browser history. -- nosy: +ned.deily ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
John Lehr added the comment: I have shared the file for which I have permission, but neither of two History.plists in my possession will load, both with the same traceback. Thank you. On Mon, May 19, 2014 at 4:18 PM, Ned Deily rep...@bugs.python.org wrote: Ned Deily added the comment: Can you attach a zipped version of the failing plist or at least identify what data in it is causing the exception? Presumably that plist is user-specific, i.e. contains browser history. -- nosy: +ned.deily ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ -- Added file: http://bugs.python.org/file35295/History.plist.7z ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ History.plist.7z Description: application/7z-compressed ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
Changes by Ned Deily n...@acm.org: -- components: +Library (Lib) nosy: +ronaldoussoren, serhiy.storchaka -ned.deily type: crash - versions: +Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
Changes by Ned Deily n...@acm.org: Removed file: http://bugs.python.org/file35295/History.plist.7z ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
Ned Deily added the comment: John, a quick look at the file shows that it contains browsing history information that might be personally identifiable. I don't think that is appropriate to store on a public web site like this one so I've deleted the file. Is there some way to provide a simpler file with non-personal history? -- nosy: +ned.deily ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
John Lehr added the comment: Ned, I understand. I did get permission to post that history, and as I feared, the sanitized History.plist I'm attaching now doesn't have the loading issue that the first did. Possibly a URL character is throwing the exception? Can you suggest where I can put a print statement in the library or some other way to post to get you meaningful debug information? I don't have any experience with pdb, and a verbose python execution is pretty lengthy. As I said before, I have two more extensive History.plist files from two different devices that won't load. On Mon, May 19, 2014 at 5:51 PM, Ned Deily rep...@bugs.python.org wrote: Ned Deily added the comment: John, a quick look at the file shows that it contains browsing history information that might be personally identifiable. I don't think that is appropriate to store on a public web site like this one so I've deleted the file. Is there some way to provide a simpler file with non-personal history? -- nosy: +ned.deily ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ -- Added file: http://bugs.python.org/file35298/History.plist ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ History.plist Description: Binary data ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file35295/History.plist.7z ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file35295/History.plist.7z ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21538] plistlib unable to load iOS7 Safari History.plist
Serhiy Storchaka added the comment: I think this patch should fix the issue. But tests needed. -- keywords: +patch stage: - test needed type: - behavior Added file: http://bugs.python.org/file35299/plistlib_read_refs.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21538 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com