[issue21581] Consider dropping importlib.abc.Loader.create_module()

[Brett Cannon]

Brett Cannon added the comment:

create_module() is now slated to be required in Python 3.6.

--
resolution:  -> out of date
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21581] Consider dropping importlib.abc.Loader.create_module()

[Brett Cannon]

Changes by Brett Cannon :


--
assignee:  -> brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21581] Consider dropping importlib.abc.Loader.create_module()

[Brett Cannon]

Brett Cannon added the comment:

Issue #23014 is planning to make create_module() required so that module 
creation doesn't have a two-tiered way of specifying a default module (which is 
handy in C code).

--
dependencies: +Don't have importlib.abc.Loader.create_module() be optional

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21581] Consider dropping importlib.abc.Loader.create_module()

[Brett Cannon]

Brett Cannon added the comment:

This issue is not talking about dropping create_module() from the algorithm (I 
need it for the lazy loader), just from the ABC since it's a do-nothing 
implementation that doesn't have to be there.

Otherwise it should be made a required method and possibly even not have its 
``return None`` special-casing.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21581] Consider dropping importlib.abc.Loader.create_module()

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
nosy: +Arfrever

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21581] Consider dropping importlib.abc.Loader.create_module()

[Nick Coghlan]

Nick Coghlan added the comment:

I suggest waiting until we update the C extension import system before making a 
final decision - that was the concrete use case for the feature, so it may 
become less confusing once that is added.

--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21581] Consider dropping importlib.abc.Loader.create_module()

[Brett Cannon]

New submission from Brett Cannon:

As Armin Ronacher pointed out, it's a bit odd having the importlib.abc.Loader 
ABC have a method whose default does nothing and having the method itself be 
entirely optional. Might as well just drop it from the ABC and instead just 
make sure that create_module() is documented appropriately (it's such an 
advanced use case it might also simplify things to not have it in the typical 
user's face).

--
components: Library (Lib)
messages: 219159
nosy: brett.cannon
priority: normal
severity: normal
stage: test needed
status: open
title: Consider dropping importlib.abc.Loader.create_module()
type: behavior
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com