[issue21722] teach distutils upload to exit with code != 0 when error occurs
Antoine Pitrou added the comment: Thank you Martin. I will take a look soon at the patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Roundup Robot added the comment: New changeset d86214c98a9c by Antoine Pitrou in branch '3.4': Issue #21722: The distutils upload command now exits with a non-zero return code when uploading fails. http://hg.python.org/cpython/rev/d86214c98a9c New changeset 979aaa08c067 by Antoine Pitrou in branch 'default': Issue #21722: The distutils upload command now exits with a non-zero return code when uploading fails. http://hg.python.org/cpython/rev/979aaa08c067 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Antoine Pitrou added the comment: I've now committed the fix. Thank you for your contribution! -- resolution: - fixed stage: - resolved status: open - closed type: - behavior versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Roundup Robot added the comment: New changeset cf70f030a744 by Antoine Pitrou in branch '2.7': Issue #21722: The distutils upload command now exits with a non-zero return code when uploading fails. http://hg.python.org/cpython/rev/cf70f030a744 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Martin Dengler added the comment: I've got the contrib form bit now. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Martin Dengler added the comment: The attached file is a patch for backporting this fix to 2.7.7. -- Added file: http://bugs.python.org/file35573/cpython2-patch-Lib-distutils-command-upload.py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
New submission from Martin Dengler: This patch teaches distutils/command/upload.py to return a non-zero exit code when uploading fails. Currently a zero error code is returned (specifically, no Exception is raised by upload.run(...)) regardless of the HTTP response from the server or any socket error during that conversation. Should be applied against tip. Thanks. -- components: Library (Lib) files: cpython-patch-Lib-distutils-command-upload.py.patch keywords: patch messages: 220276 nosy: mdengler priority: normal severity: normal status: open title: teach distutils upload to exit with code != 0 when error occurs versions: Python 2.7, Python 3.5 Added file: http://bugs.python.org/file35572/cpython-patch-Lib-distutils-command-upload.py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Changes by Ned Deily n...@acm.org: -- components: +Distutils nosy: +dstufft, eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Antoine Pitrou added the comment: Thanks you for the patch. It may be good to add a unit test for this. Also, for development, it is probably better to use a Mercurial clone instead of trying to generate diffs by hand. See the devguide for more information: https://docs.python.org/devguide/ -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Martin Dengler added the comment: Here is the patch against hg tip. -- Added file: http://bugs.python.org/file35581/cpython-patch-Lib-distutils-command-upload.py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Changes by Martin Dengler mar...@martindengler.com: Removed file: http://bugs.python.org/file35573/cpython2-patch-Lib-distutils-command-upload.py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Martin Dengler added the comment: Here is the patch against hg 2.7. -- Added file: http://bugs.python.org/file35582/cpython2-patch-Lib-distutils-command-upload.py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Changes by Martin Dengler mar...@martindengler.com: Removed file: http://bugs.python.org/file35572/cpython-patch-Lib-distutils-command-upload.py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Martin Dengler added the comment: I will submit patches with tests as soon as the before after tests finish. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Martin Dengler added the comment: Here is the patch against tip, including a new test case. -- Added file: http://bugs.python.org/file35583/cpython-patch-Lib-distutils-command-upload.py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Martin Dengler added the comment: Here is the patch against 2.7, including a new test case. -- Added file: http://bugs.python.org/file35584/cpython2-patch-Lib-distutils-command-upload.py.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21722] teach distutils upload to exit with code != 0 when error occurs
Martin Dengler added the comment: If you'd like me to change anything about the test case please let me know. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21722 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
