[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21802 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails
Roundup Robot added the comment: New changeset d4694c672c36 by Serhiy Storchaka in branch '3.4': Issue #21802: The reader in BufferedRWPair now is closed even when closing https://hg.python.org/cpython/rev/d4694c672c36 New changeset f515c7ccff57 by Serhiy Storchaka in branch 'default': Issue #21802: The reader in BufferedRWPair now is closed even when closing https://hg.python.org/cpython/rev/f515c7ccff57 New changeset dcf25060cae8 by Serhiy Storchaka in branch '2.7': Issue #21802: The reader in BufferedRWPair now is closed even when closing https://hg.python.org/cpython/rev/dcf25060cae8 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21802 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21802 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails
Changes by Martin Panter vadmium...@gmail.com: -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21802 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails
Serhiy Storchaka added the comment: Ping. If this patch will be accepted I'll provide larger patch for similar issues in close methods of other classes. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21802 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails
Antoine Pitrou added the comment: Why don't you reuse the API from issue21715? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21802 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails
Serhiy Storchaka added the comment: Because this API was not still committed. Here is a patch which uses it. -- Added file: http://bugs.python.org/file37271/bufferedrwpair_close_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21802 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails
Serhiy Storchaka added the comment: Antoine, what do you think about this? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21802 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails
New submission from Serhiy Storchaka: Current implementation of BufferedRWPair.close() is: def close(self): self.writer.close() self.reader.close() When self.writer.close() raises an exception, self.reader left non-closed. This can cause file description leak unless GC sweep it. Proposed patch fixes this issue. With applied patch for issue21715 it would be a little simpler. -- components: IO files: bufferedrwpair_close.patch keywords: patch messages: 220945 nosy: benjamin.peterson, pitrou, serhiy.storchaka, stutzbach priority: normal severity: normal stage: patch review status: open title: Reader of BufferedRWPair is not closed if writer's close() fails type: behavior versions: Python 2.7, Python 3.4, Python 3.5 Added file: http://bugs.python.org/file35684/bufferedrwpair_close.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21802 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
