[issue21803] Remove macro indirections in complexobject
Mark Dickinson added the comment: LGTM. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21803 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21803] Remove macro indirections in complexobject
Roundup Robot added the comment: New changeset 9f75a29c9577 by Antoine Pitrou in branch 'default': Issue #21803: remove macro indirections in complexobject.h http://hg.python.org/cpython/rev/9f75a29c9577 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21803 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21803] Remove macro indirections in complexobject
Antoine Pitrou added the comment: Ok, pushed. -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21803 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21803] Remove macro indirections in complexobject
STINNER Victor added the comment: Failure on buildbot. http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%203.x/builds/4599/steps/test/logs/stdio running build_ext building 'cmath' extension gcc -pthread -fPIC -Wno-unused-result -Werror=declaration-after-statement -g -O0 -Wall -Wstrict-prototypes -I./Include -I. -IInclude -I/usr/include/x86_64-linux-gnu -I/usr/local/include -I/opt/python/3.x.langa-ubuntu/build/Include -I/opt/python/3.x.langa-ubuntu/build -c /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c -o build/temp.linux-x86_64-3.5-pydebug/opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.o /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c: In function ‘c_atanh’: /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c:316:9: warning: implicit declaration of function ‘c_neg’ [-Wimplicit-function-declaration] /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c:316:9: error: incompatible type for argument 1 of ‘c_atanh’ /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c:307:1: note: expected ‘Py_complex’ but argument is of type ‘int’ /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c: In function ‘cmath_log’: /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c:845:9: warning: implicit declaration of function ‘c_quot’ [-Wimplicit-function-declaration] /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c:845:11: error: incompatible types when assigning to type ‘Py_complex’ from type ‘int’ /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c: In function ‘cmath_polar’: /opt/python/3.x.langa-ubuntu/build/Modules/cmathmodule.c:946:5: warning: implicit declaration of function ‘c_abs’ [-Wimplicit-function-declaration] Failed to build these modules: cmath -- nosy: +haypo resolution: fixed - status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21803 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21803] Remove macro indirections in complexobject
Antoine Pitrou added the comment: Ha, I hadn't noticed the compilation failures when rebuilding... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21803 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21803] Remove macro indirections in complexobject
Roundup Robot added the comment: New changeset 4609e31092b2 by Antoine Pitrou in branch 'default': Fix compilation failure (followup to #21803) http://hg.python.org/cpython/rev/4609e31092b2 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21803 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21803] Remove macro indirections in complexobject
Changes by Antoine Pitrou pit...@free.fr: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21803 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21803] Remove macro indirections in complexobject
New submission from Antoine Pitrou: I thought this would make things less confusing to read. -- components: Interpreter Core files: complex_macros.patch keywords: patch messages: 220947 nosy: mark.dickinson, pitrou priority: low severity: normal stage: patch review status: open title: Remove macro indirections in complexobject type: enhancement versions: Python 3.5 Added file: http://bugs.python.org/file35685/complex_macros.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21803 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
