[issue21941] Clean up turtle TPen class

[Carol Willing]

Carol Willing  added the comment:

Hi ingrid,

Thanks for your work on this issue.

I'm triaging the open "turtle" issues, and I'm going to go ahead and close this 
one. If you would like to open a new, more specific issue, I would welcome 
that. Thanks.

--
nosy: +willingc
resolution:  -> remind
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21941] Clean up turtle TPen class

[ingrid]

ingrid added the comment:

Ah, I think I was mistaken about some things when I made the first patch but it 
looks like TPen have a few methods that don't work as you'd expect. Since 
_colorstr isn't implemented on TPen fillcolor and pencolor pen don't work as 
intended when you call them directly from TPen. Jesstess suggested raising a 
NotImplementedError on these functions. Would that be a good change to make?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21941
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21941] Clean up turtle TPen class

[Ezio Melotti]

Ezio Melotti added the comment:

While TPen doesn't seem to be documented, it's not prefixed by a '_', so there 
might people using it and relying on these methods.

--
nosy: +ezio.melotti

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21941
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21941] Clean up turtle TPen class

[ingrid]

New submission from ingrid:

There are a lot of methods in the TPen class that are defined but not used 
because all the child classes overwrite almost all the functions and TPen 
itself isn't used directly a whole lot. This patch removes the unused code so 
it's less confusing to read turtle.py.

--
components: Library (Lib)
files: TPen_cleanup.patch
keywords: patch
messages: 222598
nosy: ingrid, jesstess
priority: normal
severity: normal
status: open
title: Clean up turtle TPen class
type: enhancement
versions: Python 3.5
Added file: http://bugs.python.org/file35909/TPen_cleanup.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21941
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com