[issue22343] Install bash activate script on Windows when using venv

[Vinay Sajip]

Changes by Vinay Sajip :


--
assignee:  -> vinay.sajip
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Evan]

Evan added the comment:

Works for me on the master branch. Thanks, Vinay.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Vinay Sajip]

Vinay Sajip added the comment:

Changesets:

3.5 d6ae934da199
3.6 8f77c4f93806
default 7afe82ad34e7

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Vinay Sajip]

Vinay Sajip added the comment:

I've pushed the changes, but due to some SMTP problem this issue wasn't updated 
by Roundup:

remote: SMTPServerDisconnected: Connection unexpectedly closed: timed out
remote: error: changegroup.roundup hook raised an exception: Connection 
unexpectedly closed: timed out

However, the changes appear to be in the repository. Interested parties might 
want to pull the changes and test things out on Windows so that the issue can 
be closed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Evan]

Evan added the comment:

Works for me in Git Bash.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Kevin Christopher Henry]

Kevin Christopher Henry added the comment:

I can confirm that LF endings work fine on Cygwin, and it's hard to imagine any 
bash implementation not handling that properly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Vinay Sajip]

Vinay Sajip added the comment:

If we do this, the activate script will have LF (POSIX) line endings on 
Windows. Will this work for things like cygwin, Git-bash etc?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Evan]

Evan added the comment:

+1, I'm also using Windows with Git Bash and venv is unusable for me without 
Brandon's workaround.

--
nosy: +evan_

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Brandon VanVaerenbergh - NOAA Affiliate]

Brandon VanVaerenbergh - NOAA Affiliate added the comment:

+1 just experienced this issue migrating from Python3.4 to Python3.5 on windows 
with bash (MINGW git bash) as primary shell

Temporarily resolved issue (on this workstation) by simply copying 
Python35\Lib\venv\scripts\posix\activate file, into folder: 
Python35\Lib\venv\scripts\nt\

then recreating venv

--
nosy: +Brandon VanVaerenbergh - NOAA Affiliate
versions: +Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Paul Moore]

Paul Moore added the comment:

Presumably this would just be a case of moving "activate" from 
venv/scripts/posix to venv/scripts/common? I don't think including csh or fish 
scripts on Windows is worthwhile...

Attached is a patch on that basis. I didn't see any tests for which scripts 
were installed, so I don't think there's anything to change there.

--
keywords: +patch
nosy: +paul.moore
Added file: http://bugs.python.org/file38851/activate.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
stage:  -> test needed
versions: +Python 3.5 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Vinay Sajip]

Vinay Sajip added the comment:

I have no particular objection to this, and it's not a lot of work to make it 
happen. The POSIX scripts were left out in case the opposite view was advanced 
- that these scripts would be of no use to most people on Windows, and 
shouldn't be there cluttering up the place :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Nick Coghlan]

Nick Coghlan added the comment:

+1 from me - Vinay?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Ned Deily]

Changes by Ned Deily :


--
nosy: +ncoghlan, vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22343] Install bash activate script on Windows when using venv

[Kevin Christopher Henry]

New submission from Kevin Christopher Henry:

When I use venv to create a new virtual environment in Windows I'm given two 
activate scripts, a .bat file and a .ps1 file (which is consistent with the 
documentation).

However, bash (and probably the other shells as well) works just fine in 
Windows under Cygwin. Since you have these scripts anyway, please include them 
in the Windows virtual environment (as virtualenv did).

--
components: Windows
messages: 226452
nosy: marfire
priority: normal
severity: normal
status: open
title: Install bash activate script on Windows when using venv
type: enhancement
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com