[issue22628] Idle: Tree lines are spaced too close together.

[Terry J. Reedy]

Terry J. Reedy  added the comment:

We started using ttk widgets in 3.6.  As I said above, the real solution should 
be to use ttk.Treeview.  This is issue 31552.

--
resolution:  -> fixed
status: open -> closed
superseder:  -> IDLE: Convert browswers to use ttk.Treeview

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22628] Idle: Tree lines are spaced too close together.

[Jean-Paul Calderone]

Jean-Paul Calderone  added the comment:

This is still/again broken, probably because the "fixed" version still 
hard-codes all of the geometry values and these will certainly not be correct 
for all combinations of display dpi, font configuration, etc.

Instead, `TreeNode.draw` and `TreeNode.drawtext` (at least) need to consider 
the size of the children and space them accordingly.

--
nosy: +exarkun
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22628] Idle: Tree lines are spaced too close together.

[Al Sweigart]

Changes by Al Sweigart :


--
nosy: +Al.Sweigart

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22628] Idle: Tree lines are spaced too close together.

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22628] Idle: Tree lines are spaced too close together.

[Roundup Robot]

Roundup Robot added the comment:

New changeset aa447531490d by Terry Jan Reedy in branch '2.7':
Issue #22628: Increase Treewidge line spacing so lines do not overlap.
https://hg.python.org/cpython/rev/aa447531490d

New changeset ffe4f3694c0f by Terry Jan Reedy in branch '3.4':
Issue #22628: Increase Treewidge line spacing so lines do not overlap.
https://hg.python.org/cpython/rev/ffe4f3694c0f

New changeset 7ee79c3d4f5f by Terry Jan Reedy in branch 'default':
Merge with 3.4 Issue #22628
https://hg.python.org/cpython/rev/7ee79c3d4f5f

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22628] Idle: Tree lines are spaced too close together.

[Saimadhav Heblikar]

Saimadhav Heblikar added the comment:

It does not change anything else other than the intended, so looks OK on linux.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22628] Idle: Tree lines are spaced too close together.

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
components: +IDLE

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22628] Idle: Tree lines are spaced too close together.

[Terry J. Reedy]

New submission from Terry J. Reedy:

(Mentioned on #16233) At least on my windows 7 system, the lines of 
idlelib.TreeWidget, used for Path Browser and Class (Module) Browser, are 
spaced too narrowly.  They are so close together that they overlap and each 
cuts off enough of the line above to make reading difficult.

TreeWidget is actually a canvas painted with icons, connecting lines, and lines 
of text. There is no automatic spacing of text lines as with tkinter.Text.  A 
comment in the draw method notes "XXX This hard-codes too many geometry 
constants!".

The attached patch changes two of the constants.  Increasing dy spreads the 
line apart a bit so there is very little clipping. (Both g and y are sometimes 
complete, sometimes not.) The other change moves the lines up relative to the 
icons so they are not offset.

Saimadhav, does this change look ok on linux?

I think the long term fix (before 3.5) is to use ttk.Treeview.  So I am not 
inclined to spend lots of time fine-tuning on various systems or adding user 
configuration (though we might for Treeview).  However, dy could be made 
conditional on, for instance, sys.platform[0:3] == 'win'.

--
assignee: terry.reedy
files: atree.diff
keywords: patch
messages: 229277
nosy: sahutd, terry.reedy
priority: normal
severity: normal
stage: patch review
status: open
title: Idle: Tree lines are spaced too close together.
type: behavior
versions: Python 2.7, Python 3.4, Python 3.5
Added file: http://bugs.python.org/file36905/atree.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com