[issue22943] bsddb: test_queue fails on Windows

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22943] bsddb: test_queue fails on Windows

[Roundup Robot]

Roundup Robot added the comment:

New changeset df17d2b0878f by Serhiy Storchaka in branch '2.7':
Issue #22943: bsddb tests are locale independend now.
https://hg.python.org/cpython/rev/df17d2b0878f

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22943] bsddb: test_queue fails on Windows

[Benjamin Peterson]

Benjamin Peterson added the comment:

Yes, please apply.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22943] bsddb: test_queue fails on Windows

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Does it look good to you Benjamin?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22943] bsddb: test_queue fails on Windows

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This test is locale-depending. string.letters is the collection of 8-bit 
characters for which islower() or isupper() is true. On most Unixes the locale 
is either UTF-8 or ASCII and string.letters contains only ASCII letters. On 
most Windows it contains characters from extended ASCII, and the length of 
string.letters can be larger than 75 (minimal non-replacement index used in 
tests).

There is two simple way to fix this issue.
1) increase test indices to be larger than 255.
2) use string.ascii_letters instead of string.letters.

Here is the patch which uses the second approach (because string.letters is 
used in other tests).

--
keywords: +patch
nosy: +serhiy.storchaka
stage: needs patch -> patch review
Added file: http://bugs.python.org/file37282/bsddbtests_ascii_letters.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22943] bsddb: test_queue fails on Windows

[Roundup Robot]

Roundup Robot added the comment:

New changeset e5ed983bc784 by Benjamin Peterson in branch '2.7':
disable tests that always fail on windows (#22943)
https://hg.python.org/cpython/rev/e5ed983bc784

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22943] bsddb: test_queue fails on Windows

[Benjamin Peterson]

New submission from Benjamin Peterson:

One gets this on the Windows bots:

==
FAIL: test01_basic (bsddb.test.test_queue.SimpleQueueTestCase)
--
Traceback (most recent call last):
  File 
"D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\bsddb\test\test_queue.py",
 line 49, in test01_basic
self.assertEqual(len(d), len(string.letters)+3)
AssertionError: 125 != 128

==
FAIL: test02_basicPost32 (bsddb.test.test_queue.SimpleQueueTestCase)
--
Traceback (most recent call last):
  File 
"D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\bsddb\test\test_queue.py",
 line 120, in test02_basicPost32
self.assertEqual(len(d), len(string.letters)+3)
AssertionError: 125 != 128

--

(See 
http://buildbot.python.org/all/builders/x86%20Windows7%202.7/builds/2925/steps/test/logs/stdio)

This has been going on for a long time. I doubt anyone cares. I'm just going to 
disable the test.

--
components: Extension Modules
messages: 231687
nosy: benjamin.peterson
priority: normal
severity: normal
stage: needs patch
status: open
title: bsddb: test_queue fails on Windows
type: behavior
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com