[issue23062] test_argparse --version test cases
Serhiy Storchaka added the comment: I should agree with you. Then the patch LGTM. -- assignee: - berker.peksag stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23062 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23062] test_argparse --version test cases
Martin Panter added the comment: Serhiy, there is already a test for that: class TestHelpVersionAction(HelpTestCase): Test the default help for the version action So I still think the test is redundant, unless it is made to exercise help=SUPPRESS, as Berker’s patch does. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23062 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23062] test_argparse --version test cases
Serhiy Storchaka added the comment: Why the test class is moved? -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23062 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23062] test_argparse --version test cases
Berker Peksag added the comment: Why the test class is moved? Just wanted to group all TestHelp* tests together. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23062 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23062] test_argparse --version test cases
Serhiy Storchaka added the comment: But it already was between two help tests: TestHelpNoHelpOptional and TestHelpNone. I think that original test tested that the help attribute is optional for the --version argument and default description is printed in help output. This test shouldn't be removed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23062 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23062] test_argparse --version test cases
Martin Panter added the comment: Patch looks sensible enough to me -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23062 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23062] test_argparse --version test cases
New submission from Martin Panter: In Lib/test/test_argparse.py: class TestHelpVersionOptional(HelpTestCase): Test that the --version argument can be suppressed help messages Assuming that the docstring means something like “. . . can be suppressed _in_ help messages”, the test is wrong, because the --version option is present in the expected output. Maybe it is missing a help=SUPPRESS option? Otherwise it seems this test class would be largely redundant with TestHelpVersionAction. It also looks like the “version” attribute of the test classes is not used. -- components: Tests messages: 232712 nosy: vadmium priority: normal severity: normal status: open title: test_argparse --version test cases versions: Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23062 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23062] test_argparse --version test cases
Berker Peksag added the comment: I think that your analysis is correct. Also, looks like the original test is problematic: https://code.google.com/p/argparse/source/browse/test/test_argparse.py#3710 Here is a patch to fix the test. -- keywords: +patch nosy: +berker.peksag, bethard, paul.j3 stage: - patch review type: - behavior versions: +Python 3.4 Added file: http://bugs.python.org/file37460/issue23062.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23062 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
