[issue2356] fixer for sys.exitfunc -> atexit

[Sean Reifschneider]

Sean Reifschneider  added the comment:

I've posted to python-dev asking for a reviewer for this, the thread is at 
http://mail.python.org/pipermail/python-dev/2010-March/098597.html

--
nosy: +jafo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2356] fixer for sys.exitfunc -> atexit

[Benjamin Peterson]

Benjamin Peterson  added the comment:

Sean, are you referring to the warning or the 2to3 fixer?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2356] fixer for sys.exitfunc -> atexit

[Benjamin Peterson]

Changes by Benjamin Peterson :


--
assignee: collinwinter -> benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2356] fixer for sys.exitfunc -> atexit

[Benjamin Peterson]

Benjamin Peterson  added the comment:

Committed the 2to3 fixer in r79137.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2356] fixer for sys.exitfunc -> atexit

[Alexandre Vassalotti]

Alexandre Vassalotti  added the comment:

Here is an attempt to add a Py3K warning when sys.exitfunc is modified.

--
nosy: +alexandre.vassalotti
Added file: http://bugs.python.org/file14453/sys_exitfunc_warning.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2356] fixer for sys.exitfunc -> atexit

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

Here's my 2to3 fixer for the cause. It always changes assignment to
sys.exitfunc to atexit.register. It then inserts a "import atexit" after
the module's sys import. If it can't find a sys import (that should be
rare obviously :) ), it emits a warning.

--
assignee:  -> collinwinter
components: +2to3 (2.x to 3.0 conversion tool) -Interpreter Core
keywords: +needs review, patch -26backport
nosy: +collinwinter
title: sys.exitfunc should raise a Py3K warning -> fixer for sys.exitfunc -> 
atexit
type:  -> feature request
Added file: http://bugs.python.org/file11252/atexit_fixer.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2356] fixer for sys.exitfunc -> atexit

[Armin Ronacher]

Armin Ronacher <[EMAIL PROTECTED]> added the comment:

Since yesterday there is a handy little helper that adds imports to
files which is already used for the reduce() / intern() fixers.  This
makes this fix a lot easier.

I attached a version that does that.

However the import adder is not yet as sophisticated as the one in the
previous patch, but the utility method could be improved to better adapt
to existing styleguides.

--
nosy: +aronacher
Added file: http://bugs.python.org/file12279/fix_exitfunc.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com