[issue23652] ifdef uses of EPOLLxxx macros so we can compile on systems that don't have them
Roundup Robot added the comment: New changeset e38470b49d3c by Zachary Ware in branch '2.7': Issue #23652: Make the select module compile against LSB headers. https://hg.python.org/cpython/rev/e38470b49d3c New changeset c18a18b65a49 by Zachary Ware in branch '3.4': Issue #23652: Make the select module compile against LSB headers. https://hg.python.org/cpython/rev/c18a18b65a49 New changeset a99f17c752d8 by Zachary Ware in branch '3.5': Issue #23652: Merge with 3.4 https://hg.python.org/cpython/rev/a99f17c752d8 New changeset c7273b46980c by Zachary Ware in branch 'default': Closes #23652: Merge with 3.5 https://hg.python.org/cpython/rev/c7273b46980c -- nosy: +python-dev resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23652 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23652] ifdef uses of EPOLLxxx macros so we can compile on systems that don't have them
Zachary Ware added the comment: Thanks for the patch! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23652 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23652] ifdef uses of EPOLLxxx macros so we can compile on systems that don't have them
Zachary Ware added the comment: Looks good to me. -- nosy: +zach.ware stage: - commit review versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23652 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23652] ifdef uses of EPOLLxxx macros so we can compile on systems that don't have them
New submission from Matt Frank: With the LSB (Linux Standard Base) headers for libc Modules/selectmodule.c fails to compile because we have code that uses EPOLLRDNORM, EPOLLRDBAND, EPOLLWRNORM and EPOLLMSG without first checking that they are defined. The patch wraps the five uses of PyModule_AddIntMacro in #ifdefs, following exactly the same pattern that is used for the POLLRDNORM, POLLRDBAND, POLLWRNORM, POLLMSG macros 30 lines earlier in selectmodule.c. The only documentation I can find for these five macros from Linux is (a) in the Python documentation for the select module! (https://docs.python.org/3.4/library/select.html#edge-and-level-trigger-polling-epoll-objects) and (b) on this StackOverflow answer: http://stackoverflow.com/a/27143672/2209313. They are not described on http://man7.org/linux/man-pages/man2/epoll_ctl.2.html (where the rest of the EPOLL macros are defined), nor at http://linux.die.net/man/4/epoll. As explained by the StackOverflow answer they actually are described (indirectly) by http://man7.org/linux/man-pages/man2/poll.2.html. Nor are these macros in the Linux Foundation's LSB database: http://www.linuxbase.org/navigator/browse/headgroup.php?cmd=list-byheadgroupHGid=1398. Obviously almost all modern Linuxes have these macros, so we should keep them, but we should also compile with the LSB headers (since compiling and linking against the LSB SDK (http://www.linuxfoundation.org/collaborate/workgroups/lsb/group) is one of the easiest ways to produce a Python binary that will actually run on most important supported Linux distros (e.g., RHEL 5). http://man7.org/linux/man-pages/man7/epoll.7.html, -- components: Build files: epoll-macros-patch.diff keywords: patch messages: 237984 nosy: WanderingLogic priority: normal severity: normal status: open title: ifdef uses of EPOLLxxx macros so we can compile on systems that don't have them versions: Python 2.7, Python 3.5, Python 3.6 Added file: http://bugs.python.org/file38461/epoll-macros-patch.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23652 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23652] ifdef uses of EPOLLxxx macros so we can compile on systems that don't have them
Changes by Matt Frank matthew.i.fr...@intel.com: -- type: - compile error ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23652 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23652] ifdef uses of EPOLLxxx macros so we can compile on systems that don't have them
Changes by Ned Deily n...@acm.org: -- nosy: +neologix ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23652 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
