[issue23667] IDLE to provide option for making trailing whitespace visible

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Given the issues I raised and Raymond's rejection of this, his first suggested 
option, on the PR, in favor of his second suggested option, #33046, I agree, at 
least for now.

The use case for whitespace tagging would be if someone wants to selectively 
delete trailing whitespace.  However, python/cpython rejects any trailing 
whitespace for all of .py, .c, and .rst files.  So this must be exceedingly 
rare and is not something that IDLE must facilitate.

--
resolution:  -> rejected
stage: needs patch -> resolved
status: open -> closed
superseder:  -> IDLE option to strip trailing whitespace automatically on save

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Tal Einat]

Tal Einat  added the comment:

See also issue33046 specifically suggesting auto-removal of trailing whitespace 
on saving a file, as per Raymond's second suggestion here. It has a PR which 
seems about ready to go.

I see that as the simplest approach to this issue, both in terms of 
implementation and in terms of UI/UX.

Could we mark that issue as superseding this one?

--
nosy: +taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Raymond, which definition of 'whitespace' do you intent?

Git gui also marks trailing spaces in frozen diffs.  This is much harder to do 
while editing as text can be read, keyed, and pasted.  Most spaces and blank 
lines are only temporarily trailing, before something more is added.  I believe 
I would dislike the idea of temporarily marking them, unless it were very 
subtle.  They really only need to be stripped just before saving.  So I think 
we should make that easy and not too intrusive. 

1. Ask if there is trailing whitespace.  For instance,
if (text.find('\s\n') != -1) or :


2. Add a setting to strip on save, default yes.

3. always strip trailing whitespace from .py files when saving.
Perhaps flash 'trailing whitespace stripped' to status bar.

The danger with any of these is stripping of wanted trailing whitespace in 
tripple-quoted string literals.  Such whitespace is rare, but I don't know how 
rare.

Alternate ways of making such are better in making the blanks permanently 
visible in any display, not just in IDLE.  The problem is teaching this.

>>> s = (
  'This is justified text\n'
  'with blank spaces.\n'
  'It is is followed by  \n'
  'a trailing blank line.\n'
  '\n')
>>> s
'This is justified text\nwith blank spaces.\nIt is is followed by  \na 
trailing blank line.\n\n'

while an error marking would tell users to do it manually.
---

I closed PR 1644 because implementing features as extensions is obsolete and 
because the trim function duplicates the existing function (once it is fixed to 
include blank lines).

I am dubious about PR 1643.  Tagging trailing whitespace as an error would 
suggest that the user should delete it.  With strip on save, this would be 
noise.

--
stage: patch review -> needs patch
versions: +Python 3.8 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Cheryl Sabella]

Cheryl Sabella added the comment:

Thanks, Terry!  I'll take a look at 30290.  No need to start with colorizer; it 
was in this ticket so I referenced it more for convenience than anything.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Terry J. Reedy]

Terry J. Reedy added the comment:

Louie: It appears that old PRs might merge as they are but any change, 
including an update merge, requires that you close and re-open.  When you 
re-open, please add "was pr".  It would be easier for me if you redid all 
the IDLE PRs in a batch or two.

Cheryl: Yes. Idlelib callables need docstrings, especially because they are not 
otherwise documented.  Based on our work on bdb, I was hoping you would work on 
IDLE.  I added you to #30290

Some of the colorizer functions are hard to usefully characterize.  This is 
parly because everything is done by side-effect and most functions have 
multiple side-effects.  There is a connection between the lack of docstrings 
and the vestigial nature of test_colorizer.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Cheryl Sabella]

Cheryl Sabella added the comment:

Terry,

Should IDLE library modules get docstrings or is that something you'd rather 
not have?  Putting the question here because ColorDelegator in colorizer.py 
doesn't have any docstrings.  I wanted to read some of the IDLE code and I can 
try to add missing docstrings if it's something that should be done.

Thanks!

--
nosy: +csabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Louie Lu]

Louie Lu added the comment:

terry, these close isn't changing anything. But I'm migrating my GitHub account 
from old one to new one, thus will close the PR and reopen another one, sorry 
for annoying mailing.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Terry J. Reedy]

Terry J. Reedy added the comment:

Louie, when you close and open PRs, please give at least a brief explanation.  
In particular, how is the new one different?

--
assignee:  -> terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Louie Lu]

Changes by Louie Lu :


--
pull_requests: +1739

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Louie Lu]

Changes by Louie Lu :


--
pull_requests: +1738

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Louie Lu]

Changes by Louie Lu :


--
pull_requests: +1737

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
stage: needs patch -> patch review
versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Louie Lu]

Louie Lu added the comment:

PR 1602 add trailing whitespace highlight, which using color from error.

PR 1603 add TrimExtension to provide auto trim while saving the file.

--
nosy: +louielu

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Louie Lu]

Changes by Louie Lu :


--
pull_requests: +1694

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Louie Lu]

Changes by Louie Lu :


--
pull_requests: +1693

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Terry J. Reedy]

Terry J. Reedy added the comment:

I agree that this area needs improvement.  'Strip trailing whitespace' should 
strip trailing blank lines at the end of a file, as well as trailing blank 
spaces at the end of each line.  Both are required to commit to our repository.

I would like to have a configuration option to always strip trailing blanks, at 
least for .py files.

I believe the cursor moving from one line to another is an event that is or 
could be caugth and acted on. If so, trailing spaces could be removed 
immediately from the line left, and Save would only have to check the current 
line and the end of the file.  I would rather remove blanks than mark them for 
later removal.

--
nosy: +terry.reedy
stage:  - needs patch
versions: +Python 2.7, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23667
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23667] IDLE to provide option for making trailing whitespace visible

[Raymond Hettinger]

New submission from Raymond Hettinger:

We have an option to clear trailing whitespace (Format / Strip trailing 
whitespace) but it isn't always clear when to use it (because the trailing 
whitespace is invisible).

One thing the can be done is to colorize trailing white space to make it more 
visible (this idea is inspired by a similar feature in mercurial's colorized 
diffs).

Another option is put a hook on File / Save to scan for trailing whitespace and 
offer to remove it (this idea is inspired by the whitespace commit hook used in 
Python's own source code management).

--
components: IDLE
messages: 238110
nosy: rhettinger
priority: normal
severity: normal
status: open
title: IDLE to provide option for making trailing whitespace visible
type: enhancement
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23667
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com