[issue23830] Add AF_IUCV support to sockets
Neale Ferguson added the comment: Updated patch against head (96580:3156dd82df2d). Built on s390x and x86_64. Test suite ran on both - tests successfully ignored on x86_64 and passed on s390x. -- versions: +Python 3.6 -Python 3.5 Added file: http://bugs.python.org/file39683/af_iucv_cpython.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23830] Add AF_IUCV support to sockets
Neale Ferguson added the comment: Attaching a patch based off 3.5.0a3. Note, for Py_ssize_t I had to add: #ifdef PY_SSIZE_T_CLEAN Py_ssize_t lNode, lUser, lName; #else int lNode, lUser, lName; #endif As if I did not, the values I got back were garbage. Is this because of some configuration parameter I failed to use? However, the patch builds on s390x and x86_64 and the test passes on the former and is skipped on the latter. -- Added file: http://bugs.python.org/file38850/af_iucv.patch35 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23830] Add AF_IUCV support to sockets
Neale Ferguson added the comment: Removed two debug statements -- Added file: http://bugs.python.org/file38852/af_iucv.patch35 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23830] Add AF_IUCV support to sockets
Neale Ferguson added the comment: Corrected declaration of args to PyArg_ParseTuple() from int to Py_ssize_t. -- Added file: http://bugs.python.org/file38845/af_iucv.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23830] Add AF_IUCV support to sockets
Armin Rigo added the comment: The PyArg_ParseTuple() size arguments should be of type Py_ssize_t instead of int. -- nosy: +arigo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23830] Add AF_IUCV support to sockets
Neale Ferguson added the comment: I can provide one if required. I have access to an s390x Linux Foundation machine where I have a couple of virtual machines that could be used. Original message From: Nick Coghlan rep...@bugs.python.org Date:2015/04/02 06:35 (GMT-05:00) To: Neale Ferguson ne...@sinenomine.net Subject: [issue23830] Add AF_IUCV support to sockets Nick Coghlan added the comment: Slavek, there's an s390x patch here to add AF_IUCV support to the socket module. One interesting point to note is that s390x isn't an officially supported CPython architecture by the terms of PEP 11. While I can vouch for it working there (courtesy of beaker-project.org), I don't see any reasonable way we could provide an upstream buildbot for it. -- nosy: +bkabrda, ncoghlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23830] Add AF_IUCV support to sockets
Nick Coghlan added the comment: Slavek, there's an s390x patch here to add AF_IUCV support to the socket module. One interesting point to note is that s390x isn't an officially supported CPython architecture by the terms of PEP 11. While I can vouch for it working there (courtesy of beaker-project.org), I don't see any reasonable way we could provide an upstream buildbot for it. -- nosy: +bkabrda, ncoghlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23830] Add AF_IUCV support to sockets
Neale Ferguson added the comment: Thanks. Question/responses in-line On 4/1/15, 11:14 AM, Amaury Forgeot d'Arc rep...@bugs.python.org wrote: Amaury Forgeot d'Arc added the comment: Hi, First, please fill and submit a Contribution Agreement: https://www.python.org/psf/contrib/ Done but I never got the email confirmation - it was not in my spam fold either. Then about the patch: - This is a patch against Python2.7, which is frozen for new developments. This change will only be applied to python 3.5 or later. Understood. - There are some tab characters in the diff Will fix - Names are limited to 8 characters, but there is no check. I truncate, but I will add a check to be more programmer friendly - Names must be padded with spaces. This is done automatically in connect(), but these extra spaces should be removed in makesockaddr() so that the same names are returned. Will do, I was going to let the caller strip() but I will do it here instead. Is there an existing strip routine that I could call rather than writing my own (trivial) stripper? Do I resubmit the patch in the bug/enhancement report I had created? Neale -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23830] Add AF_IUCV support to sockets
Amaury Forgeot d'Arc added the comment: Hi, First, please fill and submit a Contribution Agreement: https://www.python.org/psf/contrib/ Then about the patch: - This is a patch against Python2.7, which is frozen for new developments. This change will only be applied to python 3.5 or later. - There are some tab characters in the diff - Names are limited to 8 characters, but there is no check. - Names must be padded with spaces. This is done automatically in connect(), but these extra spaces should be removed in makesockaddr() so that the same names are returned. -- nosy: +amaury.forgeotdarc ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23830] Add AF_IUCV support to sockets
Terry J. Reedy added the comment: The CA ack is a * added after your name here. May take a week. If you are asking whether to submit a new patch against 3.5, with suggested fixes, yes, please do . -- nosy: +terry.reedy stage: - patch review versions: +Python 3.5 -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23830] Add AF_IUCV support to sockets
Neale Ferguson added the comment: Updated patch - Removes tabs - Strips name/user/node returned by connect - Checks lengths of name/user/node -- Added file: http://bugs.python.org/file38788/af_iucv.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23830] Add AF_IUCV support to sockets
Neale Ferguson added the comment: Corrected a length error in the strip routine Initialized the end of string indicator -- Added file: http://bugs.python.org/file38789/af_iucv.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23830] Add AF_IUCV support to sockets
New submission from Neale Ferguson: IUCV is a hypervisor mediated communications method for z/VM guest virtual machines. Linux on z Systems (aka s390x) has supported this via the use of AF_IUCV sockets for many years (added to kernel Feb 2007). This suggested patch adds support to Python 2.7.9 for this socket type. I have built Python on both s390x and x86_64: both build cleanly and the test added to test_socket.py runs cleanly on s390x and is skipped on other platforms. -- components: Library (Lib) files: af_iucv.patch keywords: patch messages: 239743 nosy: neale priority: normal severity: normal status: open title: Add AF_IUCV support to sockets type: enhancement versions: Python 2.7 Added file: http://bugs.python.org/file38765/af_iucv.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23830 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
