[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[STINNER Victor]

STINNER Victor  added the comment:

Nice optimization! I wanted to implement it, but then I forgot.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

See issue35582 for next step.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 32d96a2b5bc3136d45a66adbdb45fac351b520ce by Serhiy Storchaka in 
branch 'master':
bpo-23867: Argument Clinic: inline parsing code for a single positional 
parameter. (GH-9689)
https://github.com/python/cpython/commit/32d96a2b5bc3136d45a66adbdb45fac351b520ce


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[Ammar Askar]

Change by Ammar Askar :


--
nosy: +ammar2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[STINNER Victor]

STINNER Victor  added the comment:

I'm a little bit sad that the PR doesn't add new tests :-(

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Thank you all for your comments. Addressed all comments, fixed few other bugs, 
added support for more convertors. I think this patch is completed.

This is just a first step. Next steps are adding support of multiple 
positional-only parameters, optional groups, and finally keyword parameters.

--
versions: +Python 3.8 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +9076
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[STINNER Victor]

STINNER Victor added the comment:

I like the idea since I just proposed something similar in the issue #29419, 
but it seems like your change removes the function name from error messages 
which can become much more obscure.

Maybe we should wrap all exceptions into a new TypeError which contains at 
least the function name, or even the parameter name/position. I mean chained 
exception to keep the original exception which contains more information.

The best would be to have all information in a single error message, but it is 
likely to be much more complex to implement, especially if you want to support 
arbitrary converter function, not only simple formats like  i". So I think that 
two chained exceptions is a reasonable compromise. What do you think?

If we succeed to get the function name and the parameter name or position, the 
error messages will be MUCH MORE better than currently! And Argument Clinic 
allows us to implement this feature.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Because new generated code contains "if" statements and braces (and PEP 7 
requires even more braces than current patch adds). The patch for issue26305 
allows to repeat braces only twice instead of 4 times.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[Larry Hastings]

Larry Hastings added the comment:

Why is this dependent on #26305?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
dependencies: +Argument Clinic incorrectly work with custom converter and 
renamed parameter, Make Argument Clinic to generate PEP 7 conforming code

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Synchronized with tip.

--
versions: +Python 3.6 -Python 3.5
Added file: http://bugs.python.org/file42672/clinic_meth_o_inline.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23867] Argument Clinic: inline parsing code for 1-argument functions

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Proposed patch makes Argument Clinic to inline parsing code for most popular 
formats in functions with single positional argument. This makes parsing faster.

--
components: Argument Clinic
files: clinic_meth_o_inline.patch
keywords: patch
messages: 240074
nosy: larry, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Argument Clinic: inline parsing code for 1-argument functions
type: enhancement
versions: Python 3.5
Added file: http://bugs.python.org/file38830/clinic_meth_o_inline.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com