[issue23922] turtle.py and turtledemo use the default tkinter icon

[Terry J. Reedy]

Terry J. Reedy added the comment:

PyShell is now pyshell.  I think factoring the icon setting into a separate 
function is a good idea, separate from turtle and turtledemo.  I am leaving 
this issue open for that, for 3.6/7.

I don't think the turtle/turtledemo icons matter that much.  I will not patch 
them.

--
stage:  -> test needed
type:  -> enhancement
versions: +Python 3.6, Python 3.7 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23922] turtle.py and turtledemo use the default tkinter icon

[Ned Deily]

Ned Deily added the comment:

Creating a new import dependency to idlelib.PyShell in turtle.py doesn't seem 
like a good idea since turtle.py does not currently need to be used with IDLE 
(unlike turtledemo which does have an existing dependency on idlelib).  Perhaps 
a better way would be to add an option to turtle.cfg to allow users to specify 
an icon file and have turtledemo set it to the IDLE one if used from IDLE?

--
nosy: +terry.reedy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23922
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23922] turtle.py and turtledemo use the default tkinter icon

[Terry J. Reedy]

Terry J. Reedy added the comment:

The blue feather is the tk 8.6 icon.  The tk 8.5 and before icon is a red 
script 'Tk'.

The title bar icons for Idle were added in #20406.  It was a bit of a challenge 
to get them to work right and look good enough for all versions on all systems. 
 The icons were taken from the repository PC directory, which does not get 
installed.  I forget whether the ones committed were direct copies or modified. 
 I know I had in mind some future editing.  See msg209747

I agree with the general idea.  However, PEP 434 defines the idlelib api as 
mostly private.  Indeed, I might like to someday rename and refactor 
PyShell.py.  Rather than add an idlelib dependency (in particular PyShell.py) 
to turtle, I would prefer to move generic tkinter code to the tkinter tree.  (I 
might even like to remove the idlelib dependency from turtledemo this way, but 
this is a future issue.)

In this case, the tkinter addition would be a new method on the application 
window or toplevel class: def set_icon(self, icon_dir, icon_file): code pretty 
much as already written.  Icon_file is the base name which gets .ico, .gif, or 
.png added.  This non-obvious code would then be available to all.  Serhiy, 
what do you think of this?

However, I have no reason to rename the icon files, so turtle could reuse 
those.  But a better application icon for turtle and turtledemo might be new 
icons with the two snakes on the back of a turtle shell.

--
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23922
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23922] turtle.py and turtledemo use the default tkinter icon

[Al Sweigart]

New submission from Al Sweigart:

The turtle.py and turtledemo scripts launch windows that have the default 
tkinter icon. Instead, they should make use of the IDLE icon (which are already 
in the idlelib/Icons folder)

--
components: IDLE
messages: 240564
nosy: Al.Sweigart
priority: normal
severity: normal
status: open
title: turtle.py and turtledemo use the default tkinter icon
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23922
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23922] turtle.py and turtledemo use the default tkinter icon

[Ned Deily]

Ned Deily added the comment:

Or perhaps a generic Python ioon.  Is there a tkinter icon?  I think the 
default is just the Tk-supplied icon.  Also, there are platform differences.  
AFAIK, on OS X the application icon cannot be changed while running; 
information about icon files is specified in the app bundle Info.plist.  For OS 
X framework builds, launching IDLE.app (for example, via double-click) results 
in an IDLE icon.  Opening turtledemo (or, for that matter, idle from the 
command line) causes the default Python icon to be used, from the Python.app 
bundle located within the framework.  Running tkinter apps with non-framework 
builds default to the Tk icon if no app bundle is used.  So, I think there is 
nothing to be done here for OS X but one needs to be aware of the platform 
differences when testing.

--
nosy: +ned.deily

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23922
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23922] turtle.py and turtledemo use the default tkinter icon

[Al Sweigart]

Al Sweigart added the comment:

On my system (Windows 7) it shows up with a blue feather icon, which I is the 
generic Tk icon.

The reason I suggest the IDLE icon is 1) we already have it and 2) it's the 
python logo on top of a generic sheet of paper icon so it fits well enough imo, 
and 3) I'm assuming that the use of the turtle demo and IDLE are pretty 
intertwined anyway.

I've attached a patch which I've tested on Windows, but I'm away from my other 
machines right now.

--
Added file: http://bugs.python.org/file38907/patch_issue_23922

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23922
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com