[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

PR 25182 fixes the issue, so I am closing this again.

Thanks for the quick fix, Irit!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset aadd4e10fda87b64ea527667238503da326a06e7 by Irit Katriel in 
branch 'master':
bpo-24160: Fix test_pdb refleaks failure (GH-25182)
https://github.com/python/cpython/commit/aadd4e10fda87b64ea527667238503da326a06e7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

[Irit Katriel]

Irit Katriel  added the comment:

With the patch:

PS C:\Users\User\src\cpython-dev> ./python -m test test_pdb -R 3:3
Running Debug|x64 interpreter...
0:00:00 Run tests sequentially
0:00:00 [1/1] test_pdb
beginning 6 repetitions
123456
..

== Tests result: SUCCESS ==

1 test OK.

Total duration: 34.2 sec
Tests result: SUCCESS

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +23924
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/25182

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

[Irit Katriel]

Irit Katriel  added the comment:

Thanks, I'm looking.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Per our buildbot policy 
(https://discuss.python.org/t/policy-to-revert-commits-on-buildbot-failure/404) 
we will need to revert this in 24 hours if is not fixed to avoid masking future 
errors.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Unfortunately PR21989 has breaking the refleaks buildbots. Example:

https://buildbot.python.org/all/#/builders/320/builds/226/steps/5/logs/stdio

To reproduce:

❯ ./python -m test test_pdb -R 3:3
0:00:00 load avg: 1.40 Run tests sequentially
0:00:00 load avg: 1.40 [1/1] test_pdb
beginning 6 repetitions
123456
.test test_pdb failed -- Traceback (most recent call last):
  File "/home/pablogsal/github/cpython/Lib/doctest.py", line 2205, in runTest
raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for 
test.test_pdb.test_pdb_breakpoints_preserved_across_interactive_sessions
  File "/home/pablogsal/github/cpython/Lib/test/test_pdb.py", line 326, in 
test_pdb_breakpoints_preserved_across_interactive_sessions

--
File "/home/pablogsal/github/cpython/Lib/test/test_pdb.py", line 330, in 
test.test_pdb.test_pdb_breakpoints_preserved_across_interactive_sessions
Failed example:
with PdbTestInput([  # doctest: +ELLIPSIS, +NORMALIZE_WHITESPACE
   'import test.test_pdb',
   'break test.test_pdb.do_something',
   'break test.test_pdb.do_nothing',
   'break',
   'continue',
]):
   pdb.run('print()')
Expected:
> (1)()
(Pdb) import test.test_pdb
(Pdb) break test.test_pdb.do_something
Breakpoint 1 at ...test_pdb.py:...
(Pdb) break test.test_pdb.do_nothing
Breakpoint 2 at ...test_pdb.py:...
(Pdb) break
Num Type Disp Enb   Where
1   breakpoint   keep yes   at ...test_pdb.py:...
2   breakpoint   keep yes   at ...test_pdb.py:...
(Pdb) continue
Got:
> (1)()->None
(Pdb) import test.test_pdb
(Pdb) break test.test_pdb.do_something
Breakpoint 1 at /home/pablogsal/github/cpython/Lib/test/test_pdb.py:396
(Pdb) break test.test_pdb.do_nothing
Breakpoint 2 at /home/pablogsal/github/cpython/Lib/test/test_pdb.py:393
(Pdb) break
Num Type Disp Enb   Where
1   breakpoint   keep yes   at 
/home/pablogsal/github/cpython/Lib/test/test_pdb.py:396
2   breakpoint   keep yes   at 
/home/pablogsal/github/cpython/Lib/test/test_pdb.py:393
(Pdb) continue

--
File "/home/pablogsal/github/cpython/Lib/test/test_pdb.py", line 350, in 
test.test_pdb.test_pdb_breakpoints_preserved_across_interactive_sessions
Failed example:
with PdbTestInput([  # doctest: +ELLIPSIS, +NORMALIZE_WHITESPACE
   'break',
   'break pdb.find_function',
   'break',
   'clear 1',
   'continue',
]):
   pdb.run('print()')
Expected:
> (1)()
(Pdb) break
Num Type Disp Enb   Where
2   breakpoint   keep yes   at ...test_pdb.py:...
3   breakpoint   keep yes   at ...pdb.py:...
(Pdb) clear 2
Deleted breakpoint 2 at ...test_pdb.py:...
(Pdb) clear 3
Deleted breakpoint 3 at ...pdb.py:...
(Pdb) continue
Got:
> (1)()->None
(Pdb) break
Num Type Disp Enb   Where
2   breakpoint   keep yes   at 
/home/pablogsal/github/cpython/Lib/test/test_pdb.py:393
3   breakpoint   keep yes   at /home/pablogsal/github/cpython/Lib/pdb.py:94
(Pdb) clear 2
Deleted breakpoint 2 at 
/home/pablogsal/github/cpython/Lib/test/test_pdb.py:393
(Pdb) clear 3
Deleted breakpoint 3 at /home/pablogsal/github/cpython/Lib/pdb.py:94
(Pdb) continue



test_pdb failed

== Tests result: FAILURE ==

1 test failed:
test_pdb

Total duration: 2.8 sec
Tests result: FAILURE

--
nosy: +pablogsal
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

[Irit Katriel]

Irit Katriel  added the comment:

Thanks!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset ad442a674ca443feec43a88a2d3671784712e550 by Irit Katriel in 
branch 'master':
bpo-24160: Fix breakpoints persistence across multiple pdb sessions (GH-21989)
https://github.com/python/cpython/commit/ad442a674ca443feec43a88a2d3671784712e550


--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

[Tal Einat]

Tal Einat  added the comment:

Irit, I like the approach of your PR for an immediate fix, that we could 
consider backporting.

In the long term, ISTM that we should refactor to store the breakpoints with 
only a single source of truth, and avoid the duplication between 
Breakpoint.bplist, Breakpoint.bpbynumber and Bdb.breaks.

--
nosy: +taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

[Georg Brandl]

Change by Georg Brandl :


--
nosy:  -georg.brandl

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

[Irit Katriel]

Change by Irit Katriel :


--
title: Pdb sometimes crashes when trying to remove a breakpoint defined in a 
different debugger sessoon -> Pdb sometimes raises exception when trying to 
remove a breakpoint defined in a different debugger session
versions: +Python 3.10 -Python 2.7, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com