[issue24274] erroneous comments in dictobject.c

2017-02-20 Thread INADA Naoki 

Changes by INADA Naoki :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24274] erroneous comments in dictobject.c

2017-02-20 Thread INADA Naoki 

INADA Naoki added the comment:


New changeset ce552e2d5c4ff90218fb41847e8ffb1fd3ba3b2d by GitHub in branch 
'3.6':
bpo-24274: fix erroneous comment in dictobject.c (GH-200)
https://github.com/python/cpython/commit/ce552e2d5c4ff90218fb41847e8ffb1fd3ba3b2d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24274] erroneous comments in dictobject.c

2017-02-20 Thread INADA Naoki 

Changes by INADA Naoki :


--
pull_requests: +167

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24274] erroneous comments in dictobject.c

2017-02-20 Thread INADA Naoki 

INADA Naoki added the comment:


New changeset 1b8df107f867fb05ff39ebee7c55f0a907e7ad5f by GitHub in branch 
'master':
bpo-24274: fix erroneous comment in dictobject.c (GH-196)
https://github.com/python/cpython/commit/1b8df107f867fb05ff39ebee7c55f0a907e7ad5f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24274] erroneous comments in dictobject.c

2017-02-20 Thread INADA Naoki 

Changes by INADA Naoki :


--
pull_requests: +163

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24274] erroneous comments in dictobject.c

2017-02-20 Thread INADA Naoki 

INADA Naoki added the comment:


New changeset 66fa9d4205e0da672ed19a397069281a4b177af4 by GitHub in branch 
'3.5':
bpo-24274: fix comment in dictobject.c (GH-194)
https://github.com/python/cpython/commit/66fa9d4205e0da672ed19a397069281a4b177af4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24274] erroneous comments in dictobject.c

2017-02-20 Thread INADA Naoki 

INADA Naoki added the comment:

https://github.com/python/cpython/pull/194#issuecomment-281054701

Xiang Zhang found Python 3.6+ have similar issue.

--
versions: +Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24274] erroneous comments in dictobject.c

2017-02-20 Thread INADA Naoki 

Changes by INADA Naoki :


--
pull_requests: +161

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24274] erroneous comments in dictobject.c

2016-10-01 Thread INADA Naoki 

Changes by INADA Naoki :


--
assignee:  -> inada.naoki
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24274] erroneous comments in dictobject.c

2016-09-29 Thread INADA Naoki 

Changes by INADA Naoki :


--
keywords: +patch
Added file: http://bugs.python.org/file44875/lookdict_unicode_comment.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24274] erroneous comments in dictobject.c

2016-09-28 Thread Berker Peksag 

Berker Peksag added the comment:

Comments have been updated by the new dict implementation in 3.6+, but the 3.5 
branch still needs to be updated.

--
nosy: +berker.peksag, inada.naoki
stage:  -> needs patch
type: enhancement -> behavior
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24274] erroneous comments in dictobject.c

2015-05-23 Thread Jim Jewett 

New submission from Jim Jewett:

https://hg.python.org/cpython/file/2df7c958974e/Objects/dictobject.c#l451

The comments near lookdict suggest that specialized versions such as 
lookdict_unicode and lookdict_unicode_nodummy cannot return NULL, as that would 
indicate an Exception was raised during comparison.

They can return NULL, because if the *search* key is not unicode, they replace 
themselves with the generic lookdict and then return its result, which may be 
NULL.

--
components: Interpreter Core
messages: 243968
nosy: Jim.Jewett
priority: normal
severity: normal
status: open
title: erroneous comments in dictobject.c
type: enhancement

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24274
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com