[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

[Eric Snow]

Changes by Eric Snow :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

[Roundup Robot]

Roundup Robot added the comment:

New changeset 821663556d87 by Eric Snow in branch 'default':
Issue #24320: Drop an old setuptools-induced hack.
https://hg.python.org/cpython/rev/821663556d87

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:


--
nosy: +Arfrever

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24320
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

[Larry Hastings]

Larry Hastings added the comment:

Then you may fire when ready.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24320
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

[Eric Snow]

Eric Snow added the comment:

Hmm.  Looks like the fix in setuptools/pkg_resources is 17.0. [1]  The bundled 
pip to which we just updated is 7.0.3, which appears to bundle pkg_resources 
15.0. [2]  So unless I've misunderstood, the hack will have to linger for a bit 
longer.

Here's a patch for when we get there.

[1] https://bitbucket.org/pypa/setuptools/commits/tag/17.0
[2] https://github.com/pypa/pip/blob/7.0.3/pip/_vendor/README.rst

--
keywords: +patch
nosy: +dstufft
stage: needs patch - patch review
Added file: http://bugs.python.org/file39599/issue24320-remove-hack.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24320
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

[Larry Hastings]

Larry Hastings added the comment:

Sounds okay in theory.  Is the bug in question now tested in our regression 
suite?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24320
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

[Eric Snow]

Eric Snow added the comment:

https://hg.python.org/cpython/rev/5c4ba50f6a57

I'll see if that does it.

@Larry, would you be opposed to dropping the hack for beta 3?  That would mean 
just deleting the last 2 lines in Lib/importlib/_bootstrap_external.py.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24320
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

[Nick Coghlan]

Nick Coghlan added the comment:

Donald updated 3.5 to pip 7 for the 1st beta, so the relevant fix may have 
already been included.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24320
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
nosy: +larry

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24320
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

[Eric Snow]

Eric Snow added the comment:

Would we be okay fixing this in 3.5 as well?  I ask because I'm not familiar 
with the constraints we have on what pip is bundled.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24320
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

[Eric Snow]

New submission from Eric Snow:

In issue #23911 I worked around a bug [1] in pkg_resources (setuptools) which 
caused test_venv to fail when I split out importlib._bootstrap_external.  That 
bug has now been fixed so we just(?) need to update the version of pip we're 
bundling and remove the hack I put in as a workaround (see msg242440).

[1] https://bitbucket.org/pypa/setuptools/issue/378

--
assignee: eric.snow
messages: 244350
nosy: brett.cannon, eric.snow, ncoghlan
priority: normal
severity: normal
stage: needs patch
status: open
title: Remove a now-unnecessary workaround from importlib._bootstrap.
versions: Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24320
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com