[issue24364] Not all defects pass through email policy

[mike mcleod]

mike mcleod  added the comment:

I would like to help with this issue.

--
nosy: +mikecmcleod

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24364] Not all defects pass through email policy

[R. David Murray]

R. David Murray added the comment:

The name default is future proofing.  It will be the default...eventually :)  
And it is the default now if you use EmailMessage to construct your messages.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24364] Not all defects pass through email policy

[Martin Panter]

Martin Panter added the comment:

I see that “compat32” and “default” are actually different things (Compat32 vs 
EmailPolicy classes). IMO “default” was a bad choice of name, but I guess that 
ship has already sailed.

This patch adds a test_defect_handling.TestCompat32 subclass, so the test 
methods are now run with compat32 as well as the “default” policy.

--
Added file: http://bugs.python.org/file43533/defect-fixes.v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24364] Not all defects pass through email policy

[R. David Murray]

R. David Murray added the comment:

test_email/test_email tests the compat32 policy.  test_defect_handling tests 
the default policy.  Thus they are not redundant, except of course that they 
are...it would be better to run the same test with both policies in turn, but I 
never got as far as setting up that infrastructure.

That said, for defects it may not matter, and for the other "redudant" tests 
sometimes the result is different, which is the point of the new policy.  So, 
things are in a bit of a limbo currently and could use some sorting out.  
You'll note that in some cases in test_email I've noted where the corresponding 
test for the new policy is in the new test files.  There are a bunch more tests 
in test_email that need equivalents for the new policies (and I'm sure we'll 
find some bugs when that happens, unfortunately).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24364] Not all defects pass through email policy

[Martin Panter]

Martin Panter added the comment:

Here is a patch to fix the two defects in Lib/email/feedparser.py. I also made 
some extra changes to the tests:

* Remove some tests from Lib/test/test_email/test_email.py, because I think 
they were redundant with methods of the same name in test_defect_handling.py.

* Change a couple of the tests in test_defect_handling.py to verify there are 
no defects recorded at all even in raise_on_defect=True mode.

--
keywords: +patch
stage: needs patch -> patch review
versions:  -Python 3.4
Added file: http://bugs.python.org/file43486/defect-fixes.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24364] Not all defects pass through email policy

[Martin Panter]

Martin Panter added the comment:

In particular, I noticed InvalidHeaderDefect is not raised if a header line 
begins with a colon (:), and also MisplacedEnvelopeHeaderDefect, if a header 
line begins "From ", including a space, and is neither the first or last line 
of the header section.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24364] Not all defects pass through email policy

[R. David Murray]

New submission from R. David Murray:

This is a note to myself.  While looking at another issue I noticed that I 
never completed the work to make sure that all message defects discovered by 
feedparser are passed through the policy defect handler.  The fix is simple, 
the time consuming part is writing the tests.

--
components: email
keywords: easy
messages: 244679
nosy: barry, r.david.murray
priority: normal
severity: normal
stage: needs patch
status: open
title: Not all defects pass through email policy
type: behavior
versions: Python 3.4, Python 3.5, Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24364
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com