[issue24801] right-mouse click in IDLE on Mac doesn't work

[Terry J. Reedy]

Terry J. Reedy added the comment:

Serhiy, thanks for the review.  I bungled the issue number on the commit 
message, so here are the commit notices.  Will correct for NEWS.

New changeset b79dd0d7dc98 by Terry Jan Reedy in branch '2.7':
Issue #24570: Right-click for context menus now work on Mac Aqual also.
https://hg.python.org/cpython/rev/b79dd0d7dc98

New changeset 51b2b1a821b7 by Terry Jan Reedy in branch '3.4':
Issue #24570: Right-click for context menus now work on Mac Aqual also.
https://hg.python.org/cpython/rev/51b2b1a821b7

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24801] right-mouse click in IDLE on Mac doesn't work

[Mark Roseman]

Mark Roseman added the comment:

Have attached macpopup-revised.patch, incorporating Serhiy's very helpful 
suggestions. Unless there are any other thoughts, this one is probably ready to 
go.

--
Added file: http://bugs.python.org/file40208/macpopup-revised.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24801
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24801] right-mouse click in IDLE on Mac doesn't work

[Mark Roseman]

Mark Roseman added the comment:

There is no notion of middle button on Mac, hence right button is B2. It's 
documented. Current Tk 8.6 has even removed the PasteSelection binding from 
B2 on Aqua because of this (I've filed a Tk bug report to backport this to 
8.5). 8.6 also defines a ContextMenu virtual event, which on Mac is tied to 
B2.

Mac UI guidelines define use of 'right button' (when available) to be used for 
context menu clicks.

So yeah, we should change this. :-)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24801
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24801] right-mouse click in IDLE on Mac doesn't work

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Looks as right button on Mac corresponds to middle button on X Window (paste 
selection and scroll if moved). This behavior is standard for all Tk 
applications. I don't think we should break this.

--
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24801
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24801] right-mouse click in IDLE on Mac doesn't work

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24801
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24801] right-mouse click in IDLE on Mac doesn't work

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Ah, so this is a workaround of 8.5- bug. Then looks reasonable to me.

Added comments on Rietveld.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24801
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24801] right-mouse click in IDLE on Mac doesn't work

[Mark Roseman]

Mark Roseman added the comment:

Have attached macpopup.patch which removes the incorrect Tk behaviour and makes 
it so that right click on Mac will bring up the context menu as appropriate.

--
keywords: +patch
Added file: http://bugs.python.org/file40148/macpopup.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24801
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24801] right-mouse click in IDLE on Mac doesn't work

[Mark Roseman]

Mark Roseman added the comment:

If you have your mouse set up to have two buttons, right-clicking in the editor 
window doesn't bring up the context menu it's supposed to.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24801
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24801] right-mouse click in IDLE on Mac doesn't work

[Terry J. Reedy]

Terry J. Reedy added the comment:

From your description, I an not sure what it is that does not work.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24801
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24801] right-mouse click in IDLE on Mac doesn't work

[Mark Roseman]

Changes by Mark Roseman m...@markroseman.com:


--
components: +IDLE

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24801
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24801] right-mouse click in IDLE on Mac doesn't work

[Mark Roseman]

New submission from Mark Roseman:

For popup menus, control-click works, but right-click on mouse buttons that 
support it, doesn't work.

This is a followup to #10404, last addressed in 2010.

As noted there, right click behaviour should be supported.

The right click Tk text bindings on Mac (which is B2) seem to bind both to the 
virtual 'PasteSelection' event, and also to fast-scroll through a large file is 
you click and drag with the right mouse button. Both of these are blatant 
problems with Tk's text.tcl.

The issue when trying to fix this before was when a B2 (context menu) binding 
was added to the text widget, both that and the bogus B2 bindings fired. This 
is because Tk can fire multiple bindings for a widget (default is bindings for 
the widget itself, the widget's toplevel, the widget's class, and 'all'). 

There is a way to short-circuit this in Tcl (basically the widget-specific 
binding calls 'break', which prevents the others from firing). The simpler 
alternative is probably just redefining the alternative class-level (Text) 
bindings.

In other words, yeah, this should be pretty easily fixable.

--
messages: 248092
nosy: markroseman, ned.deily, ronaldoussoren, terry.reedy
priority: normal
severity: normal
status: open
title: right-mouse click in IDLE on Mac doesn't work
type: behavior
versions: Python 2.7, Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24801
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com