[issue24808] PyTypeObject fields have incorrectly documented types
Martin Panter added the comment: Okay I think that worked smoothly (let me know if I missed something). Thanks for the patch Joseph. -- resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24808 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24808] PyTypeObject fields have incorrectly documented types
R. David Murray added the comment: Congratulation on your first commit, Martin :) Dropping the python2 reference was the right call: the python3 docs are supposed to be a fresh start and there are very few places where they mention python2. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24808 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24808] PyTypeObject fields have incorrectly documented types
Roundup Robot added the comment: New changeset 54a9c649281d by Martin Panter vadmium in branch '3.4': Issue #24808: Update the documentation of some PyTypeObject fields https://hg.python.org/cpython/rev/54a9c649281d New changeset e81d692a00b1 by Martin Panter vadmium in branch '3.5': Issue #24808: Merge 3.4 into 3.5; adjust new tp_as_async field https://hg.python.org/cpython/rev/e81d692a00b1 New changeset 2637e2593f01 by Martin Panter vadmium in branch 'default': Issue #24808: Merge 3.5 into 3.6 https://hg.python.org/cpython/rev/2637e2593f01 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24808 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24808] PyTypeObject fields have incorrectly documented types
Martin Panter added the comment: Most of this looks good. For the record, tp_flags was changed to unsigned in 3.4 (Issue 16086). The const and Py_ssize_t changes were done before 3.0. The only bits I would hesitate about are adding back the two comments saying “Assigned meaning in release 2”. These comments seem to have been removed from the Python 3 documentation in r67578, and I don’t see much point adding them back. I will have a go at committing the rest of the patch. (This is my first time making a commit.) -- assignee: docs@python - martin.panter nosy: +berker.peksag, martin.panter stage: - commit review versions: -Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24808 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24808] PyTypeObject fields have incorrectly documented types
New submission from Joseph Weston: Several fields in the Python 3.x documentation for the PyTypeObject API have incorrectly documented types. This was probably due to a wholesale shift of documentation from Python 2.x. -- assignee: docs@python components: Documentation files: PyTypeObject_documentation.patch keywords: patch messages: 248123 nosy: Joseph Weston, docs@python priority: normal severity: normal status: open title: PyTypeObject fields have incorrectly documented types type: enhancement versions: Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6 Added file: http://bugs.python.org/file40136/PyTypeObject_documentation.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24808 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
