[issue24895] indentation fix in ceval.c in python 2.7

[Roundup Robot]

Roundup Robot added the comment:

New changeset ea2f6fd04307 by Benjamin Peterson in branch '2.7':
remove tabs from ceval.c (closes #24895)
https://hg.python.org/cpython/rev/ea2f6fd04307

--
nosy: +python-dev
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24895] indentation fix in ceval.c in python 2.7

[STINNER Victor]

Changes by STINNER Victor :


--
title: indentation fix in ceval.c -> indentation fix in ceval.c in python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24895] indentation fix in ceval.c

[Antoine Pitrou]

Antoine Pitrou added the comment:

The Python 3 code doesn't have tabs. I'm assuming Benjamin took the original 
patch instead of trying to backport the Python 3 commit.

--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24895] indentation fix in ceval.c

[Laurent Coustet]

Laurent Coustet added the comment:

by the way, the rest of the code did not contain any tab in ceval.c. They were 
added by 17d3bbde60d2

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24895] indentation fix in ceval.c

[R. David Murray]

R. David Murray added the comment:

I couldn't remember either.  Antoine should know, he did the work/commit.

--
nosy: +pitrou, r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24895] indentation fix in ceval.c

[Brett Cannon]

Brett Cannon added the comment:

Thanks for the patch, Laurent.

Can any other core devs remembered if we explicitly untabbed the C source in 
2.7? I know we did in Python 3, but I can't remember if we did it in Python 2 
to make patches easier.

--
nosy: +brett.cannon
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24895] indentation fix in ceval.c

[Laurent Coustet]

New submission from Laurent Coustet:

https://hg.python.org/cpython/rev/17d3bbde60d2

introduced a patch using tabs for indentation in ceval.c.

Attached patch just make the code more consistent by using spaces instead of 
tabs for indentation.


Related to: http://bugs.python.org/issue4753

--
components: Interpreter Core
files: cpython2.7_indentfix_ceval.diff
keywords: patch
messages: 248827
nosy: Laurent Coustet
priority: normal
severity: normal
status: open
title: indentation fix in ceval.c
versions: Python 2.7
Added file: http://bugs.python.org/file40212/cpython2.7_indentfix_ceval.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com