[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Stefan Krah]

Stefan Krah added the comment:

icc on Linux has always worked exactly as gcc, except that -fp-model=strict 
needs to be specified.

I can't test on Windows -- I don't seem to get MSVC licences any more.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[STINNER Victor]

STINNER Victor added the comment:

The two ICC buildbots are now offline. ICC was never really officially 
supported, so I just close this old issue (no activity since the end of 2015).

--
resolution:  -> out of date
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Stefan Krah]

Changes by Stefan Krah :


--
title: ICC compiler: ICC treats denormal floating point numbers as 0.0 -> 
Segfault in test_re.test_sre_character_class_literals() when Python is compiled 
by ICC

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Zachary Ware]

Zachary Ware added the comment:

Unfortunately, #25827 has no effect on Windows, which is where this issue 
occurs.  There are still several segfaults on Windows, including test_re.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Stefan Krah]

Stefan Krah added the comment:

I see, thanks.  I've opened #25934 to keep the issues separate.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Zachary Ware]

Zachary Ware added the comment:

Stefan Krah wrote:
> If anyone worries that "-fp-model strict" will slow
> things down:  In the Python context these settings have
> no measurable impact:  A while ago I tested setting/restoring
> the control word *for every operation*, and even that did
> not have any impact.

If that's the case, would anyone (in particular, Steve, Tim or Tim) mind if we 
just made the default (for MSVC as well as ICC) /fp:strict?  It would be much 
easier to just change the global default than to try to either make it settable 
or to change it just when ICC is used.

As far as the segfault that this issue is actually about, compiling _sre.c with 
/Os seems to clear it up.  I believe Intel is looking into it deeper to 
determine whether it's an ICC bug or if there's something we should change in 
_sre.c.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Stefan Krah]

Stefan Krah added the comment:

> It looks to me that all issues are related to floating points.

You need to compile with "-fp-model strict" or the Windows
equivalent (I think "-fp-model precise").

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Stefan Krah]

Stefan Krah added the comment:

If anyone worries that "-fp-model strict" will slow
things down:  In the Python context these settings have
no measurable impact:  A while ago I tested setting/restoring
the control word *for every operation*, and even that did
not have any impact.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

It looks to me that all issues are related to floating points. 

==
FAIL: test_add (test.test_audioop.TestAudioop)
--
Traceback (most recent call last):
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\test\test_audioop.py",
 line 138, in test_add
datas[w])
AssertionError: b'\x00\x00\x00\x00\x80V4\x12\x80\x89gE\x80v\x98\xba\x00\x00[36 
chars]\xff' != b'\x00\x00\x00\x00xV4\x12\xab\x89gEUv\x98\xba\xff\xff\xff\x[30 
chars]\xff'

==
FAIL: test_tostereo (test.test_audioop.TestAudioop)
--
Traceback (most recent call last):
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\test\test_audioop.py",
 line 438, in test_tostereo
self.assertEqual(audioop.tostereo(data1, w, 1, 0), data2)
AssertionError: b'\x00\x00\x00\x00\x00\x00\x00\x00\x80V4\x[165 chars]\x00' != 
bytearray(b'\x00\x00\x00\x00\x00\x00\x00\x[170 chars]x00')

--

audioop uses double for addition of 32-bit samples and converting to stereo. On 
this platforms it uses only highest 25 bits (including sign) and clears lowest 
7 bit.

Other tests also expose the lost of precision.

==
FAIL: test_from_hex (test.test_float.HexFloatTestCase)
--
Traceback (most recent call last):
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\test\test_float.py",
 line 1228, in test_from_hex
self.identical(fromHex('0x0.d6p-1022'), MIN-3*TINY)
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\test\test_float.py",
 line 939, in identical
self.fail('%r not identical to %r' % (x, y))
AssertionError: 0.0 not identical to 2.2250738585072014e-308

--
==
ERROR: test_specific_values (test.test_cmath.CMathTests)
--
Traceback (most recent call last):
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\test\test_cmath.py",
 line 355, in test_specific_values
actual = function(arg)
ValueError: math domain error

--
==
FAIL: fromhex (builtins.float)
Doctest: builtins.float.fromhex
--
Traceback (most recent call last):
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\doctest.py", line 
2189, in runTest
raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for builtins.float.fromhex
  File "builtins", line unknown line number, in fromhex

--
File "builtins", line ?, in builtins.float.fromhex
Failed example:
float.fromhex('-0x1p-1074')
Expected:
-5e-324
Got:
-0.0


--
==
FAIL: test_bigcomp (test.test_strtod.StrtodTests)
--
Traceback (most recent call last):
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\test\test_strtod.py",
 line 213, in test_bigcomp
self.check_strtod(s)
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\test\test_strtod.py",
 line 104, in check_strtod
"expected {}, got {}".format(s, expected, got))
AssertionError: '0x0.00be3528cp-1022' != '0x0.0p+0'
- 0x0.00be3528cp-1022
+ 0x0.0p+0
 : Incorrectly rounded str->float conversion for 9854e-319: expected 
0x0.00be3528cp-1022, got 0x0.0p+0

==
FAIL: test_boundaries (test.test_strtod.StrtodTests)
--
Traceback (most recent call last):
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\test\test_strtod.py",
 line 190, in test_boundaries
self.check_strtod(s)
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\test\test_strtod.py",
 line 104, in check_strtod
"expected {}, got {}".format(s, expected, got))
AssertionError: '0x0.ep-1022' != '0x0.0p+0'
- 0x0.ep-1022
+ 0x0.0p+0
 : Incorrectly rounded str->float conversion for 22250738585072001874e-327: 
expected 0x0.ep-1022, got 0x0.0p+0

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Tim Peters]

Tim Peters added the comment:

If it were treating doubles as floats, you'd get a lot more failures than this.

Many of these look like clear cases of treating _denormal_ doubles as 0.0, 
though.  I have no experience with ICC, but a quick Google search suggests ICC 
flushes denormals to 0.0 by default, and the compiler flag "no-ftz" (no 
flush-to-zero) is needed to stop that; e.g., see

https://software.intel.com/sites/default/files/article/326703/fp-control-2012-08.pdf

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

test_audioop fails because (int)((double)0x12345678+0.0) is truncated to 
0x12345680 and (int)((double)-0x456789ab+0.0) to -0x45678980.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[R. David Murray]

R. David Murray added the comment:

FYI Intel provided us with a workaround that disables a compiler optimization 
for re and allows the test to not crash.  Zach, can you test no-ftz? Maybe we 
need to apply that to the entire python compile.  Also, can you make sure the 
appropriate person from Intel is nosy on this issue, assuming they have already 
registered?

Tim: any idea why would this only show up on Windows?  Also, if you want a copy 
of ICC to play with, we can arrange that.
 
I wonder if this issue has any effect on Intel's numpy support.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Mark Dickinson]

Changes by Mark Dickinson :


--
nosy: +mark.dickinson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[STINNER Victor]

STINNER Victor added the comment:

pylong_digits.patch: new patch add two local inlined functions 
_PyLong_AsDigits() and _PyLong_FromDigits() to make the code more readable. 
Does it look good to you?

I chose two shifts since only Tim Peters has an opinion on it, and he prefers 
two shifts :-)

--
Added file: http://bugs.python.org/file40513/pylong_digits.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This variant look overcomplicated to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[STINNER Victor]

STINNER Victor added the comment:

> This variant look overcomplicated to me.

Ok fine. I pushed  pylong_digits.patch, but I also modified a similar code a 
few lines below.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Roundup Robot]

Roundup Robot added the comment:

New changeset 21076e24cd8a by Victor Stinner in branch '3.5':
Issue #24999: In longobject.c, use two shifts instead of ">> 2*PyLong_SHIFT" to
https://hg.python.org/cpython/rev/21076e24cd8a

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I'm fine with both variants: (LONG_MAX >> PyLong_SHIFT) >> PyLong_SHIFT and 
SIZEOF_LONG*CHAR_BIT-1 >= 2*PyLong_SHIFT (the latter can be simplified to 
8*SIZEOF_LONG > 2*PyLong_SHIFT). A comment on the next line explains the 
condition, it can be extended if needed. I'm fine with Victor's patch too.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Stefan Krah]

Stefan Krah added the comment:

Thanks, I've contacted Robert.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[STINNER Victor]

STINNER Victor added the comment:

Zachary Ware added the comment:
> To be fair, other buildbots are also segfaulting (or otherwise silently 
> failing) on those:

Sorry, the following issues are unrelated.

> 3.4 on XP, test_json:
> http://buildbot.python.org/all/builders/x86%20XP-4%203.4/builds/1190/steps/test/logs/stdio

This one is old. We don't really support Windows XP. If I recall
correctly, Windows XP doesn't handle correctly stack overflow.

> 3.5 on 7, test_tokenize:
> http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.5/builds/250/steps/test/logs/stdio

This is a timeout, not a crash.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Zachary Ware]

Zachary Ware added the comment:

Note: the ICC buildbot does fail much more consistently on those.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Zachary Ware]

Zachary Ware added the comment:

Stefan Krah commented:
> The buildbot segfaults all over the place, also in test_tokenize
> and test_json:

To be fair, other buildbots are also segfaulting (or otherwise silently 
failing) on those: 

3.4 on XP, test_json:
http://buildbot.python.org/all/builders/x86%20XP-4%203.4/builds/1190/steps/test/logs/stdio
3.5 on 7, test_tokenize:
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.5/builds/250/steps/test/logs/stdio

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Stefan Krah]

Stefan Krah added the comment:

Yes, according to C99 the shift is undefined:

6.5.7:

"If the value of the right operand is negative or is greater than
 or equal to the width of the promoted left operand, the behavior
 is undefined."

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Stefan Krah]

Stefan Krah added the comment:

Perhaps the stack overflow hypothesis applies here, too.

You could try changing Py_DEFAULT_RECURSION_LIMIT in ceval.c
to lower values.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[R. David Murray]

R. David Murray added the comment:

Ah, interesting.  We know that there are stack overflow issues on the ICC 
windows build (they show up consistently in a debug build).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Stefan Krah]

Stefan Krah added the comment:

Visual studio apparently has the option /F to set the stack size.
Maybe ICC has one, too.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[R. David Murray]

R. David Murray added the comment:

By the way Stefan, if you want a copy of the ICC compiler to test with, you can 
contact robert.s.c...@intel.com.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Stefan Krah]

Stefan Krah added the comment:

The buildbot segfaults all over the place, also in test_tokenize
and test_json:

http://buildbot.python.org/all/builders/x86-64%20Windows%20Server%202012R2%20ICC%203.x/builds/89/steps/test/logs/stdio


Running the tests under the VS debugger is probably the fastest way to find out 
why (I don't have the Intel compiler).

--
nosy: +skrah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
nosy: +tim.peters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Tim Peters]

Tim Peters added the comment:

The longobject.c warnings are almost certainly unrelated to the test_re crash.

If shifting right twice (adding parens for clarity):

(LONG_MAX >> PyLong_SHIFT) >> PyLong_SHIFT.

squashes the warnings, that would be a substantially clearer way to express the 
intent than the

SIZEOF_LONG*CHAR_BIT-1 >= 2*PyLong_SHIFT

spelling.  Adding a comment *explaining* the intent would be even better.

For the segfault issue, best guess is that it's a compiler optimization bug.  
Not common as mud, or even as common as nuisance warnings, but not all that 
rare either ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[STINNER Victor]

New submission from STINNER Victor:

The crash occurred on the buildbot "x86-64 Windows Server 2012R2 ICC 3.x".

Do you we officially support the ICC compiler?

--

There are still some curious compiler warnings:

Objects\longobject.c(4498): warning #63: shift count is too large
=> "#if LONG_MAX >> 2*PyLong_SHIFT"
Objects\longobject.c(4519): warning #63: shift count is too large
=> "#if LONG_MAX >> 2*PyLong_SHIFT"

I don't understand the test: do we test if the result is zero?

On Windows, a long is only 32-bits. I guess that PyLong_SHIFT is 30 (so 
2*PyLong_SHIFT=60).

Maybe we should put "#elif defined(PY_LONG_LONG) && PY_LLONG_MAX >> 
2*PyLong_SHIFT" before?

--

The crash itself:


http://buildbot.python.org/all/builders/x86-64%20Windows%20Server%202012R2%20ICC%203.x/builds/83/steps/test/logs/stdio

[ 14/398] test_re
Fatal Python error: Segmentation fault

Current thread 0x0578 (most recent call first):
  File "C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\re.py", 
line 163 in match
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\test\test_re.py", 
line 976 in test_sre_character_class_literals
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\unittest\case.py", 
line 600 in run
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\unittest\case.py", 
line 648 in __call__
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\unittest\suite.py",
 line 122 in run
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\unittest\suite.py",
 line 84 in __call__
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\unittest\suite.py",
 line 122 in run
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\unittest\suite.py",
 line 84 in __call__
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\unittest\suite.py",
 line 122 in run
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\unittest\suite.py",
 line 84 in __call__
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\unittest\runner.py",
 line 176 in run
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\test\support\__init__.py",
 line 1775 in _run_suite
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\lib\test\support\__init__.py",
 line 1809 in run_unittest
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\PCbuild\..\lib\test\regrtest.py",
 line 1280 in test_runner
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\PCbuild\..\lib\test\regrtest.py",
 line 1281 in runtest_inner
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\PCbuild\..\lib\test\regrtest.py",
 line 968 in runtest
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\PCbuild\..\lib\test\regrtest.py",
 line 763 in main
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\PCbuild\..\lib\test\regrtest.py",
 line 1565 in main_in_temp_cwd
  File 
"C:\Users\buildbot\buildarea\3.x.intel-windows-icc\build\PCbuild\..\lib\test\regrtest.py",
 line 1590 in 

--
components: Build, Windows
messages: 249749
nosy: haypo, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Segfault in test_re.test_sre_character_class_literals() when Python is 
compiled by ICC
type: crash
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[STINNER Victor]

STINNER Victor added the comment:

Zachary Ware is the administrator of the buildbot.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[R. David Murray]

R. David Murray added the comment:

We don't officially support ICC yet, but the buildbots are a step in the 
direction of proposing that we do.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

> I don't understand the test: do we test if the result is zero?

We test that signed long is enough to contain 2 digits. May be it should be 
written as LONG_MAX >> PyLong_SHIFT >> PyLong_SHIFT.

> Maybe we should put "#elif defined(PY_LONG_LONG) && PY_LLONG_MAX >> 
> 2*PyLong_SHIFT" before?

No. We need to use long long only if long is not enough.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Zachary Ware]

Changes by Zachary Ware :


--
stage:  -> needs patch
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Zachary Ware]

Zachary Ware added the comment:

Another lovely facet of this segfault: it doesn't occur when built in Debug 
configuration.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[STINNER Victor]

STINNER Victor added the comment:

> The condition is equivalent to SIZEOF_LONG*CHAR_BIT-1 >= 2*PyLong_SHIFT on 
> binary computers with two-complementarn two's-complement integers. But 
> current form looks more natural to me.

Oh by the way: I have no idea if the test_re crash is related to this warning 
:-) I don't plan to install ICC to reproduce the issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[STINNER Victor]

STINNER Victor added the comment:

> We test that signed long is enough to contain 2 digits. May be it should be 
> written as LONG_MAX >> PyLong_SHIFT >> PyLong_SHIFT.

Ok, but I don't understand "if ". Does it mean "if 
 != 0"?

Maybe we can use SIZEOF_LONG instead of LONG_MAX?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Yes, it means "if  != 0".

The condition is equivalent to SIZEOF_LONG*CHAR_BIT-1 >= 2*PyLong_SHIFT on 
binary computers with two-complementarn two's-complement integers. But current 
form looks more natural to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24999] Segfault in test_re.test_sre_character_class_literals() when Python is compiled by ICC

[Zachary Ware]

Zachary Ware added the comment:

Replacing the two instances of "LONG_MAX >> 2*PyLong_SHIFT" with 
"SIZEOF_LONG*CHAR_BIT-1 >= 2*PyLong_SHIFT" fixes the warnings, but does nothing 
for test_re.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com