[issue25002] Deprecate asyncore/asynchat

[Barry A. Warsaw]

Barry A. Warsaw added the comment:

For the archaeologists of the future, smtpd.py is also deprecated in favor of 
aiosmtpd.

http://aiosmtpd.readthedocs.io/en/latest/

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Guido van Rossum]

Guido van Rossum added the comment:

Sounds good.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[STINNER Victor]

STINNER Victor added the comment:

I suggest to close this issue and instead work on the the issue #28533: modify 
code using asyncore to use something else.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Giampaolo Rodola']

Changes by Giampaolo Rodola' :


--
nosy: +giampaolo.rodola

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Guido van Rossum]

Guido van Rossum added the comment:

OK, backed out the code changes, kept the docs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Roundup Robot]

Roundup Robot added the comment:

New changeset 6eb3312a9a16 by Guido van Rossum in branch '3.6':
Issue #25002: Back out asyncore/asynchat deprecation.
https://hg.python.org/cpython/rev/6eb3312a9a16

New changeset 2879185bc511 by Guido van Rossum in branch 'default':
Issue #25002: Back out asyncore/asynchat deprecation. (3.6->3.7)
https://hg.python.org/cpython/rev/2879185bc511

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Martin Panter]

Martin Panter added the comment:

Perhaps it is okay to keep the documentation changes, but I think either the 
library changes should be reverted or worked around where the modules are still 
in use.

I normally run the tests with -Werror, and the failures I get are:

* test_ssl, test_smtplib, test_poplib, test_logging, test_ftplib, test_support: 
tests use asyncore
* test_os: test uses asynchat (When you import asynchat, the first error 
complains about importing asyncore, there are actually two warnings)
* test_all: This seems to ignore DeprecationWarning; perhaps an exception for 
PendingDeprecationWarning should also be added?
* test_asyncore and test_asynchat: Obviously these have to still test the 
modules, so they should anticipate the warnings, perhaps using Serhiy’s code
* test_smtpd: smtpd module itself uses asyncore; see Issue 25008

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[STINNER Victor]

STINNER Victor added the comment:

R. David Murray added the comment:
> The alternative has already been written: aiosmtpd, in the aiolibs
project.  The question is should it be added to the stdlib...

I suggest to keep it on PyPI to keep fast releases.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Guido van Rossum]

Guido van Rossum added the comment:

Serhiy, so should I revert this patch for now? Or are the silent
deprecation warnings outside the test suite okay? (In that case, maybe
Mariatta can upload a patch?)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[R. David Murray]

R. David Murray added the comment:

The alternative has already been written: aiosmtpd, in the aiolibs project.  
The question is should it be added to the stdlib...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Thanks Serhiy, 

I created these two tickets:
https://bugs.python.org/issue28534
https://bugs.python.org/issue28533

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Ah, asyncore/asynchat are used in smtpd!

It looks to me that we should first write asyncio alternative to smtpd, then 
deprecate smtpd, and only after this we can deprecate asyncore/asynchat.

--
dependencies: +Deprecate smtpd (based on deprecated asyncore/asynchat): write a 
new smtp server with asyncio

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

> Should I create a different ticket about replacing asyncore and asynchat?

This may require several tickets, one per case.

--
components: +Library (Lib)
resolution: fixed -> 
stage:  -> needs patch
type:  -> enhancement
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Sorry about this Serhiy. I can work on another patch based on your code snippet 
later today.

Should I create a different ticket about replacing asyncore and asynchat?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I think replacing

import asynchat
import asyncore

with

with warnings.catch_warnings():
warnings.simplefilter('ignore', PendingDeprecationWarning)
import asynchat
import asyncore

can help.

asynchat and asyncore are used in several tests.

In long term asynchat and asyncore should be replaced with alternatives.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Guido van Rossum]

Guido van Rossum added the comment:

Sorry about that. Should I roll it back or is there a way to make the test pass 
(expect this deprecation)?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This change broke buildbots.

$ ./python -We -m test.regrtest test_os 
Run tests sequentially
0:00:00 [1/1] test_os
test test_os crashed -- Traceback (most recent call last):
  File "/home/serhiy/py/cpython/Lib/test/libregrtest/runtest.py", line 151, in 
runtest_inner
the_module = importlib.import_module(abstest)
  File "/home/serhiy/py/cpython/Lib/importlib/__init__.py", line 126, in 
import_module
return _bootstrap._gcd_import(name[level:], package, level)
  File "", line 978, in _gcd_import
  File "", line 961, in _find_and_load
  File "", line 950, in _find_and_load_unlocked
  File "", line 655, in _load_unlocked
  File "", line 677, in exec_module
  File "", line 205, in _call_with_frames_removed
  File "/home/serhiy/py/cpython/Lib/test/test_os.py", line 5, in 
import asynchat
  File "/home/serhiy/py/cpython/Lib/asynchat.py", line 48, in 
import asyncore
  File "/home/serhiy/py/cpython/Lib/asyncore.py", line 65, in 
PendingDeprecationWarning, stacklevel=2)
PendingDeprecationWarning: asyncore module is deprecated in 3.6. Use asyncio 
instead.

test_os failed

1 test failed:
test_os

Total duration: 59 ms
Tests result: FAILURE

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Roundup Robot]

Roundup Robot added the comment:

New changeset bb23770f82f1 by Guido van Rossum in branch '3.6':
Issue 25002: Deprecate asyncore/asynchat. Patch by Mariatta.
https://hg.python.org/cpython/rev/bb23770f82f1

New changeset 3b8dfe6f5bcb by Guido van Rossum in branch 'default':
Issue 25002: Deprecate asyncore/asynchat. Patch by Mariatta. (3.6->3.7)
https://hg.python.org/cpython/rev/3b8dfe6f5bcb

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Guido van Rossum]

Guido van Rossum added the comment:

Applied:

remote: notified python-check...@python.org of incoming changeset bb23770f82f1
remote: notified python-check...@python.org of incoming changeset 3b8dfe6f5bcb

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Hi,

Attached is the patch that adds pending deprecation warnings to asyncore and 
asynchat. Please review. Thanks :)

--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45210/issue25002.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Mark Lawrence]

Mark Lawrence added the comment:

IIRC I flagged up oustanding asyncore/asynchat issues months or even years back 
and Victor closed a lot down, so there shouldn't be many left to deal with.

--
nosy: +BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[R. David Murray]

R. David Murray added the comment:

Yes, stopping changing asyncore/asynchat also means it becomes a stable target 
for people who *are* using it for 2/3 code.  We may have effectively done this 
already (without closing the open issues): the last asyncore-specific change 
(as opposed to library-wide changes that also hit asyncore) was a 
ResourceWarning added by Victor in June of 2014.  Likewise for asynchat.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[STINNER Victor]

STINNER Victor added the comment:

If you care of smooth python 2 => python 3 migration, I suggest to
deprecate smtpd and remove it later, when asyncore & asynchat will
also be removed (ex: in Python 4?).

I suggest to write a *new* SMTP server module using asyncio. As I
explained, the API will be very different for the user of the API.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Brett Cannon]

Brett Cannon added the comment:

Victor's suggestion also aligns with my thinking on the subject as well: 
deprecate the modules but simply leave them sitting there for compatibility 
reasons until Python 4 of whenever we feel like the Python 2 transition is done 
for those that will ever bother making the switch. That way people's 
expectations are in the proper alignment of where things will end up and code 
won't break if it straddles Python 2 & 3 short of having to silence a 
deprecation warning. I think this is a good use of PendingDeprecationWarning 
and the message both in the deprecation and the docs can make it clear that the 
removal date is not planned but you should avoid using the module in new code.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Guido van Rossum]

Guido van Rossum added the comment:

> Is it ok to add the PendingDeprecationWarning in Python 3.5.1?

I prefer to wait until 3.6.  A bugfix release should not rock the boat, it 
should not make your code emit new warnings.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[STINNER Victor]

STINNER Victor added the comment:

> Ideally these modules should emit a deprecation warning starting in 3.6

Is it ok to add the PendingDeprecationWarning in Python 3.5.1?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Raymond Hettinger]

Raymond Hettinger added the comment:

In addition to a PendingDeprecationWarning in 3.6, it might be nice to put a 
note in the asyncore/asynchat docs like we did for optparse.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Barry A. Warsaw]

Barry A. Warsaw added the comment:

On Sep 04, 2015, at 08:55 PM, STINNER Victor wrote:

>Maybe it can be fun to rewrite the module using asyncio, but I'm not
>convinced that a SMTP server in the Python stdlib is super useful.

As I mentioned in issue25008, removing smtpd would be a hardship for myself,
and I don't think I'm alone.  I would however love to have (and maybe even
work on ) an asyncio-based version.  I do think it is useful to have an
SMTP server in the stdlib - and actually, I'd also like to have an LMTP server
there too.  But I think we can take baby steps toward this by some folks
getting together and writing a third party asyncio-based module, releasing
this on PyPI and eventually leading to its inclusion in Python down the road.
I think there's no hurry to remove smtpd, but it can be deprecated-in-place
like optparse, as someone else mentioned.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Brett Cannon]

Brett Cannon added the comment:

I opened http://bugs.python.org/issue25008 to discuss deprecating smtpd since 
this issue is about asyncore/asynchat.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Guido van Rossum]

New submission from Guido van Rossum:

Now that we've got asyncio in two releases (3.4 and 3.5) we should start 
deprecating asyncore and asynchat. There isn't much use of these in the stdlib 
(smtpd.py uses them, and a bunch of tests) and we should probably rewrite those 
to use asyncio. Maybe smtpd.py can be deprecated itself.

--
messages: 249829
nosy: gvanrossum
priority: normal
severity: normal
status: open
title: Deprecate asyncore/asynchat
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[STINNER Victor]

STINNER Victor added the comment:

The documentation of both modules begin with the following note:

"This module exists for backwards compatibility only. For new code we recommend 
using asyncio."

What do you mean by deprecating the module? Emit a PendingDeprecationWarning in 
Python 3.6 and emit a DeprecationWarning in Python 3.7?

> Maybe smtpd.py can be deprecated itself.

Maybe it can be fun to rewrite the module using asyncio, but I'm not convinced 
that a SMTP server in the Python stdlib is super useful.

(A HTTP server *is* very useful, it saved my life multiple times when I worked 
on embedded devices without any server available to transfer files.)

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Donald Stufft]

Donald Stufft added the comment:

I'm all for deprecating asyncore/asynchat but should deprecating them wait 
until asyncio is no longer provisional?

--
nosy: +dstufft

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Guido van Rossum]

Guido van Rossum added the comment:

Yes, in 3.6 asyncio will no longer be provisional and we can start deprecating 
async{ore,hat}. Which is why I marked this bug with 3.6.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Guido van Rossum]

Changes by Guido van Rossum :


--
nosy: +barry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Brett Cannon]

Changes by Brett Cannon :


--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Eric V. Smith]

Eric V. Smith added the comment:

I use smtpd.py for testing my code. But it's not such a big deal that I 
couldn't live without it. If I have some time to burn, I might convert it to 
asyncio so I can continue to use it.

--
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[Guido van Rossum]

Guido van Rossum added the comment:

Ideally these modules should emit a deprecation warning starting in 3.6 (when 
asyncio is no longer provisional) and we should strive to delete them per 3.8.

If nobody rewrites smptd.py using asyncio it should be deleted at the same time.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25002] Deprecate asyncore/asynchat

[R. David Murray]

R. David Murray added the comment:

smtpd is used for testing smtplib.  It is also used in test_logging.  I would 
object to having it removed, but I suspect we can manage to rewrite it by 3.8.  
Maybe Eric and I can collaborate on it.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com