[issue25066] Better repr for multiprocessing.synchronize objects

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset af6b4068859a5d0c8afd696f3c0c0155660211a4 by Kumar Aditya in 
branch 'main':
bpo-25066: Added repr for multiprocessing.Event (GH-29749)
https://github.com/python/cpython/commit/af6b4068859a5d0c8afd696f3c0c0155660211a4


--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25066] Better repr for multiprocessing.synchronize objects

[Kumar Aditya]

Change by Kumar Aditya :


--
keywords: +patch
nosy: +kumaraditya303
nosy_count: 7.0 -> 8.0
pull_requests: +27986
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/29749

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25066] Better repr for multiprocessing.synchronize objects

[Andrei Kulakov]

Andrei Kulakov  added the comment:

Nihir: in synchronize.py, only Barrier inherits from threading.Barrier, as far 
as I can see. Other classes inherit from `object`.

--
nosy: +andrei.avk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25066] Better repr for multiprocessing.synchronize objects

[Nihir Patel]

Nihir Patel  added the comment:

Given https://github.com/python/cpython/pull/20534 is merged and the 
multiprocessing.synchronize objects inherit from the corresponding threading 
module objects, is this still needed?

--
nosy: +nihir27

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25066] Better repr for multiprocessing.synchronize objects

[Irit Katriel]

Irit Katriel  added the comment:

The patch need to be converted to a GitHub PR.

--
keywords: +easy -patch
nosy: +iritkatriel
stage: patch review -> needs patch
versions: +Python 3.11 -Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25066] Better repr for multiprocessing.synchronize objects

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25066] Better repr for multiprocessing.synchronize objects

[Davin Potts]

Davin Potts added the comment:

To Antoine's point in issue24391, here too, these modifications to the format 
of the repr are estimated to have very little impact or risk to breaking 
existing code.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25066] Better repr for multiprocessing.synchronize objects

[Davin Potts]

Davin Potts added the comment:

This patch implements the majority opinion from issue24391 for the desired 
format of the reprs produced by Event, Semaphore, BoundedSemaphore, and 
Barrier.  It provides tests around each, inspired by Serhiy's preliminary patch 
for that same issue but adapted for multiprocessing.

These tests pass on all but 2 -- it is expected that those 2 will pass once the 
threading module has been similarly updated as some of the combinatoric tests 
leverage threading.Event in some cases and multiprocessing.Event in others (and 
so on for the other synchronization objects).  At present, Serhiy's patch still 
needs updating to match the majority opinion on the repr format, hence it could 
not yet be applied in combination with this patch for testing.  Tests thus far 
have been performed on OS X 10.10.3.

--
keywords: +patch
stage: needs patch -> patch review
Added file: 
http://bugs.python.org/file40432/issue_25066_sync_objects_reprs.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25066] Better repr for multiprocessing.synchronize objects

[Davin Potts]

Changes by Davin Potts :


--
dependencies: +Better repr for threading objects

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25066] Better repr for multiprocessing.synchronize objects

[Davin Potts]

New submission from Davin Potts:

Inspired by issue24391 and the changes proposed to the threading module's reprs 
for Event, Semaphore, BoundedSemaphore, and Barrier, the corresponding objects 
in the multiprocessing module should have their reprs updated accordingly.

--
assignee: davin
components: Library (Lib)
messages: 250443
nosy: davin, jnoller, sbt
priority: normal
severity: normal
stage: needs patch
status: open
title: Better repr for multiprocessing.synchronize objects
type: enhancement
versions: Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com