[issue25111] Broken compatibility in FrameSummary equality

2015-09-29 Thread STINNER Victor 

STINNER Victor added the comment:

traceback_FrameSummary_equality_2.patch looks good to me, but I have the same 
remark than Berker (see the review).

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25111] Broken compatibility in FrameSummary equality

2015-09-29 Thread Robert Collins 

Robert Collins added the comment:

LGTM too.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25111] Broken compatibility in FrameSummary equality

2015-09-29 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 2ecb7d4d9e0b by Serhiy Storchaka in branch '3.5':
Issue #25111: Fixed comparison of traceback.FrameSummary.
https://hg.python.org/cpython/rev/2ecb7d4d9e0b

New changeset f043182a81d7 by Serhiy Storchaka in branch 'default':
Issue #25111: Fixed comparison of traceback.FrameSummary.
https://hg.python.org/cpython/rev/f043182a81d7

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25111] Broken compatibility in FrameSummary equality

2015-09-29 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25111] Broken compatibility in FrameSummary equality

2015-09-28 Thread Berker Peksag 

Berker Peksag added the comment:

LGTM

+self.assertEqual(f, tuple(f))
+self.assertEqual(tuple(f), f)

It would be good to add a comment to explain why we test both variants, but 
it's not really important.

--
nosy: +berker.peksag
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25111] Broken compatibility in FrameSummary equality

2015-09-27 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

Ping.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25111] Broken compatibility in FrameSummary equality

2015-09-18 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

Fixed patch and added tests.

--
Added file: 
http://bugs.python.org/file40500/traceback_FrameSummary_equality_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25111] Broken compatibility in FrameSummary equality

2015-09-14 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
keywords: +patch
Added file: 
http://bugs.python.org/file40463/traceback_FrameSummary_equality.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25111] Broken compatibility in FrameSummary equality

2015-09-14 Thread Serhiy Storchaka 

New submission from Serhiy Storchaka:

Since 3.5 traceback.extract_tb() and traceback.extract_stack() return a list 
(actually list's subclass StackSummary) of FrameSummary objects instead of a 
list of tuples. FrameSummary is not fully compatible with tuple. One important 
incompatibility is in the comparing.

>>> import traceback
>>> traceback.extract_stack()[0] == ('', 1, '', '')
Traceback (most recent call last):
  File "", line 1, in 
  File "/home/serhiy/py/cpython-3.5/Lib/traceback.py", line 254, in __eq__
return (self.filename == other.filename and
AttributeError: 'tuple' object has no attribute 'filename'

In general __eq__ shouldn't raise an exception. Issue25108 is needed to be 
fixed first for tests.

Here is a patch that restores compatibility.

An alternative solution would be to make FrameSummary a subclass of tuple 
(namedtuple).

--
components: Library (Lib)
messages: 250693
nosy: rbcollins, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Broken compatibility in FrameSummary equality
type: behavior
versions: Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com